Commits · 8d2f0722f2dd629226fc125423807f8fdea10943 · Administrator / Openfire

06 Jan, 2016 5 commits

Merge pull request #492 from sco0ter/smDelay · 8d2f0722
Guus der Kinderen authored Jan 06, 2016
```
Don't add multiple delayed delivery extension to resent messages.
```
8d2f0722
Merge pull request #490 from sco0ter/websocket · 5b11857d
Dave Cridland authored Jan 06, 2016
```
WebSocket plugin: Fix wrong namespace adding to empty elements
```
5b11857d

Don't add multiple delayed delivery extension to resent messages. · 81363d82

Christian Schudt authored Jan 06, 2016

The issue is that messages, which get resent from offline storage already have an older timestamp.

There should not be another delayed delivery extension, which "overwrites" the old one.

Messages looked like that:
<message><body>...</body><delay xmlns="urn:xmpp:delay" stamp="2016-01-06T13:48:45.312Z"></delay><delay xmlns="urn:xmpp:delay" stamp="2016-01-06T13:49:56.674Z"></delay></message>

Instead the original timestamp should be preserved.

81363d82

WebSocket plugin: Fix wrong namespace adding to empty elements · 3a3faad1

Christian Schudt authored Jan 06, 2016

The old logic produced XML like:
<presence xmlns="jabber:client" from="..." to="..."><show xmlns="">xa</show><status xmlns=""/></presence>

This is basically the same fix as in 6965c13e.

Relates to OF-938.

3a3faad1

Merge pull request #488 from guusdk/logging · 632eec6f
Dave Cridland authored Jan 06, 2016
```
Remove verbose logging
```
632eec6f

05 Jan, 2016 17 commits

Merge pull request #489 from guusdk/OF-1009 · 4e8614b1
Tom Evans authored Jan 05, 2016
```
OF-1009: Allow non-TLS dialback
```
4e8614b1
OF-1009: Allow non-TLS dialback · 37588e0f
Guus der Kinderen authored Jan 05, 2016
```
When a TLS failure occurs during dialback, allow for a non-TLS
based fallback.
```
37588e0f

Remove verbose logging · 66e91ee3

Guus der Kinderen authored Jan 05, 2016

This class logged to debug on any property change (including properties
that do not relate to the class itself).

66e91ee3

Merge pull request #479 from guusdk/s2s · 056012e1
Dave Cridland authored Jan 05, 2016
```
S2S logging
```
056012e1
Merge pull request #481 from tevans/OF-1023 · 39d00f52
Dave Cridland authored Jan 05, 2016
```
OF-1023: Fire contactChanged/Deleted events
```
39d00f52
Merge pull request #483 from guusdk/OF-999 · f6f3df47
Dave Cridland authored Jan 05, 2016
```
OF-999: Allow configuration of BOSH worker thread pool
```
f6f3df47
Merge pull request #485 from guusdk/OF-998 · 5fd38241
Dave Cridland authored Jan 05, 2016
```
OF-998: Ant should resolve DTDs locally
```
5fd38241
Merge pull request #487 from guusdk/OF-1025 · 20eb8c48
Dave Cridland authored Jan 05, 2016
```
OF-1025: Restore web-custom.xml functionality
```
20eb8c48
Merge pull request #484 from guusdk/OF-1000 · f77c0399
Tom Evans authored Jan 05, 2016
```
OF-1000 Prevent NPE and improve logging
```
f77c0399
Merge pull request #474 from anuko/master · aa0cf333
Tom Evans authored Jan 05, 2016
```
Fixed group population for colliding full names.
```
aa0cf333
Merge pull request #478 from tevans/OF-122 · bdef6ba7
Tom Evans authored Jan 05, 2016
```
OF-122: MUC subject change policy
```
bdef6ba7
Merge pull request #473 from ishmakov/invitationrejection-delegate · a1c498cd
Tom Evans authored Jan 05, 2016
```
MUC Invitation rejection delegate call
```
a1c498cd

OF-1025: Restore web-custom.xml functionality · 770fee82

Guus der Kinderen authored Jan 05, 2016

For some reason, XPath-based selection of nodes no longer works. Traversing
the Dom4j object resolves that problem.

770fee82

Merge pull request #480 from guusdk/random · 736b76f1
Dave Cridland authored Jan 05, 2016
```
Improve quality of random data generation.
```
736b76f1

OF-998: Ant should resolve DTDs locally · d3f242e7

Guus der Kinderen authored Jan 05, 2016

Ant (or rather, the XMLTask in our build) attempts to lookup DTDs
online. The build (of plugins) will fail if no internet connectivity
is available. This commit references DTDs locally, allowing Ant to
skip the online lookup.

d3f242e7

OF-1000 Prevent NPE and improve logging · 1afdefef

Guus der Kinderen authored Jan 05, 2016

When a log directory cannot be created, a warning should be logged,
and null pointers should be prevented when the directory is being
referenced.

1afdefef

OF-999: Allow configuration of BOSH worker thread pool · 9bb61406

Guus der Kinderen authored Jan 05, 2016

The thread pool that performs processing of data received through the HTTP-based
connections of BOSH (as provided by Jetty) should not have a hardcoded upper bound.
Instead, the pool size should be configurable.

For other connection types, this is managed by properties named as such:
 - xmpp.client.processing.threads (client sockets)
 - xmpp.multiplex.processing.threads (connection managers)
 - xmpp.component.processing.threads (components)

BOSH does have a similar property: httpbind.client.processing.threads
It's value however is not used to configure the amount of worker threads. It is
used to configure the amount of (NIO) acceptors instead. In NIO, acceptor
threads handle network IO, and hand off processing to the worker threads.

There's little benefit in being able to configure the amount of acceptors, as
Jetty will default to a platform-specific default (based on the number of CPUs
that are available). There is greater benefit in being able to configure the
amount of worker threads (as that's more likely to affect throughput).

9bb61406

04 Jan, 2016 16 commits

OF-122: Use strict policy by default · 7ef6b4a7

Tom Evans authored Jan 04, 2016

Per PR feedback, default to a strict (conforming) policy when detecting
MUC room subject change requests.

Additional work could be done to add a corresponding configuration
option to the MUC service admin console, but is not included in the
scope of this PR.

7ef6b4a7

Use StreamIDFactory when generating Stream IDs · 579a8247

Guus der Kinderen authored Jan 04, 2016

StreamIDFactory is designed to generate stream IDs. It's silly to use
something else when generating stream IDs.

579a8247

OF-1023: Fire contactChanged/Deleted events · eca7b458

Tom Evans authored Jan 04, 2016

When a shared group is removed from a roster item, fire an update or
delete event to keep the corresponding Roster cache in sync.

eca7b458

Improve random distribution of generated stream IDs · 8073bab7

Guus der Kinderen authored Jan 04, 2016

Stream ID generation should be based on a strong random number generator,
should use a wider variety of characters than just hexadecimals, and
could be a bit larger for reduced chance of duplicates.

8073bab7

Default to strong RNG for encryption. · 08eb2993
Guus der Kinderen authored Jan 04, 2016

08eb2993
Default to strong RNG for random strings. · ccfee2ea
Guus der Kinderen authored Jan 04, 2016

ccfee2ea
Improved Dialback logging · 2490aba5
Guus der Kinderen authored Jan 04, 2016
```
Clarified the role in which Dialback is acting.
```
2490aba5

Remove unused code. · c4868c2c

Guus der Kinderen authored Jan 04, 2016

Reduced code complexity by removing code for which there is no execution path.

c4868c2c

Reduce code duplication and fix logging. · 7d9a8bc8

Guus der Kinderen authored Jan 04, 2016

This commit reduced duplicated code that creates a socket to any
of the DNS-SRV-based hosts for an XMPP domain by moving that code
to a new utility class.

Additionally, S2S logging was improved: references to 'remote hosts'
where replaced by 'remote domains' to differentiate between servers
and domains (that can consist of multiple servers).

7d9a8bc8

Merge pull request #477 from sco0ter/languageTag · c58efa58
Guus der Kinderen authored Jan 04, 2016
```
xml:lang in stream header should conform to a language tag.
```
c58efa58
xml:lang in stream header should conform to a language tag. · c07d3f93
Christian Schudt authored Jan 04, 2016
```
toString() was called on the Locale here, resulting e.g. in "de_DE".
Instead it should be "de-DE".
```
c07d3f93
Merge pull request #476 from guusdk/s2s · 6238ec6a
daryl herzmann authored Jan 04, 2016
```
Improving logging for S2S / dialback
```
6238ec6a

OF-122: MUC subject change policy · bc5faf4b

Tom Evans authored Jan 04, 2016

Default to lenient policy, allowing override to strict (conforming)
policy. Tested using Pidgin, Psi, and Exodus. Refer to details in
OF-122.

bc5faf4b

Merge pull request #475 from wrooot/patch-2 · 193091d7
Guus der Kinderen authored Jan 04, 2016
```
Add explanation to setup about default admin password
```
193091d7
Merge pull request #472 from ishmakov/really-all-resources-fix · 75692253
Guus der Kinderen authored Jan 04, 2016
```
Fix twice sending of messages on route.really-all-resources=true
```
75692253

Improving logging for S2S / dialback · 8ad81f2f

Guus der Kinderen authored Jan 04, 2016

The S2S (federation) code was not big on logging. This commit
introduces new logging, and structures the logged messages.
This commit does not introduce functional changes.

8ad81f2f

30 Dec, 2015 1 commit

Add explanation to setup about default admin password · 0a882bb2

wroot authored Dec 30, 2015

Add explanation to setup about default admin password
https://igniterealtime.org/issues/browse/OF-1016

0a882bb2

29 Dec, 2015 1 commit

Fixed group population for colliding full names. · fb9c6a39

Nik Okuntseff authored Dec 29, 2015

When LDAP search returns a multiple result set for a user CN,
we now iterate through the entire set to find a matching user DN.

fb9c6a39