- 08 May, 2017 2 commits
-
-
Michael Klein authored
-
Michael Klein authored
* OF-1325 -- Implement separate History settings in Client Control * OF-1325 -- Implement separate History settings in Client Control * OF-1325 -- Implement separate History settings in Client Control
-
- 04 May, 2017 1 commit
-
-
akrherz authored
-
- 03 May, 2017 1 commit
-
-
Guus der Kinderen authored
Openfire repeatedly searches for the same UserDN values. This cache should alleviate the backend storage and improve performance.
-
- 27 Apr, 2017 1 commit
-
-
daryl herzmann authored
OF-1324 limit outbound s2s queue
-
- 26 Apr, 2017 10 commits
-
-
Guus der Kinderen authored
-
daryl herzmann authored
Non-functional changes
-
Guus der Kinderen authored
These add nothing, but warnings in tooling.
-
Guus der Kinderen authored
These statements do nothing but generate warnings. Easily fixed.
-
Guus der Kinderen authored
Javadoc comment are dangling if they don't belong to any class, method or field. For example a Javadoc comment in between method declarations that have their own javadoc comments. These generate needless warnings, which are in most instances easily solved. By far most problems occur in the license block that's in most files.
-
Guus der Kinderen authored
-
Guus der Kinderen authored
-
Dave Cridland authored
-
Guus der Kinderen authored
-
Guus der Kinderen authored
This commit adds an upper-limit to the amount of stanzas that can be queued in an outgoing session promise. Any data that won't fit in the queue is rejected immediately. Note that this can lead to a situation where later stanzas are rejected before stanzas that or sent earlier (but got in the queue).
-
- 25 Apr, 2017 4 commits
-
-
Dave Cridland authored
OF-1311: Don't assume values are Strings.
-
Dave Cridland authored
OF-1321: Proper null-check to avoid stacktrace with stale session.
-
Guus der Kinderen authored
-
Guus der Kinderen authored
-
- 24 Apr, 2017 6 commits
-
-
Guus der Kinderen authored
By default, the Maven structure uses the Maven artifactId value as the name for a plugin. Maven artifactIds typically include tokens that will cause problems, such as dashes and dots. The plugin name is used in various places, that all have limitations: filenames (the jar file itself, the i18n files), package names (for the java files generated from JSPs), etc. This commit allows the name of the plugin to be overridden using a maven property 'plugin.name' and includes instructions on what the best format is.
-
Guus der Kinderen authored
For plugins to be able to use the tags used in the admin console, the tags should be distributed in a library. By making this library a Maven module, plugins can define the library as a dependency. Note that the admin.tld file is duplicated, but *slightly* modified in the Maven module: the path of the tags is different (META-INF vs WEB-INF).
-
Guus der Kinderen authored
The HSQLDB library that ships with Openfire (for Ant) is newer than the dependency that's defined in Maven. This introduces a compatibility issue at runtime: > org.jivesoftware.database.SchemaManager - Unexpected token: FILES in statement [ SET FILES] The difference is likely an oversight, caused by us taking a very long time to merge the Maven PR. At the time it was created, the dependency was still okay.
-
Guus der Kinderen authored
The Avalon framework is a dependency of the Proxool Maven artificat, but was never included as a library to Openfire prior the move to Maven (so, we can do without). The Avalon dependency itself has a dependency of servlet-api 2.3, which is unwanted, and causes issues when compiling JSPs.
-
Guus der Kinderen authored
Previously, the openfire-plugin-assembly artifact replaced the default artifact. When using plugin project as a Maven dependency, this causes oddities: the dependency still is a JAR file, but does not conform to a standard archive. This results in missing classes. Instead, this commit retains the original project artifact. This is expected to be more useful. Sadly, we appear to can pick only one of these options: - Attach the openfire-plugin-assembly artifact (making it referencable) - Define a finalName for this artifact (<artifactname>.plugin) Both options appear to be mutually exclusive. More annoyance is prevented by giving the plugin jar file a 'proper' name, I suspect, which is why I opted for doing that. For the other option, set 'appendAssemblyId' to true, and remove the 'attach' element of the 'make-assembly' block. The removed openfire-plugin-jar assembly does not appear to have a practical purpose: it builds a jar file that is pretty similar to the standard artifact (it misses some metadata, and its final name is different). Removing this assembly reduces complexity, at the cost of a benefit that I cannot see.
-
Guus der Kinderen authored
-
- 19 Apr, 2017 6 commits
-
-
Guus der Kinderen authored
-
Guus der Kinderen authored
-
Guus der Kinderen authored
-
Guus der Kinderen authored
-
Guus der Kinderen authored
-
Guus der Kinderen authored
The build plans for the plugins should not inherit from the parent project, as this ties their existence in with our parent project. Third party developers cannot do this (without modifying the parent project structure). We should facilitate third party developers, and use the same tools as we provide them. This commit removes the parent/child dependencies between the top-level parent POM and the plugins POM. There still as a parent/child dependency between the plugins POM and each individual plugin. Although I'm not sure this change is a complete solution, it is aimed to more closely represent a development setup in which a third party developer might find itself. To create a plugin of their own, they can now: - Use our 'plugins' module directly (define it as a parent) - Replace our 'plugins' module by a proprietary one (when developing multiple proprietary plugins). - Take most POM definition from our 'plugins' module and merge that with a new stand-alone plugin project.
-
- 14 Apr, 2017 5 commits
-
-
Dave Cridland authored
Straightforward failure to escape in this debugging plugin.
-
GregDThomas authored
* Add option to disable delayed delivery (XEP-0203)
-
Guus der Kinderen authored
This fixes some encoding issues, preventing LDAP users that have an '@' character in their username from becoming admin.
-
Dave Cridland authored
-
Guus der Kinderen authored
In an annoying quest to reproduce a bug related to JSTL and plugins I completely redid the MoTD plugin admin console page. I added CSRF protection to justify my changes. Never did reproduce that bug...
-
- 13 Apr, 2017 1 commit
-
-
Guus der Kinderen authored
* OF-1311: Allow lists to be stored in a property. * OF-1312: Allow SASL mechanisms to be configured in the admin console.
-
- 10 Apr, 2017 1 commit
-
-
Guus der Kinderen authored
-
- 03 Apr, 2017 1 commit
-
-
akrherz authored
-
- 29 Mar, 2017 1 commit
-
-
Guus der Kinderen authored
A new property (ldap.encodeMultibyteCharacters) is introduced that controls if multibyte characters in LDAP search queries are escaped. Escaping of these characters started with the fix for OF-830, which appears to have caused OF-1305. Although I can't say that escaping of characters is wrong (per RFC 4515), it does cause real-world problems. This fix defaults to not encoding again (reverting back to the behavior pre OF-830, without affecting other changes made in OF-830).
-