Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
O
Openfire
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Administrator
Openfire
Commits
f4529cd2
Commit
f4529cd2
authored
Apr 14, 2017
by
Dave Cridland
Committed by
daryl herzmann
Apr 14, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
OF-1272 Close XSS in dbaccess plugin (#742)
Straightforward failure to escape in this debugging plugin.
parent
aabb2bf5
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
1 deletion
+2
-1
db-access.jsp
src/plugins/dbaccess/src/web/db-access.jsp
+2
-1
No files found.
src/plugins/dbaccess/src/web/db-access.jsp
View file @
f4529cd2
<%@ page
import=
"org.jivesoftware.database.DbConnectionManager"
%>
<%@ page
import=
"org.jivesoftware.database.DbConnectionManager"
%>
<%@ page
import=
"java.sql.*"
%>
<%@ page
import=
"java.sql.*"
%>
<%@ page
import=
"org.jivesoftware.util.StringUtils"
%>
<%@ taglib
uri=
"http://java.sun.com/jsp/jstl/core"
prefix=
"c"
%>
<%@ taglib
uri=
"http://java.sun.com/jsp/jstl/core"
prefix=
"c"
%>
<%@ taglib
uri=
"http://java.sun.com/jsp/jstl/fmt"
prefix=
"fmt"
%>
<%@ taglib
uri=
"http://java.sun.com/jsp/jstl/fmt"
prefix=
"fmt"
%>
...
@@ -68,7 +69,7 @@
...
@@ -68,7 +69,7 @@
out.print("
<
tr
>
");
out.print("
<
tr
>
");
for (int i=1; i<=count; i++) {
for (int i=1; i<=count; i++) {
out.print("
<
td
>
");
out.print("
<
td
>
");
out.print(
rs.getString(i
));
out.print(
StringUtils.escapeHTMLTags(rs.getString(i)
));
}
}
out.println("
</
tr
>
");
out.println("
</
tr
>
");
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment