Commit f4529cd2 authored by Dave Cridland's avatar Dave Cridland Committed by daryl herzmann

OF-1272 Close XSS in dbaccess plugin (#742)

Straightforward failure to escape in this debugging plugin.
parent aabb2bf5
<%@ page import="org.jivesoftware.database.DbConnectionManager" %> <%@ page import="org.jivesoftware.database.DbConnectionManager" %>
<%@ page import="java.sql.*" %> <%@ page import="java.sql.*" %>
<%@ page import="org.jivesoftware.util.StringUtils" %>
<%@ taglib uri="http://java.sun.com/jsp/jstl/core" prefix="c" %> <%@ taglib uri="http://java.sun.com/jsp/jstl/core" prefix="c" %>
<%@ taglib uri="http://java.sun.com/jsp/jstl/fmt" prefix="fmt" %> <%@ taglib uri="http://java.sun.com/jsp/jstl/fmt" prefix="fmt" %>
...@@ -68,7 +69,7 @@ ...@@ -68,7 +69,7 @@
out.print("<tr>"); out.print("<tr>");
for (int i=1; i<=count; i++) { for (int i=1; i<=count; i++) {
out.print("<td>"); out.print("<td>");
out.print(rs.getString(i)); out.print(StringUtils.escapeHTMLTags(rs.getString(i)));
} }
out.println("</tr>"); out.println("</tr>");
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment