Commit 19d3cd16 authored by Dietmar Maurer's avatar Dietmar Maurer

FirewallRules: set error tooltips on load

And use a hidden field to forms with errors as dirty.
parent 658179f3
...@@ -66,6 +66,8 @@ Ext.define('PVE.FirewallRulePanel', { ...@@ -66,6 +66,8 @@ Ext.define('PVE.FirewallRulePanel', {
values.proto = ''; values.proto = '';
} }
delete values.modified_marker;
return values; return values;
}, },
...@@ -73,6 +75,14 @@ Ext.define('PVE.FirewallRulePanel', { ...@@ -73,6 +75,14 @@ Ext.define('PVE.FirewallRulePanel', {
var me = this; var me = this;
me.column1 = [ me.column1 = [
{
// hack: we use this field to mark the form 'dirty' when the
// record has errors- so that the user can safe the unmodified
// form again.
xtype: 'hiddenfield',
name: 'modified_marker',
value: '',
},
{ {
xtype: 'pveKVComboBox', xtype: 'pveKVComboBox',
name: 'type', name: 'type',
...@@ -249,6 +259,14 @@ Ext.define('PVE.FirewallRuleEdit', { ...@@ -249,6 +259,14 @@ Ext.define('PVE.FirewallRuleEdit', {
success: function(response, options) { success: function(response, options) {
var values = response.result.data; var values = response.result.data;
ipanel.setValues(values); ipanel.setValues(values);
var field = me.query('[isFormField][name=modified_marker]')[0];
field.setValue(1);
if (values.errors) {
Ext.Function.defer(function() {
var form = ipanel.up('form').getForm();
form.markInvalid(values.errors)
}, 100);
}
} }
}); });
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment