Commit 0bba4496 authored by Wolfgang Bumiller's avatar Wolfgang Bumiller Committed by Dietmar Maurer

bridgevlanport: replace sed pipe with substitution

The previous code stripped *all* combinations of zero or
more letters and digits followed by a dot of an interface
name to retrieve the VLANID. At the same time the supposedly
opposite code for IF_VLAN_RAW_DEVICE only actually extracts
the part up to the *first* dot. Thus an interface named
'a.b.0' would have a VLANID of 0 and a raw device name of
just 'a'.
I also don't see a reason to limit the removed portions to
alphanumeric characters. I.e. an interface named tap-test.0
would result in a VLANID of 'tap-0' and an
IF_VLAN_RAW_DEVICE of 'test'.

A simple shell substitution seems to do a much better job
and is more efficient than forking out two processes with a
pipe.
parent 9cbb0187
......@@ -8,8 +8,8 @@ fi
if [ "$MODE" = "start" ] ; then
case "$IFACE" in
*.[0-9]*)
VLANID=`echo $IFACE|sed "s/[a-zA-Z0-9]*\.//g"`
IF_VLAN_RAW_DEVICE=`echo $IFACE|sed "s/\([a-zA-Z0-9]*\)\..*/\1/"`
VLANID="${IFACE##*.}"
IF_VLAN_RAW_DEVICE="${IFACE%.*}"
;;
esac
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment