Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
L
linphone-desktop
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Administrator
linphone-desktop
Commits
91bb74c2
Commit
91bb74c2
authored
Nov 16, 2016
by
Ronan Abhamon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix(Notifications/Notification): remove binding loop
parent
91ef7469
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
11 additions
and
4 deletions
+11
-4
Notifier.cpp
tests/src/components/notifier/Notifier.cpp
+4
-1
Notification.qml
tests/ui/modules/Linphone/Notifications/Notification.qml
+7
-3
No files found.
tests/src/components/notifier/Notifier.cpp
View file @
91bb74c2
...
...
@@ -106,7 +106,10 @@ void Notifier::showCallMessage (
m_mutex
.
unlock
();
// Display notification.
QMetaObject
::
invokeMethod
(
object
,
"show"
,
Qt
::
DirectConnection
);
QMetaObject
::
invokeMethod
(
object
,
NOTIFICATION_SHOW_METHOD_NAME
,
Qt
::
DirectConnection
);
// Destroy it after timeout.
QTimer
::
singleShot
(
timeout
,
this
,
[
object
,
this
]()
{
...
...
tests/ui/modules/Linphone/Notifications/Notification.qml
View file @
91bb74c2
...
...
@@ -35,9 +35,13 @@ DesktopPopup {
window
.
y
=
Qt
.
binding
(
function
()
{
var
screen
=
window
.
Screen
return
screen
!=
null
?
screen
.
desktopAvailableHeight
-
window
.
height
-
notificationOffset
:
0
if
(
screen
==
null
)
{
return
0
}
var
height
=
screen
.
desktopAvailableHeight
-
window
.
height
return
height
-
notificationOffset
%
height
})
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment