feat(ui/views/App/Calls/Incall): better encryption tooltip

linphone-desktop/assets/languages/en.ts

@@ -315,10 +315,6 @@
         <source>callErrorNotAcceptable</source>
         <translation type="unfinished"></translation>
     </message>
-    <message>
-        <source>noMediaEncryption</source>
-        <translation>None</translation>
-    </message>
 </context>
 <context>
     <name>CallSipAddress</name>
@@ -812,6 +808,14 @@ Server url not configured.</translation>
         <source>pendingRequestLabel</source>
         <translation>Please to wait, a request is pending.</translation>
     </message>
+    <message>
+        <source>securedStringFormat</source>
+        <translation>Call is encrypted with: %1.</translation>
+    </message>
+    <message>
+        <source>callNotSecured</source>
+        <translation>Call not encrypted.</translation>
+    </message>
 </context>
 <context>
     <name>InviteFriends</name>

linphone-desktop/assets/languages/fr.ts

@@ -315,10 +315,6 @@
         <source>callErrorNotAcceptable</source>
         <translation type="unfinished"></translation>
     </message>
-    <message>
-        <source>noMediaEncryption</source>
-        <translation>Aucun</translation>
-    </message>
 </context>
 <context>
     <name>CallSipAddress</name>
@@ -812,6 +808,14 @@ Url du serveur non configurée.</translation>
         <source>pendingRequestLabel</source>
         <translation>Merci de patienter, une requête est en attente.</translation>
     </message>
+    <message>
+        <source>securedStringFormat</source>
+        <translation>L&apos;appel est chiffré avec: %1.</translation>
+    </message>
+    <message>
+        <source>callNotSecured</source>
+        <translation>Appel non chiffré.</translation>
+    </message>
 </context>
 <context>
     <name>InviteFriends</name>

linphone-desktop/src/components/call/CallModel.cpp

@@ -541,7 +541,7 @@ QString CallModel::getSecuredString () const {
       break;
   }
 
-  return tr("noMediaEncryption");
+  return QStringLiteral("");
 }
 
 // -----------------------------------------------------------------------------

linphone-desktop/ui/views/App/Calls/Incall.js

@@ -64,6 +64,14 @@ function handleVideoRequested () {
   })
 }
 
+function makeReadableSecuredString (securedString) {
+  if (!securedString.length) {
+    return qsTr('callNotSecured')
+  }
+
+  return qsTr('securedStringFormat').replace('%1', securedString)
+}
+
 function showFullscreen () {
   if (incall._fullscreen) {
     return

linphone-desktop/ui/views/App/Calls/Incall.qml

@@ -111,7 +111,7 @@ Rectangle {
           onClicked: zrtp.visible = (incall.call.encryption === CallModel.CallEncryptionZRTP)
 
           TooltipArea {
-            text: incall.call.securedString
+            text: Logic.makeReadableSecuredString(incall.call.securedString)
           }
         }
       }