Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
L
linphone-desktop
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Administrator
linphone-desktop
Commits
42e00a18
Commit
42e00a18
authored
Aug 09, 2017
by
nicolas
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix(Cli): better test when passing uri as cli, and an argument is missing
parent
bd0c9bdd
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
1 deletion
+2
-1
Cli.cpp
src/app/cli/Cli.cpp
+2
-1
No files found.
src/app/cli/Cli.cpp
View file @
42e00a18
...
...
@@ -123,7 +123,7 @@ void Cli::Command::execute (QHash<QString, QString> &args) const {
// Check missing arguments.
for
(
const
auto
&
argName
:
mArgsScheme
.
keys
())
{
if
(
!
args
.
contains
(
argName
)
&&
!
mArgsScheme
[
argName
].
isOptional
)
{
if
(
!
mArgsScheme
[
argName
].
isOptional
&&
(
!
args
.
contains
(
argName
)
||
args
[
argName
].
isEmpty
())
)
{
qWarning
()
<<
QStringLiteral
(
"Missing argument for command: `%1 (%2)`."
)
.
arg
(
mFunctionName
).
arg
(
argName
);
return
;
...
...
@@ -220,6 +220,7 @@ void Cli::executeCommand (const QString &command, CommandFormat *format) const {
return
;
}
//TODO: check if there is any header when the `method` header is missing.
const
QString
functionName
=
::
Utils
::
coreStringToAppString
(
address
->
getHeader
(
"method"
)).
isEmpty
()
?
QStringLiteral
(
"call"
)
:
::
Utils
::
coreStringToAppString
(
address
->
getHeader
(
"method"
));
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment