Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
L
linphone-desktop
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Administrator
linphone-desktop
Commits
3dd47411
Commit
3dd47411
authored
Jun 12, 2017
by
Ronan Abhamon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
feat(app): `QString("")` is more efficient than `QStringLiteral("")`
parent
271f771c
Changes
7
Hide whitespace changes
Inline
Side-by-side
Showing
7 changed files
with
9 additions
and
9 deletions
+9
-9
Cli.cpp
linphone-desktop/src/app/cli/Cli.cpp
+2
-2
DefaultTranslator.cpp
linphone-desktop/src/app/translator/DefaultTranslator.cpp
+1
-1
CallModel.cpp
linphone-desktop/src/components/call/CallModel.cpp
+1
-1
VcardModel.cpp
linphone-desktop/src/components/contact/VcardModel.cpp
+1
-1
Presence.cpp
linphone-desktop/src/components/presence/Presence.cpp
+1
-1
SipAddressesModel.cpp
...esktop/src/components/sip-addresses/SipAddressesModel.cpp
+2
-2
Utils.cpp
linphone-desktop/src/utils/Utils.cpp
+1
-1
No files found.
linphone-desktop/src/app/cli/Cli.cpp
View file @
3dd47411
...
...
@@ -113,13 +113,13 @@ const QString Cli::parseFunctionName (const QString &command) noexcept {
const
QStringList
&
texts
=
mRegExpFunctionName
.
capturedTexts
();
if
(
texts
.
size
()
<
2
)
{
qWarning
()
<<
QStringLiteral
(
"Unable to parse function name of command: `%1`."
).
arg
(
command
);
return
QString
Literal
(
""
);
return
QString
(
""
);
}
const
QString
functionName
=
texts
[
1
];
if
(
!
mCommands
.
contains
(
functionName
))
{
qWarning
()
<<
QStringLiteral
(
"This command doesn't exist: `%1`."
).
arg
(
functionName
);
return
QString
Literal
(
""
);
return
QString
(
""
);
}
return
functionName
;
...
...
linphone-desktop/src/app/translator/DefaultTranslator.cpp
View file @
3dd47411
...
...
@@ -58,7 +58,7 @@ QString DefaultTranslator::translate (
int
n
)
const
{
if
(
!
context
)
return
QString
Literal
(
""
);
return
QString
(
""
);
QString
translation
=
QTranslator
::
translate
(
context
,
sourceText
,
disambiguation
,
n
);
...
...
linphone-desktop/src/components/call/CallModel.cpp
View file @
3dd47411
...
...
@@ -527,7 +527,7 @@ QString CallModel::getSecuredString () const {
break
;
}
return
QString
Literal
(
""
);
return
QString
(
""
);
}
// -----------------------------------------------------------------------------
...
...
linphone-desktop/src/components/contact/VcardModel.cpp
View file @
3dd47411
...
...
@@ -136,7 +136,7 @@ QString VcardModel::getAvatar () const {
// No path found.
if
(
!
photo
)
return
QString
Literal
(
""
);
return
QString
(
""
);
// Returns right path.
return
QStringLiteral
(
"image://%1/%2"
).
arg
(
AvatarProvider
::
PROVIDER_ID
).
arg
(
...
...
linphone-desktop/src/components/presence/Presence.cpp
View file @
3dd47411
...
...
@@ -68,5 +68,5 @@ QString Presence::getPresenceLevelIconName (const PresenceLevel &level) {
return
QStringLiteral
(
"led_white"
);
}
return
QString
Literal
(
""
);
return
QString
(
""
);
}
linphone-desktop/src/components/sip-addresses/SipAddressesModel.cpp
View file @
3dd47411
...
...
@@ -154,7 +154,7 @@ QString SipAddressesModel::getTransportFromSipAddress (const QString &sipAddress
);
if
(
!
address
)
return
QString
Literal
(
""
);
return
QString
(
""
);
switch
(
address
->
getTransport
())
{
case
linphone
:
:
TransportTypeUdp
:
...
...
@@ -167,7 +167,7 @@ QString SipAddressesModel::getTransportFromSipAddress (const QString &sipAddress
return
QStringLiteral
(
"DTLS"
);
}
return
QString
Literal
(
""
);
return
QString
(
""
);
}
QString
SipAddressesModel
::
addTransportToSipAddress
(
const
QString
&
sipAddress
,
const
QString
&
transport
)
const
{
...
...
linphone-desktop/src/utils/Utils.cpp
View file @
3dd47411
...
...
@@ -65,7 +65,7 @@ QString Utils::getSafeFilePath (const QString &filePath, bool *soFarSoGood) {
if
(
soFarSoGood
)
*
soFarSoGood
=
false
;
return
QString
Literal
(
""
);
return
QString
(
""
);
}
#undef SAFE_FILE_PATH_LIMIT
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment