Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
L
linphone-desktop
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Administrator
linphone-desktop
Commits
2de3d840
Commit
2de3d840
authored
Aug 16, 2017
by
Ronan Abhamon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix(SipAddressesModel): avoid a crash when a sip address observer is destroyed
parent
306c1877
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
4 deletions
+4
-4
SipAddressesModel.cpp
src/components/sip-addresses/SipAddressesModel.cpp
+4
-4
No files found.
src/components/sip-addresses/SipAddressesModel.cpp
View file @
2de3d840
...
...
@@ -116,10 +116,10 @@ SipAddressObserver *SipAddressesModel::getSipAddressObserver (const QString &sip
mObservers
.
insert
(
cleanedSipAddress
,
model
);
QObject
::
connect
(
model
,
&
SipAddressObserver
::
destroyed
,
this
,
[
this
,
model
]()
{
const
QString
sipAddress
=
cleanSipAddress
(
model
->
getSipAddress
());
if
(
mObservers
.
remove
(
s
ipAddress
,
model
)
==
0
)
qWarning
()
<<
QStringLiteral
(
"Unable to remove sip address `%1` from observers."
).
arg
(
s
ipAddress
);
model
,
&
SipAddressObserver
::
destroyed
,
this
,
[
this
,
model
,
cleanedSipAddress
]()
{
// Do not use `model` methods here. `model` is partially destroyed here!
if
(
mObservers
.
remove
(
cleanedS
ipAddress
,
model
)
==
0
)
qWarning
()
<<
QStringLiteral
(
"Unable to remove sip address `%1` from observers."
).
arg
(
cleanedS
ipAddress
);
});
return
model
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment