feat(src/app/cli/Cli): `mRegExpArgs` and `mRegExpFunctionName` are now static...

feat(src/app/cli/Cli): `mRegExpArgs` and `mRegExpFunctionName` are now static & `parseFunctionName` and `parseArgs` private

linphone-desktop/src/app/cli/Cli.cpp

@@ -65,13 +65,16 @@ void Cli::Command::execute (const QHash<QString, QString> &args) {
 
 // =============================================================================
 
-Cli::Cli (QObject *parent) : QObject(parent) {
-  // FIXME: Do not accept args without value like: cmd toto.
-  // In the future `toto` could be a boolean argument.
-  mRegExpArgs = QRegExp("(?:(?:(\\w+)\\s*)=\\s*(?:\"([^\"\\\\]*(?:\\\\.[^\"\\\\]*)*)\"|([^\\s]+)\\s*))");
-  mRegExpFunctionName = QRegExp("^\\s*(\\w+)\\s*");
+// FIXME: Do not accept args without value like: cmd toto.
+// In the future `toto` could be a boolean argument.
+QRegExp Cli::mRegExpArgs("(?:(?:(\\w+)\\s*)=\\s*(?:\"([^\"\\\\]*(?:\\\\.[^\"\\\\]*)*)\"|([^\\s]+)\\s*))");
+QRegExp Cli::mRegExpFunctionName("^\\s*(\\w+)\\s*");
 
-  makeCommands();
+Cli::Cli (QObject *parent) : QObject(parent) {
+  addCommand("show", tr("showFunctionDescription"), cliShow);
+  addCommand("call", tr("showFunctionCall"), cliCall, {
+    { "sip-address", {} }
+  });
 }
 
 // -----------------------------------------------------------------------------
@@ -83,13 +86,6 @@ void Cli::addCommand (const QString &functionName, const QString &description, F
     mCommands[functionName] = Cli::Command(functionName, description, function, argsScheme);
 }
 
-void Cli::makeCommands () noexcept {
-  addCommand("show", tr("showFunctionDescription"), cliShow);
-  addCommand("call", tr("showFunctionCall"), cliCall, {
-    { "sip-address", {} }
-  });
-}
-
 // -----------------------------------------------------------------------------
 
 void Cli::executeCommand (const QString &command) noexcept {

linphone-desktop/src/app/cli/Cli.hpp

@@ -71,16 +71,16 @@ public:
 
   void executeCommand (const QString &command) noexcept;
 
-  const QString parseFunctionName (const QString &command) noexcept;
-  const QHash<QString, QString> parseArgs (const QString &command, const QString functionName, bool &soFarSoGood) noexcept;
-
 private:
   void addCommand (const QString &functionName, const QString &description, Function function, const QHash<QString, Argument> &argsScheme = {}) noexcept;
-  void makeCommands () noexcept;
 
-  QRegExp mRegExpArgs;
-  QRegExp mRegExpFunctionName;
+  const QString parseFunctionName (const QString &command) noexcept;
+  const QHash<QString, QString> parseArgs (const QString &command, const QString functionName, bool &soFarSoGood) noexcept;
+
   QHash<QString, Command> mCommands;
+
+  static QRegExp mRegExpArgs;
+  static QRegExp mRegExpFunctionName;
 };
 
 #endif // CLI_H_