Unverified Commit b426c46a authored by Viral Solani's avatar Viral Solani Committed by GitHub

Merge pull request #56 from viralsolani/analysis-zD6139

Apply fixes from StyleCI
parents 32d3c4b8 e9ad8276
......@@ -2,15 +2,15 @@
namespace App\Http\Controllers\Backend\Pages;
use App\Models\Page\Page;
use App\Http\Controllers\Controller;
use App\Repositories\Backend\Pages\PagesRepository;
use App\Http\Requests\Backend\Pages\EditPageRequest;
use App\Http\Requests\Backend\Pages\StorePageRequest;
use App\Http\Requests\Backend\Pages\CreatePageRequest;
use App\Http\Requests\Backend\Pages\DeletePageRequest;
use App\Http\Requests\Backend\Pages\EditPageRequest;
use App\Http\Requests\Backend\Pages\ManagePageRequest;
use App\Http\Requests\Backend\Pages\StorePageRequest;
use App\Http\Requests\Backend\Pages\UpdatePageRequest;
use App\Models\Page\Page;
use App\Repositories\Backend\Pages\PagesRepository;
/**
* Class PagesController.
......@@ -63,7 +63,7 @@ class PagesController extends Controller
}
/**
* @param \App\Models\Page\Page $page
* @param \App\Models\Page\Page $page
* @param \App\Http\Requests\Backend\Pages\EditPageRequest $request
*
* @return mixed
......@@ -75,7 +75,7 @@ class PagesController extends Controller
}
/**
* @param \App\Models\Page\Page $page
* @param \App\Models\Page\Page $page
* @param \App\Http\Requests\Backend\Pages\UpdatePageRequest $request
*
* @return mixed
......@@ -88,7 +88,7 @@ class PagesController extends Controller
}
/**
* @param \App\Models\Page\Page $page
* @param \App\Models\Page\Page $page
* @param \App\Http\Requests\Backend\Pages\DeletePageRequest $request
*
* @return mixed
......
......@@ -2,11 +2,11 @@
namespace App\Http\Controllers\Backend\Pages;
use Carbon\Carbon;
use App\Http\Controllers\Controller;
use Yajra\DataTables\Facades\DataTables;
use App\Repositories\Backend\Pages\PagesRepository;
use App\Http\Requests\Backend\Pages\ManagePageRequest;
use App\Repositories\Backend\Pages\PagesRepository;
use Carbon\Carbon;
use Yajra\DataTables\Facades\DataTables;
/**
* Class PagesTableController.
......
......@@ -4,8 +4,8 @@ namespace App\Models\Page;
use App\Models\BaseModel;
use App\Models\ModelTrait;
use Illuminate\Database\Eloquent\SoftDeletes;
use App\Models\Page\Traits\Attribute\PageAttribute;
use Illuminate\Database\Eloquent\SoftDeletes;
class Page extends BaseModel
{
......@@ -26,7 +26,7 @@ class Page extends BaseModel
* The guarded field which are not mass assignable.
*
* @var array
*/
*/
protected $guarded = ['id'];
public function __construct(array $attributes = [])
......
......@@ -2,12 +2,12 @@
namespace App\Repositories\Backend\Pages;
use App\Models\Page\Page;
use App\Exceptions\GeneralException;
use App\Repositories\BaseRepository;
use App\Events\Backend\Pages\PageCreated;
use App\Events\Backend\Pages\PageDeleted;
use App\Events\Backend\Pages\PageUpdated;
use App\Exceptions\GeneralException;
use App\Models\Page\Page;
use App\Repositories\BaseRepository;
/**
* Class PagesRepository.
......@@ -46,14 +46,15 @@ class PagesRepository extends BaseRepository
if ($this->query()->where('title', $input['title'])->first()) {
throw new GeneralException(trans('exceptions.backend.pages.already_exists'));
}
//Making extra fields
$input['page_slug'] = str_slug($input['title']);
$input['status'] = isset($input['status']) ? 1 : 0;
$input['created_by'] = access()->user()->id;
if( $page = Page::create($input) ) {
if ($page = Page::create($input)) {
event(new PageCreated($page));
return true;
}
......@@ -62,7 +63,7 @@ class PagesRepository extends BaseRepository
/**
* @param \App\Models\Page\Page $page
* @param array $input
* @param array $input
*
* @throws \App\Exceptions\GeneralException
*
......@@ -79,12 +80,12 @@ class PagesRepository extends BaseRepository
$input['status'] = isset($input['status']) ? 1 : 0;
$input['updated_by'] = access()->user()->id;
if ( $page->update($input) ) {
if ($page->update($input)) {
event(new PageUpdated($page));
return true;
}
throw new GeneralException(trans('exceptions.backend.pages.update_error'));
}
......@@ -97,7 +98,7 @@ class PagesRepository extends BaseRepository
*/
public function delete($page)
{
if ( $page->delete() ) {
if ($page->delete()) {
event(new PageDeleted($page));
return true;
......
<?php
return [
'pages' => [
'table' => 'pages'
]
];
\ No newline at end of file
'pages' => [
'table' => 'pages',
],
];
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment