Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
P
Platform
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Administrator
Platform
Commits
8e8bc6d2
Commit
8e8bc6d2
authored
Feb 27, 2018
by
박관영
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add test to assure generateTagSlug() works like str_slug()
parent
b8097224
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
14 additions
and
1 deletion
+14
-1
TaggableTraitTest.php
Modules/Tag/Tests/Integration/TaggableTraitTest.php
+13
-0
TaggableTrait.php
Modules/Tag/Traits/TaggableTrait.php
+1
-1
No files found.
Modules/Tag/Tests/Integration/TaggableTraitTest.php
View file @
8e8bc6d2
...
...
@@ -3,6 +3,7 @@
namespace
Modules\Tag\Tests\Integration
;
use
Illuminate\Support\Facades\DB
;
use
Illuminate\Support\Str
;
use
Modules\Page\Entities\Page
;
use
Modules\Page\Repositories\PageRepository
;
use
Modules\Tag\Repositories\TagRepository
;
...
...
@@ -132,6 +133,18 @@ class TaggableTraitTest extends BaseTestCase
$this
->
assertCount
(
3
,
Page
::
allTags
()
->
get
());
}
/** @test */
public
function
it_generates_slug_like_original_str_slug
()
{
$page
=
$this
->
createPage
();
$this
->
assertEquals
(
Str
::
slug
(
'hello world'
),
$page
->
generateTagSlug
(
'hello world'
));
$this
->
assertEquals
(
Str
::
slug
(
'hello world'
),
$page
->
generateTagSlug
(
'hello-world'
));
$this
->
assertEquals
(
Str
::
slug
(
'hello_world'
),
$page
->
generateTagSlug
(
'hello_world'
));
$this
->
assertEquals
(
Str
::
slug
(
'hello_world'
,
'_'
),
$page
->
generateTagSlug
(
'hello_world'
,
'_'
));
$this
->
assertEquals
(
Str
::
slug
(
'user@host'
),
$page
->
generateTagSlug
(
'user@host'
));
}
/** @test */
public
function
it_gets_pages_with_non_latin_tags
()
{
...
...
Modules/Tag/Traits/TaggableTrait.php
View file @
8e8bc6d2
...
...
@@ -204,7 +204,7 @@ trait TaggableTrait
/**
* {@inheritdoc}
*/
p
rotected
function
generateTagSlug
(
$name
,
$separator
=
'-'
)
p
ublic
function
generateTagSlug
(
$name
,
$separator
=
'-'
)
{
// Convert all dashes/underscores into separator
$flip
=
$separator
==
'-'
?
'_'
:
'-'
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment