1. 26 Apr, 2017 1 commit
    • Guus der Kinderen's avatar
      Replace dangling javadoc with block comment. · 65f1f7f1
      Guus der Kinderen authored
      Javadoc comment are dangling if they don't belong to any class, method or field. For example a Javadoc comment in between method declarations that have their own javadoc comments.
      
      These generate needless warnings, which are in most instances easily solved. By far most problems occur in the license block that's in most files.
      65f1f7f1
  2. 04 Jan, 2017 1 commit
  3. 25 Nov, 2015 2 commits
    • Guus der Kinderen's avatar
      OF-946: Centralize connection configuration. · e58d590b
      Guus der Kinderen authored
      This commit (which is compilable, but breaks some important
      functionality - work in progess) aims to centralize the configuration
      for connections. "Connections" are used in a broad sense here, and
      includes socket-based (TLS and legacy-mode SSL) client connections,
      BOSH-based client connections, component connections, connectionmanager
      (multiplexer) connections, but also connections to the admin panel.
      e58d590b
    • Guus der Kinderen's avatar
      OF-946: Openfire should allow for more than one set of keystores. · 97f7cf3f
      Guus der Kinderen authored
      This commit:
      - Refactors SSL-related code to reduce complexity and deprecate unused code
      - Adds factory methods to obtain SSL/TLS engine / contexts, to replace all
        code duplication that was going on before.
      97f7cf3f
  4. 21 Nov, 2015 1 commit
    • Christian Schudt's avatar
      Language info should be in the Session, not in the Connection · 170b20cc
      Christian Schudt authored
      I feel the language (the stream's "xml:lang" attribute) should be in the Session interface rather than the Connection (similar as the stream id), because it's unrelated to the session's transport.
      
      The HttpSession already did that.
      
      Otherwise the used language is not easy to retrieve, e.g. when using SessionManager to get the session and OF-208 is hard to solve.
      
      Alternatively we can expose the Connection in the Session interface, but this approach feels wrong to me.
      
      Also use `java.util.Locale` rather than String, because it better reflects what can be in `xml:lang` (it can also have country codes, e.g. "de-CH")
      170b20cc
  5. 16 Nov, 2015 1 commit
    • Tom Evans's avatar
      OF-881: Apply review feedback · aa7a5ef6
      Tom Evans authored
      - Use AtomicReference instead of synchronized block
      - Extend java.io.Closeable; document contract
      - Consolidate close/state transition logic
      aa7a5ef6
  6. 13 Nov, 2015 1 commit
  7. 09 Nov, 2015 2 commits
  8. 29 May, 2015 1 commit
    • Guus der Kinderen's avatar
      OF-883: Prevent sending data to known disconnected peers. · 0d75703d
      Guus der Kinderen authored
      By closing a session when the new MINA inputClosed() handler is triggered, we run
      the risk of sending data to the peer. As that peer is known to be dead, this is
      pointless (and potentially dangerous - deadlocks have been observed that are likely
      related to this scenario).
      
      To prevent sending data during session closure, the close() method has been
      overloaded with an argument that indicates if the peer is known to be dead. When
      set, its implementation will not attempt to send data.
      0d75703d
  9. 11 Apr, 2013 1 commit
  10. 09 Nov, 2009 1 commit
  11. 30 Sep, 2009 1 commit
  12. 16 Jul, 2008 1 commit
  13. 11 Jun, 2008 1 commit
  14. 11 Apr, 2008 1 commit
  15. 12 Sep, 2007 1 commit
  16. 30 May, 2007 1 commit
  17. 18 May, 2007 1 commit
  18. 28 Mar, 2007 1 commit
  19. 04 Jan, 2007 1 commit
  20. 10 May, 2006 1 commit