1. 17 Mar, 2016 10 commits
    • Guus der Kinderen's avatar
      Admin Console: prevent NPE on missing user creation date. · 3d569e25
      Guus der Kinderen authored
      Some user providers might not provide a creation date for each user. There's no
      reason that the Admin Console should not be able to cope with that.
      3d569e25
    • Chinmay Dani's avatar
      Outcasts should not be allowed to register with room. · e468a51a
      Chinmay Dani authored
      With the current implementation, any user can send the register IQ to register with
      a room as a 'member'. This also allows outcasts, that were banned from a room, to be
      able to register again as a member, and eventually re-join the room. The solution is
      to prevent outcasts from registering with the room.
      e468a51a
    • Guus der Kinderen's avatar
      OF-1087: Do not add empty-string prefixed namespaces · f60e9152
      Guus der Kinderen authored
      In dom4j, the default namespace of an element cannot be set by adding
      a namespace that has an empty-string prefix. Although the string
      representation of the element will be correct, that namespace is not
      being recognized as the default namespace of the element (instead, it
      is a namespace like any other prefixed namespace, to be used in child
      elements).
      f60e9152
    • Guus der Kinderen's avatar
      OF-1087: Whitespace does not take into account element boundary. · e863a946
      Guus der Kinderen authored
      The original code depends on a whitespace to be present within the limits
      of the element. This is not safe (eg: <message><foo/></message> fails).
      Instead, the closing characters ( > or /> ) of the first element should
      be used, as that's guaranteed to be present.
      e863a946
    • Guus der Kinderen's avatar
      OF-1087: BOSH namespace fix · 3980468e
      Guus der Kinderen authored
      A change introduced in Openfire 3.10.3 (OF-938) changed how the BOSH
      implementation would add default namespace definitions where applicable.
      This new implementation depends on a space from being present in the
      outer stanza. The 'fin' element that's transmitted here is wrapped in
      a message stanza without any attributes ( <message><fin ... ) which
      caused the namespace to be injected in the fin element (where the first
      space was).
      
      This commit adds a 'to' attribute to the wrapping message stanza, to
      allow for users to work around the problem without having to update
      Openfire itself.
      
      The BOSH implementation will be adjusted to account for this in another
      commit.
      3980468e
    • Derek McLean's avatar
      Cannot join room in a cluster after an availability update. · 3c580276
      Derek McLean authored
      When a room occupant sends an availability update to a host in an
      Openfire cluster, other users cannot join the room from other hosts in
      the cluster. The availability update causes the other hosts to lose an
      occupant's role and affiliation. New occupants encounter an NPE when
      joining and are prevented from joining the room. Specifically, the NPE
      occurs when Openfire attempts to send initial presences for current
      occupants.
      
      Remote hosts in the cluster lose the occupant's association because the
      local room simply broadcasts the presence packet for the occupant's
      availability update. Because it is from the client, this packet does not
      have the occupant's role or affiliation. The remote hosts treat the
      presence packet as the occupant's presence without modification.
      
      This fix changes the order in which Openfire handles an availability
      update. First, it updates its local view of an occupant's presence. This
      populates the correct association. Then, it broadcasts the updated
      presence to remote hosts in the cluster.
      3c580276
    • Chung's avatar
      Fix unicode read on input · 5e84ea54
      Chung authored
      In the current read scheme for Openfire, it is possible that due
      to variable width encoding that we sometimes only create a
      string with a partial character.
      
      This breaks the message text and causes encoding issues when read.
      
      This change modifies the way the characters are
      read to use an bytearrayoutputstream and
      only do the string conversion once.
      
      Since we only do the string creation once after the full
      buffer is read, we no longer have encoding
      issues with broken unicode characters.
      5e84ea54
    • dchinmay's avatar
      NullPointerException in RoutingTableImpl. · 1d42ddf1
      dchinmay authored
      In #routeToComponent, it is first checked if the component is being hosted in the local JVM. If it was not found, then all nodes in the ComponentsCache are checked to find if the component is hosted by one of those. In this process, the local routing table is again searched for the component, because it may have been added after the previous check. However, after this search, there is no null check done for the searched route. This results in an NPE when the component was not found locally and the #process(packet) method is called on the object. 
      
      This also prevents the code from searching other nodes that may have been in the nodes set. Added a null check to prevent this scenario.
      1d42ddf1
    • Christian Schudt's avatar
      XEP-0016 error messages should set correct from attribute (the sender). · 1315b8c4
      Christian Schudt authored
      See XEP-0016, example 50.
      1315b8c4
    • Tom Evans's avatar
      OF-954: Cleanup MUC rooms for defunct node · 6259bad9
      Tom Evans authored
      Patch submitted by community member lukzie.
      6259bad9
  2. 26 Jan, 2016 4 commits
  3. 25 Jan, 2016 16 commits
  4. 21 Jan, 2016 2 commits
    • Guus der Kinderen's avatar
      OF-1053: Don't use apostrophe in i18n · 85e442ab
      Guus der Kinderen authored
      Replaced all apostrophes with HTML-encoded entities to prevent
      formatting problems.
      85e442ab
    • Guus der Kinderen's avatar
      OF-1046: Improve offline-storage usage · 2ff3961e
      Guus der Kinderen authored
      Existing code already tried to prevent message bounces when a stanza was
      sent by the server itself. This commit builds on that solution.
      Also, debug logging was added for the store-and-* strategies when storage
      was no longer possible as a result of quota limitations (we had a hard time
      debugging this)
      2ff3961e
  5. 19 Jan, 2016 1 commit
    • Nik Okuntseff's avatar
      A fix for OF-1041 · 1e75e99c
      Nik Okuntseff authored
      Made a search by distinguishedName Active Directory specific
      as it is difficult to come up with a generic solution.
      1e75e99c
  6. 18 Jan, 2016 1 commit
  7. 12 Jan, 2016 4 commits
  8. 11 Jan, 2016 2 commits