1. 09 Apr, 2016 2 commits
    • Guus der Kinderen's avatar
      OF-1125: Should use StreamID class instead of String. · 2cc0a948
      Guus der Kinderen authored
      To represent a stream ID, Openfire defines the StreamID interface. However,
      that interface is hardly used. Instead, simple String representations are used
      in most places.
      
      StreamIDs should conform to some specifications (notably: they shouldn't
      include XML special characters). An implementation of the StreamID interface
      is a good place to enforce specifications like that.
      
      This commit replaces all String-based stream ID representations with an
      implemenation of StreamID. For clustering/hazelcast, the serialized string
      is still being used to exchange data between nodes (I expect that this allows
      older and newer cluster nodes to continue to exchange cache information within
      the same cluster).
      
      Also in this commit:
      - StreamID implementations check for (and escape) XML special characters.
      - Duplicate implemenations of the StreamID interface are removed.
      
      Some code refers to streamID while in reality session IDs are implemented. This
      commit does not affect those pieces of code.
      2cc0a948
    • wroot's avatar
      279a998f
  2. 08 Apr, 2016 2 commits
  3. 06 Apr, 2016 4 commits
  4. 30 Mar, 2016 1 commit
  5. 25 Mar, 2016 2 commits
  6. 24 Mar, 2016 3 commits
  7. 23 Mar, 2016 15 commits
  8. 22 Mar, 2016 1 commit
  9. 21 Mar, 2016 2 commits
  10. 18 Mar, 2016 1 commit
    • akrherz's avatar
      OF-929 prevent ghosts by removing ioSession check · e5182f23
      akrherz authored
      Since the release of Openfire 3.9.3, users have reported problems with
      "ghost" sessions left on the server. After reviewing the changes that
      went into the 3.9.3 release, it seemed the fix for OF-464 may have had
      some side effect causing this.
      
      Since Igniterealtime's Openfire was reproducing OF-829, I did a test
      whereby the functional changes of Igniterealtime/Openfire#ad08cae9
      were reverted.  After 36 hours, there were no ghosts!
      
      This will likely necessitate reopening OF-464.
      e5182f23
  11. 17 Mar, 2016 1 commit
  12. 11 Mar, 2016 2 commits
  13. 10 Mar, 2016 2 commits
    • Dave Cridland's avatar
      Merge pull request #558 from guusdk/master · cd4994ca
      Dave Cridland authored
      Prevent occasional failure of CheckChainTrustedTest
      cd4994ca
    • Guus der Kinderen's avatar
      Prevent occasional failure of CheckChainTrustedTest · 3ed99368
      Guus der Kinderen authored
      There's one unit test that occasionally fails. This occurs as a result of an unintended
      collision. As part of the test, many certificates are generated and stored in keystores.
      The alias used for the entry was based on the hashcode of the public ke of the certificate.
      The value range of those hashcodes is fairly small (it has only a couple of digits), which
      leads to occasional collisions, causing the test to fail.
      
      This commit replaces the hashcode-based alias with the Base64-encoded public key information.
      This ensures that aliases for distinct keys are also distinct, while ensuring that the
      aliases for equal keys are equal.
      3ed99368
  14. 07 Mar, 2016 2 commits