Optimization: Only copy presence if room is semi-anonymous. JM-480

git-svn-id: http://svn.igniterealtime.org/svn/repos/messenger/trunk@3158 b35dd754-fafc-0310-a699-88a17e54d16e

src/java/org/jivesoftware/messenger/muc/spi/MUCRoomImpl.java

@@ -575,7 +575,7 @@ public class MUCRoomImpl implements MUCRoom {
             if (occupant == joinRole) {
                 continue;
             }
-            Presence occupantPresence = occupant.getPresence().createCopy();
+            Presence occupantPresence = occupant.getPresence();
             // Skip to the next occupant if we cannot send presence of this occupant
             if (hasToCheckRoleToBroadcastPresence()) {
                 Element frag = occupantPresence.getChildElement("x",
@@ -588,6 +588,7 @@ public class MUCRoomImpl implements MUCRoom {
             // Don't include the occupant's JID if the room is semi-anon and the new occupant
             // is not a moderator
             if (!canAnyoneDiscoverJID() && MUCRole.Role.moderator != joinRole.getRole()) {
+                occupantPresence = occupantPresence.createCopy();
                 Element frag = occupantPresence.getChildElement("x",
                         "http://jabber.org/protocol/muc#user");
                 frag.element("item").addAttribute("jid", null);