Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
O
Openfire
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Administrator
Openfire
Commits
f499120f
Commit
f499120f
authored
Oct 12, 2015
by
Alpha
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Made connection retry parameters configurable
parent
1f032323
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
50 additions
and
46 deletions
+50
-46
DbConnectionManager.java
src/java/org/jivesoftware/database/DbConnectionManager.java
+50
-46
No files found.
src/java/org/jivesoftware/database/DbConnectionManager.java
View file @
f499120f
...
...
@@ -49,7 +49,7 @@ import org.slf4j.LoggerFactory;
*/
public
class
DbConnectionManager
{
private
static
final
Logger
Log
=
LoggerFactory
.
getLogger
(
DbConnectionManager
.
class
);
private
static
final
Logger
Log
=
LoggerFactory
.
getLogger
(
DbConnectionManager
.
class
);
private
static
ConnectionProvider
connectionProvider
;
private
static
final
Object
providerLock
=
new
Object
();
...
...
@@ -74,11 +74,41 @@ public class DbConnectionManager {
/** True if the database supports the Statement.setFetchSize()) method. */
static
boolean
pstmt_fetchSizeSupported
=
true
;
private
static
final
String
SETTING_DATABASE_MAX_RETRIES
=
"database.defaultProvider.maxRetries"
;
private
static
final
String
SETTING_DATABASE_RETRY_DELAY
=
"database.defaultProvider.retryDelay"
;
private
static
DatabaseType
databaseType
=
DatabaseType
.
unknown
;
private
static
SchemaManager
schemaManager
=
new
SchemaManager
();
/**
* Ensures that the connection provider exists and is set
*/
private
static
void
ensureConnectionProvider
()
{
if
(
connectionProvider
!=
null
)
return
;
synchronized
(
providerLock
)
{
if
(
connectionProvider
!=
null
)
return
;
// Attempt to load the connection provider classname as a Jive property.
String
className
=
JiveGlobals
.
getXMLProperty
(
"connectionProvider.className"
);
if
(
className
!=
null
)
{
// Attempt to load the class.
try
{
Class
conClass
=
ClassUtils
.
forName
(
className
);
setConnectionProvider
((
ConnectionProvider
)
conClass
.
newInstance
());
}
catch
(
Exception
e
)
{
Log
.
warn
(
"Failed to create the "
+
"connection provider specified by connection"
+
"Provider.className. Using the default pool."
,
e
);
setConnectionProvider
(
new
DefaultConnectionProvider
());
}
}
else
{
setConnectionProvider
(
new
DefaultConnectionProvider
());
}
}
}
/**
* Returns a database connection from the currently active connection
* provider. An exception will be thrown if no connection was found.
...
...
@@ -88,41 +118,15 @@ public class DbConnectionManager {
* @throws SQLException if a SQL exception occurs or no connection was found.
*/
public
static
Connection
getConnection
()
throws
SQLException
{
if
(
connectionProvider
==
null
)
{
synchronized
(
providerLock
)
{
if
(
connectionProvider
==
null
)
{
// Attempt to load the connection provider classname as
// a Jive property.
String
className
=
JiveGlobals
.
getXMLProperty
(
"connectionProvider.className"
);
if
(
className
!=
null
)
{
// Attempt to load the class.
try
{
Class
conClass
=
ClassUtils
.
forName
(
className
);
setConnectionProvider
((
ConnectionProvider
)
conClass
.
newInstance
());
}
catch
(
Exception
e
)
{
Log
.
warn
(
"Failed to create the "
+
"connection provider specified by connection"
+
"Provider.className. Using the default pool."
,
e
);
setConnectionProvider
(
new
DefaultConnectionProvider
());
}
}
else
{
setConnectionProvider
(
new
DefaultConnectionProvider
());
}
}
}
}
ensureConnectionProvider
();
// TODO: May want to make these settings configurable
Integer
retryCnt
=
0
;
Integer
retryMax
=
10
;
Integer
retryWait
=
250
;
// milliseconds
Connection
con
=
null
;
Integer
currentRetryCount
=
0
;
Integer
maxRetries
=
JiveGlobals
.
getIntProperty
(
SETTING_DATABASE_MAX_RETRIES
,
10
);
Integer
retryWait
=
JiveGlobals
.
getIntProperty
(
SETTING_DATABASE_RETRY_DELAY
,
250
);
// milliseconds
SQLException
lastException
=
null
;
do
{
try
{
con
=
connectionProvider
.
getConnection
();
Connection
con
=
connectionProvider
.
getConnection
();
if
(
con
!=
null
)
{
// Got one, lets hand it off.
// Usually profiling is not enabled. So we return a normal
...
...
@@ -130,28 +134,28 @@ public class DbConnectionManager {
// connection with a profiled connection.
if
(!
profilingEnabled
)
{
return
con
;
}
else
{
}
else
{
return
new
ProfiledConnection
(
con
);
}
}
}
catch
(
SQLException
e
)
{
// TODO distinguish recoverable from non-recoverable exceptions.
lastException
=
e
;
Log
.
info
(
"Unable to get a connection from the database pool "
+
"(attempt "
+
retryCnt
+
" out of "
+
retryMax
+
")."
,
e
);
}
// TODO distinguish recoverable from non-recoverable exceptions.
lastException
=
e
;
Log
.
info
(
"Unable to get a connection from the database pool "
+
"(attempt "
+
currentRetryCount
+
" out of "
+
maxRetries
+
")."
,
e
);
}
try
{
Thread
.
sleep
(
retryWait
);
}
catch
(
Exception
e
)
{
// Ignored, the thread was interrupted while waiting, so no need to log either
}
catch
(
Exception
e
)
{
// Ignored
}
retryCnt
++;
}
while
(
retryCnt
<=
retryMax
);
currentRetryCount
++;
}
while
(
currentRetryCount
<=
maxRetries
);
throw
new
SQLException
(
"ConnectionManager.getConnection() "
+
"failed to obtain a connection after "
+
retryCnt
+
" retries. "
+
"The exception from the last attempt is as follows: "
+
lastException
);
"failed to obtain a connection after "
+
currentRetryCount
+
" retries. "
+
"The exception from the last attempt is as follows: "
+
lastException
);
}
/**
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment