Commit 78ab43ef authored by Tom Evans's avatar Tom Evans Committed by tevans

OF-342: Return CORS headers for all HTTP responses (including errors) if active

git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13556 b35dd754-fafc-0310-a699-88a17e54d16e
parent 5c3c7ce5
...@@ -96,13 +96,13 @@ public class HttpBindServlet extends HttpServlet { ...@@ -96,13 +96,13 @@ public class HttpBindServlet extends HttpServlet {
sessionManager.stop(); sessionManager.stop();
} }
@Override @Override
protected void doOptions(HttpServletRequest request, HttpServletResponse response) protected void service(HttpServletRequest request, HttpServletResponse response)
throws ServletException, IOException { throws ServletException, IOException {
// Use HttpServlet's implementation to add basic headers ('Allow'). // add CORS headers for all HTTP responses (errors, etc.)
super.doOptions(request, response);
addCORSHeaders(request, response); addCORSHeaders(request, response);
} super.service(request, response);
}
@Override @Override
protected void doGet(HttpServletRequest request, HttpServletResponse response) protected void doGet(HttpServletRequest request, HttpServletResponse response)
...@@ -379,8 +379,6 @@ public class HttpBindServlet extends HttpServlet { ...@@ -379,8 +379,6 @@ public class HttpBindServlet extends HttpServlet {
content = "_BOSH_(\"" + StringEscapeUtils.escapeJavaScript(content) + "\")"; content = "_BOSH_(\"" + StringEscapeUtils.escapeJavaScript(content) + "\")";
} }
addCORSHeaders(request, response);
if (JiveGlobals.getBooleanProperty("log.httpbind.enabled", false)) { if (JiveGlobals.getBooleanProperty("log.httpbind.enabled", false)) {
System.out.println(new Date()+": HTTP SENT(" + session.getStreamID().getID() + "): " + content); System.out.println(new Date()+": HTTP SENT(" + session.getStreamID().getID() + "): " + content);
} }
...@@ -390,8 +388,7 @@ public class HttpBindServlet extends HttpServlet { ...@@ -390,8 +388,7 @@ public class HttpBindServlet extends HttpServlet {
response.getOutputStream().close(); response.getOutputStream().close();
} }
private void addCORSHeaders(HttpServletRequest request, HttpServletResponse response) private void addCORSHeaders(HttpServletRequest request, HttpServletResponse response) {
throws IOException {
// add CORS headers // add CORS headers
if (boshManager.isCORSEnabled()) { if (boshManager.isCORSEnabled()) {
if (boshManager.isAllOriginsAllowed()) if (boshManager.isAllOriginsAllowed())
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment