OF-966 <failure> tag not closed for TLS Negotitation Failure

4866cd46 · akrherz · Christian Schudt · 66f6a822 · 4866cd46 · 4866cd46
Commit 4866cd46 authored Oct 30, 2015 by akrherz Committed by Christian Schudt Nov 12, 2015
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

SocketReadingMode.java ...java/org/jivesoftware/openfire/net/SocketReadingMode.java +1 -1

StanzaHandler.java src/java/org/jivesoftware/openfire/net/StanzaHandler.java +1 -1

No files found.
--- a/src/java/org/jivesoftware/openfire/net/SocketReadingMode.java
+++ b/src/java/org/jivesoftware/openfire/net/SocketReadingMode.java
@@ -86,7 +86,7 @@ abstract class SocketReadingMode {
        }
        catch (IOException e) {
            Log.error("Error while negotiating TLS: " + socketReader.connection, e);
-            socketReader.connection.deliverRawText("<failure xmlns=\"urn:ietf:params:xml:ns:xmpp-tls\">");
+            socketReader.connection.deliverRawText("<failure xmlns=\"urn:ietf:params:xml:ns:xmpp-tls\"/>");
            socketReader.connection.close();
            return false;
        }

--- a/src/java/org/jivesoftware/openfire/net/StanzaHandler.java
+++ b/src/java/org/jivesoftware/openfire/net/StanzaHandler.java
@@ -404,7 +404,7 @@ public abstract class StanzaHandler {
        }
        catch (Exception e) {
            Log.error("Error while negotiating TLS", e);
-            connection.deliverRawText("<failure xmlns=\"urn:ietf:params:xml:ns:xmpp-tls\">");
+            connection.deliverRawText("<failure xmlns=\"urn:ietf:params:xml:ns:xmpp-tls\"/>");
            connection.close();
            return false;
        }