Commit 443ef34e authored by Matt Tucker's avatar Matt Tucker Committed by matt

Filter out invalid log file name requests. JM-1506

git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@10937 b35dd754-fafc-0310-a699-88a17e54d16e
parent 35355cdf
...@@ -76,6 +76,11 @@ ...@@ -76,6 +76,11 @@
int numLines = ParamUtils.getIntParameter(request,"lines",50); int numLines = ParamUtils.getIntParameter(request,"lines",50);
String mode = ParamUtils.getParameter(request,"mode"); String mode = ParamUtils.getParameter(request,"mode");
// Only allow requests for valid log file names.
if (!("debug".equals(log) || "warn".equals(log) || "info".equals(log) || "error".equals(log))) {
log = null;
}
// Set defaults // Set defaults
if (log == null) { if (log == null) {
log = "error"; log = "error";
...@@ -87,9 +92,6 @@ ...@@ -87,9 +92,6 @@
numLinesParam = "50"; numLinesParam = "50";
} }
// Santize variables to prevent vulnerabilities
log = StringUtils.escapeHTMLTags(log);
// Other vars // Other vars
File logDir = new File(Log.getLogDirectory()); File logDir = new File(Log.getLogDirectory());
String filename = log + ".log"; String filename = log + ".log";
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment