Commit 2a4a29d2 authored by Dave Cridland's avatar Dave Cridland

Fix CSRF protection around truststore manipulation

This also addresses a worrying (but harmless) mis-redirect to a success
page.
parent 04008796
...@@ -140,6 +140,7 @@ ...@@ -140,6 +140,7 @@
<!-- BEGIN 'Import Certificate' --> <!-- BEGIN 'Import Certificate' -->
<form action="import-truststore-certificate.jsp?connectionType=${connectionType}" method="post"> <form action="import-truststore-certificate.jsp?connectionType=${connectionType}" method="post">
<input type="hidden" name="csrf" value="${csrf}">
<fmt:message key="ssl.import.certificate.truststore.boxtitle" var="title"/> <fmt:message key="ssl.import.certificate.truststore.boxtitle" var="title"/>
<admin:contentBox title="${title}"> <admin:contentBox title="${title}">
<table cellpadding="3" cellspacing="0" border="0"> <table cellpadding="3" cellspacing="0" border="0">
......
...@@ -79,7 +79,7 @@ ...@@ -79,7 +79,7 @@
// Log the event // Log the event
webManager.logEvent( "deleted SSL cert from " + connectionType + " with alias " + alias, null ); webManager.logEvent( "deleted SSL cert from " + connectionType + " with alias " + alias, null );
response.sendRedirect( "security-keystore.jsp?connectionType=" + connectionType+ "&deletesuccess=true" ); response.sendRedirect( "security-truststore.jsp?connectionType=" + connectionType+ "&deletesuccess=true" );
return; return;
} }
catch ( Exception e ) catch ( Exception e )
...@@ -221,7 +221,7 @@ ...@@ -221,7 +221,7 @@
<c:out value="${certificate.publicKey.algorithm}"/> <c:out value="${certificate.publicKey.algorithm}"/>
</td> </td>
<td width="1" align="center"> <td width="1" align="center">
<a href="security-truststore.jsp?connectionType=${connectionType}&alias=${alias}&delete=true&csrf=csrf" <a href="security-truststore.jsp?connectionType=${connectionType}&alias=${alias}&delete=true&csrf=${csrf}"
title="<fmt:message key="global.click_delete"/>" title="<fmt:message key="global.click_delete"/>"
onclick="return confirm('<fmt:message key="ssl.certificates.confirm_delete"/>');" onclick="return confirm('<fmt:message key="ssl.certificates.confirm_delete"/>');"
><img src="images/delete-16x16.gif" width="16" height="16" border="0" alt=""></a> ><img src="images/delete-16x16.gif" width="16" height="16" border="0" alt=""></a>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment