Moved some cache related classes to org.jivesoftware.util.cache. Made Cache an...

Moved some cache related classes to org.jivesoftware.util.cache. Made Cache an interface and moved its implementation down into DefaultCache. Initial pass at porting CacheFactory from clearspace.

git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@8139 b35dd754-fafc-0310-a699-88a17e54d16e

src/java/org/jivesoftware/openfire/MulticastRouter.java

@@ -12,8 +12,8 @@
 package org.jivesoftware.openfire;
 
 import org.dom4j.Element;
-import org.jivesoftware.util.Cache;
-import org.jivesoftware.util.CacheManager;
+import org.jivesoftware.util.cache.Cache;
+import org.jivesoftware.util.cache.CacheManager;
 import org.jivesoftware.util.JiveConstants;
 import org.jivesoftware.openfire.container.BasicModule;
 import org.jivesoftware.openfire.disco.ServerFeaturesProvider;

src/java/org/jivesoftware/openfire/OfflineMessageStore.java

@@ -17,6 +17,8 @@ import org.dom4j.io.SAXReader;
 import org.jivesoftware.database.DbConnectionManager;
 import org.jivesoftware.database.SequenceManager;
 import org.jivesoftware.util.*;
+import org.jivesoftware.util.cache.Cache;
+import org.jivesoftware.util.cache.CacheManager;
 import org.jivesoftware.openfire.container.BasicModule;
 import org.jivesoftware.openfire.event.UserEventDispatcher;
 import org.jivesoftware.openfire.event.UserEventListener;

src/java/org/jivesoftware/openfire/Permissions.java

@@ -11,9 +11,9 @@
 
 package org.jivesoftware.openfire;
 
-import org.jivesoftware.util.CacheSizes;
+import org.jivesoftware.util.cache.CacheSizes;
 import org.jivesoftware.util.StringUtils;
-import org.jivesoftware.util.Cacheable;
+import org.jivesoftware.util.cache.Cacheable;
 
 /**
  * Represents a set of permissions that an entity has for an object in the system. For example,

src/java/org/jivesoftware/openfire/auth/POP3AuthProvider.java

@@ -12,6 +12,8 @@
 package org.jivesoftware.openfire.auth;
 
 import org.jivesoftware.util.*;
+import org.jivesoftware.util.cache.Cache;
+import org.jivesoftware.util.cache.CacheManager;
 import org.jivesoftware.openfire.user.UserAlreadyExistsException;
 import org.jivesoftware.openfire.user.UserManager;
 import org.jivesoftware.openfire.user.UserNotFoundException;

src/java/org/jivesoftware/openfire/filetransfer/DefaultFileTransferManager.java

@@ -11,7 +11,8 @@
 package org.jivesoftware.openfire.filetransfer;
 
 import org.dom4j.Element;
-import org.jivesoftware.util.Cache;
+import org.jivesoftware.util.cache.Cache;
+import org.jivesoftware.util.cache.DefaultCache;
 import org.jivesoftware.util.JiveGlobals;
 import org.jivesoftware.openfire.auth.UnauthorizedException;
 import org.jivesoftware.openfire.container.BasicModule;
@@ -58,7 +59,7 @@ public class DefaultFileTransferManager extends BasicModule implements FileTrans
         size = JiveGlobals.getIntProperty("cache." + propertiesName + ".size", size);
         expirationTime = (long) JiveGlobals.getIntProperty(
                 "cache." + propertiesName + ".expirationTime", (int) expirationTime);
-        return new Cache<String, FileTransfer>(name, size, expirationTime);
+        return new DefaultCache<String, FileTransfer>(name, size, expirationTime);
     }
 
     /**

src/java/org/jivesoftware/openfire/filetransfer/FileTransfer.java

@@ -10,8 +10,8 @@
  */
 package org.jivesoftware.openfire.filetransfer;
 
-import org.jivesoftware.util.Cacheable;
-import org.jivesoftware.util.CacheSizes;
+import org.jivesoftware.util.cache.Cacheable;
+import org.jivesoftware.util.cache.CacheSizes;
 
 import java.io.Serializable;
 

src/java/org/jivesoftware/openfire/filetransfer/proxy/DefaultProxyTransfer.java

@@ -10,7 +10,7 @@
  */
 package org.jivesoftware.openfire.filetransfer.proxy;
 
-import org.jivesoftware.util.CacheSizes;
+import org.jivesoftware.util.cache.CacheSizes;
 
 import java.util.concurrent.Future;
 import java.io.IOException;

src/java/org/jivesoftware/openfire/filetransfer/proxy/ProxyConnectionManager.java

@@ -11,6 +11,8 @@
 package org.jivesoftware.openfire.filetransfer.proxy;
 
 import org.jivesoftware.util.*;
+import org.jivesoftware.util.cache.Cache;
+import org.jivesoftware.util.cache.DefaultCache;
 import org.jivesoftware.openfire.auth.UnauthorizedException;
 import org.jivesoftware.openfire.filetransfer.FileTransferManager;
 import org.jivesoftware.openfire.filetransfer.FileTransferRejectedException;
@@ -58,7 +60,7 @@ public class ProxyConnectionManager {
 
     public ProxyConnectionManager(FileTransferManager manager) {
         String cacheName = "File Transfer";
-        connectionMap = new Cache<String, ProxyTransfer>(cacheName, -1, 1000 * 60 * 10);
+        connectionMap = new DefaultCache<String, ProxyTransfer>(cacheName, -1, 1000 * 60 * 10);
 
         className = JiveGlobals.getProperty("provider.transfer.proxy",
                 "org.jivesoftware.openfire.filetransfer.proxy.DefaultProxyTransfer");

src/java/org/jivesoftware/openfire/filetransfer/proxy/ProxyTransfer.java

@@ -9,7 +9,7 @@
  */
 package org.jivesoftware.openfire.filetransfer.proxy;
 
-import org.jivesoftware.util.Cacheable;
+import org.jivesoftware.util.cache.Cacheable;
 import org.jivesoftware.openfire.filetransfer.FileTransferProgress;
 
 import java.io.IOException;

src/java/org/jivesoftware/openfire/group/Group.java

@@ -14,8 +14,8 @@ package org.jivesoftware.openfire.group;
 import org.jivesoftware.database.DbConnectionManager;
 import org.jivesoftware.openfire.XMPPServer;
 import org.jivesoftware.openfire.event.GroupEventDispatcher;
-import org.jivesoftware.util.CacheSizes;
-import org.jivesoftware.util.Cacheable;
+import org.jivesoftware.util.cache.CacheSizes;
+import org.jivesoftware.util.cache.Cacheable;
 import org.jivesoftware.util.Log;
 import org.xmpp.packet.JID;
 

src/java/org/jivesoftware/openfire/group/GroupManager.java

@@ -12,6 +12,8 @@
 package org.jivesoftware.openfire.group;
 
 import org.jivesoftware.util.*;
+import org.jivesoftware.util.cache.Cache;
+import org.jivesoftware.util.cache.CacheManager;
 import org.jivesoftware.openfire.XMPPServer;
 import org.jivesoftware.openfire.event.GroupEventDispatcher;
 import org.jivesoftware.openfire.event.GroupEventListener;

src/java/org/jivesoftware/openfire/http/ResourceServlet.java

@@ -11,6 +11,8 @@
 package org.jivesoftware.openfire.http;
 
 import org.jivesoftware.util.*;
+import org.jivesoftware.util.cache.Cache;
+import org.jivesoftware.util.cache.CacheManager;
 
 import javax.servlet.http.HttpServlet;
 import javax.servlet.http.HttpServletRequest;

src/java/org/jivesoftware/openfire/ldap/LdapAuthProvider.java

@@ -12,6 +12,8 @@
 package org.jivesoftware.openfire.ldap;
 
 import org.jivesoftware.util.*;
+import org.jivesoftware.util.cache.Cache;
+import org.jivesoftware.util.cache.CacheManager;
 import org.jivesoftware.openfire.auth.AuthProvider;
 import org.jivesoftware.openfire.auth.UnauthorizedException;
 import org.jivesoftware.openfire.user.UserNotFoundException;

src/java/org/jivesoftware/openfire/privacy/PrivacyItem.java

@@ -12,8 +12,8 @@
 package org.jivesoftware.openfire.privacy;
 
 import org.dom4j.Element;
-import org.jivesoftware.util.CacheSizes;
-import org.jivesoftware.util.Cacheable;
+import org.jivesoftware.util.cache.CacheSizes;
+import org.jivesoftware.util.cache.Cacheable;
 import org.jivesoftware.openfire.roster.Roster;
 import org.jivesoftware.openfire.roster.RosterItem;
 import org.jivesoftware.openfire.user.UserNotFoundException;

src/java/org/jivesoftware/openfire/privacy/PrivacyList.java

@@ -13,8 +13,8 @@ package org.jivesoftware.openfire.privacy;
 
 import org.dom4j.DocumentFactory;
 import org.dom4j.Element;
-import org.jivesoftware.util.CacheSizes;
-import org.jivesoftware.util.Cacheable;
+import org.jivesoftware.util.cache.CacheSizes;
+import org.jivesoftware.util.cache.Cacheable;
 import org.jivesoftware.util.Log;
 import org.jivesoftware.openfire.XMPPServer;
 import org.jivesoftware.openfire.roster.Roster;

src/java/org/jivesoftware/openfire/privacy/PrivacyListManager.java

 package org.jivesoftware.openfire.privacy;
 
 import org.dom4j.Element;
-import org.jivesoftware.util.Cache;
-import org.jivesoftware.util.CacheManager;
+import org.jivesoftware.util.cache.Cache;
+import org.jivesoftware.util.cache.CacheManager;
 
 /**
  * A Privacy list manager creates, gets, updates and removes privacy lists. Loaded lists

src/java/org/jivesoftware/openfire/roster/Roster.java

@@ -12,8 +12,8 @@
 package org.jivesoftware.openfire.roster;
 
 import org.jivesoftware.database.JiveID;
-import org.jivesoftware.util.CacheSizes;
-import org.jivesoftware.util.Cacheable;
+import org.jivesoftware.util.cache.CacheSizes;
+import org.jivesoftware.util.cache.Cacheable;
 import org.jivesoftware.util.JiveConstants;
 import org.jivesoftware.util.Log;
 import org.jivesoftware.openfire.*;

src/java/org/jivesoftware/openfire/roster/RosterItem.java

@@ -11,8 +11,8 @@
 
 package org.jivesoftware.openfire.roster;
 
-import org.jivesoftware.util.CacheSizes;
-import org.jivesoftware.util.Cacheable;
+import org.jivesoftware.util.cache.CacheSizes;
+import org.jivesoftware.util.cache.Cacheable;
 import org.jivesoftware.util.IntEnum;
 import org.jivesoftware.openfire.SharedGroupException;
 import org.jivesoftware.openfire.group.Group;

src/java/org/jivesoftware/openfire/roster/RosterManager.java

@@ -11,8 +11,8 @@
 
 package org.jivesoftware.openfire.roster;
 
-import org.jivesoftware.util.Cache;
-import org.jivesoftware.util.CacheManager;
+import org.jivesoftware.util.cache.Cache;
+import org.jivesoftware.util.cache.CacheManager;
 import org.jivesoftware.util.JiveGlobals;
 import org.jivesoftware.openfire.ChannelHandler;
 import org.jivesoftware.openfire.RoutingTable;

src/java/org/jivesoftware/openfire/spi/PresenceManagerImpl.java

@@ -16,6 +16,8 @@ import org.dom4j.DocumentException;
 import org.dom4j.DocumentHelper;
 import org.jivesoftware.database.DbConnectionManager;
 import org.jivesoftware.util.*;
+import org.jivesoftware.util.cache.Cache;
+import org.jivesoftware.util.cache.CacheManager;
 import org.jivesoftware.openfire.PacketDeliverer;
 import org.jivesoftware.openfire.PresenceManager;
 import org.jivesoftware.openfire.SessionManager;

src/java/org/jivesoftware/openfire/user/User.java

@@ -16,8 +16,8 @@ import org.jivesoftware.openfire.XMPPServer;
 import org.jivesoftware.openfire.auth.AuthFactory;
 import org.jivesoftware.openfire.event.UserEventDispatcher;
 import org.jivesoftware.openfire.roster.Roster;
-import org.jivesoftware.util.CacheSizes;
-import org.jivesoftware.util.Cacheable;
+import org.jivesoftware.util.cache.CacheSizes;
+import org.jivesoftware.util.cache.Cacheable;
 import org.jivesoftware.util.Log;
 import org.jivesoftware.util.cache.ExternalizableUtil;
 

src/java/org/jivesoftware/openfire/user/UserManager.java

@@ -19,6 +19,8 @@ import org.jivesoftware.openfire.event.UserEventListener;
 import org.jivesoftware.stringprep.Stringprep;
 import org.jivesoftware.stringprep.StringprepException;
 import org.jivesoftware.util.*;
+import org.jivesoftware.util.cache.Cache;
+import org.jivesoftware.util.cache.CacheManager;
 import org.xmpp.packet.IQ;
 import org.xmpp.packet.JID;
 

src/java/org/jivesoftware/openfire/vcard/VCardManager.java

@@ -13,6 +13,8 @@ package org.jivesoftware.openfire.vcard;
 
 import org.dom4j.Element;
 import org.jivesoftware.util.*;
+import org.jivesoftware.util.cache.Cache;
+import org.jivesoftware.util.cache.CacheManager;
 import org.jivesoftware.openfire.XMPPServer;
 import org.jivesoftware.openfire.container.BasicModule;
 import org.jivesoftware.openfire.disco.ServerFeaturesProvider;

src/java/org/jivesoftware/util/FaviconServlet.java

@@ -15,6 +15,8 @@ import org.apache.commons.httpclient.HttpClient;
 import org.apache.commons.httpclient.MultiThreadedHttpConnectionManager;
 import org.apache.commons.httpclient.methods.GetMethod;
 import org.apache.commons.httpclient.params.HttpConnectionManagerParams;
+import org.jivesoftware.util.cache.Cache;
+import org.jivesoftware.util.cache.CacheManager;
 
 import javax.servlet.ServletConfig;
 import javax.servlet.ServletException;

src/java/org/jivesoftware/util/InitializationException.java

+/**
+ * $Revision$
+ * $Date$
+ *
+ * Copyright (C) 1999-2005 Jive Software. All rights reserved.
+ * This software is the proprietary information of Jive Software. Use is subject to license terms.
+ */
+package org.jivesoftware.util;
+
+import java.io.PrintStream;
+import java.io.PrintWriter;
+
+/**
+ * Exception thrown during application or component initialization failure.
+ */
+public class InitializationException extends Exception {
+    private Throwable nestedThrowable = null;
+
+    public InitializationException() {
+        super();
+    }
+
+    public InitializationException(String msg) {
+        super(msg);
+    }
+
+    public InitializationException(Throwable nestedThrowable) {
+        this.nestedThrowable = nestedThrowable;
+    }
+
+    public InitializationException(String msg, Throwable nestedThrowable) {
+        super(msg);
+        this.nestedThrowable = nestedThrowable;
+    }
+
+    public void printStackTrace() {
+        super.printStackTrace();
+        if (nestedThrowable != null) {
+            nestedThrowable.printStackTrace();
+        }
+    }
+
+    public void printStackTrace(PrintStream ps) {
+        super.printStackTrace(ps);
+        if (nestedThrowable != null) {
+            nestedThrowable.printStackTrace(ps);
+        }
+    }
+
+    public void printStackTrace(PrintWriter pw) {
+        super.printStackTrace(pw);
+        if (nestedThrowable != null) {
+            nestedThrowable.printStackTrace(pw);
+        }
+    }
+}

src/java/org/jivesoftware/util/WebManager.java

@@ -18,6 +18,8 @@ import org.jivesoftware.openfire.muc.MultiUserChatServer;
 import org.jivesoftware.openfire.roster.RosterManager;
 import org.jivesoftware.openfire.user.User;
 import org.jivesoftware.openfire.user.UserManager;
+import org.jivesoftware.util.cache.Cache;
+import org.jivesoftware.util.cache.CacheManager;
 
 import java.io.*;
 import java.net.URL;

src/java/org/jivesoftware/util/cache/Cache.java

+/**
+ * $RCSfile$
+ * $Revision$
+ * $Date$
+ *
+ * Copyright (C) 2004 Jive Software. All rights reserved.
+ *
+ * This software is published under the terms of the GNU Public License (GPL),
+ * a copy of which is included in this distribution.
+ */
+
+package org.jivesoftware.util.cache;
+
+import org.jivesoftware.util.*;
+
+import java.io.IOException;
+import java.io.ObjectOutputStream;
+import java.io.OutputStream;
+import java.util.*;
+
+/**
+ * General purpose cache. It stores objects associated with unique keys in
+ * memory for fast access. All keys and values added to the cache must
+ * implement the Serializable interface. Values may implement the Cacheable
+ * interface, which allows the cache to determine object size much more quickly.
+ * These restrictions allow a cache to never grow larger than a specified number
+ * of bytes and to optionally be distributed over a cluster of servers.<p>
+ *
+ * If the cache does grow too large, objects will be removed such that those
+ * that are accessed least frequently are removed first. Because expiration
+ * happens automatically, the cache makes <b>no</b> gaurantee as to how long
+ * an object will remain in cache after it is put in.<p>
+ *
+ * Optionally, a maximum lifetime for all objects can be specified. In that
+ * case, objects will be deleted from cache after that amount of time, even
+ * if they are frequently accessed. This feature is useful if objects put in
+ * cache represent data that should be periodically refreshed; for example,
+ * information from a database.<p>
+ *
+ * All cache operations are thread safe.<p>
+ *
+ * @see Cacheable
+ */
+public interface Cache<K,V> extends java.util.Map<K,V> {
+
+    /**
+     * Returns the name of the cache.
+     *
+     * @return the name of the cache.
+     */
+    String getName();
+
+    /**
+     * Sets the name of the cache
+     *
+     * @param name the name of the cache
+     */
+    void setName(String name);
+
+    /**
+     * Returns the maximum size of the cache in bytes. If the cache grows larger
+     * than the max size, the least frequently used items will be removed. If
+     * the max cache size is set to -1, there is no size limit.
+     *
+     * @return the maximum size of the cache in bytes.
+     */
+    int getMaxCacheSize();
+
+    /**
+     * Sets the maximum size of the cache in bytes. If the cache grows larger
+     * than the max size, the least frequently used items will be removed. If
+     * the max cache size is set to -1, there is no size limit.
+     *
+     * @param maxSize the maximum size of the cache in bytes.
+     */
+    void setMaxCacheSize(int maxSize);
+
+    /**
+     * Returns the maximum number of milliseconds that any object can live
+     * in cache. Once the specified number of milliseconds passes, the object
+     * will be automatically expried from cache. If the max lifetime is set
+     * to -1, then objects never expire.
+     *
+     * @return the maximum number of milliseconds before objects are expired.
+     */
+    long getMaxLifetime();
+
+    /**
+     * Sets the maximum number of milliseconds that any object can live
+     * in cache. Once the specified number of milliseconds passes, the object
+     * will be automatically expried from cache. If the max lifetime is set
+     * to -1, then objects never expire.
+     *
+     * @param maxLifetime the maximum number of milliseconds before objects are expired.
+     */
+    void setMaxLifetime(long maxLifetime);
+
+    /**
+     * Returns the size of the cache contents in bytes. This value is only a
+     * rough approximation, so cache users should expect that actual VM
+     * memory used by the cache could be significantly higher than the value
+     * reported by this method.
+     *
+     * @return the size of the cache contents in bytes.
+     */
+    int getCacheSize();
+
+    /**
+     * Returns the number of cache hits. A cache hit occurs every
+     * time the get method is called and the cache contains the requested
+     * object.<p>
+     *
+     * Keeping track of cache hits and misses lets one measure how efficient
+     * the cache is; the higher the percentage of hits, the more efficient.
+     *
+     * @return the number of cache hits.
+     */
+    long getCacheHits();
+
+    /**
+     * Returns the number of cache misses. A cache miss occurs every
+     * time the get method is called and the cache does not contain the
+     * requested object.<p>
+     *
+     * Keeping track of cache hits and misses lets one measure how efficient
+     * the cache is; the higher the percentage of hits, the more efficient.
+     *
+     * @return the number of cache hits.
+     */
+    long getCacheMisses();
+
+}

src/java/org/jivesoftware/util/cache/CacheFactoryStrategy.java

+/**
+ * $Revision$
+ * $Date$
+ *
+ * Copyright (C) 1999-2005 Jive Software. All rights reserved.
+ * This software is the proprietary information of Jive Software. Use is subject to license terms.
+ */
+package org.jivesoftware.util.cache;
+
+import java.util.Collection;
+import java.util.Map;
+
+/**
+ * Implementation of CacheFactory that relies on the specific clustering solution.
+ *
+ * @author Gaston Dombiak
+ */
+public interface CacheFactoryStrategy {
+
+    /**
+     * Returns true if the cluster has been started. When running in local
+     * mode a true value should be returned.<p>
+     *
+     * An error should be logged when the cluster fails to be started.
+     *
+     * @return true if the cluster has been started.
+     */
+    boolean startCluster();
+
+    /**
+     * Stops the cluster. When not running in a cluster this request will be ignored.
+     */
+    void stopCluster();
+
+    /**
+     * Creates a new cache for the cache name specified. The created cache is
+     * already configured. Different implementations could store the cache
+     * configuration in different ways. It is recommended to store the cache
+     * configuration in an external file so it is easier for customers to change
+     * the default configuration.
+     *
+     * @param name name of the cache to create.
+     * @return newly created and configured cache.
+     */
+    Cache createCache(String name);
+
+    /**
+     * Returns true if this node is the maste node of the cluster. When not running
+     * in cluster mode a value of true should be returned.
+     *
+     * @return true if this node is the maste node of the cluster.
+     */
+    boolean isSeniorClusterMember();
+
+    /**
+     * Returns a string uniquely identifying this member within the cluster.
+     *
+     * @return a string uniquely identifying this member within the cluster.
+     */
+    String getClusterMemberID();
+
+    /**
+     * Invokes a task on other cluster members in an asynchronous fashion. The task will not be
+     * executed on the local cluster member. If clustering is not enabled, this method
+     * will do nothing.
+     *
+     * @param task the task to be invoked on all other cluster members.
+     */
+    void doClusterTask(final ClusterTask task);
+
+    /**
+     * Invokes a task on other cluster members synchronously and returns the result as a Collection
+     * (method will not return until the task has been executed on each cluster member).
+     * The task will not be executed on the local cluster member. If clustering is not enabled,
+     * this method will return an empty collection.
+     *
+     * @param task               the ClusterTask object to be invoked on all other cluster members.
+     * @param includeLocalMember true to run the task on the local member, false otherwise
+     * @return collection with the result of the execution.
+     */
+    Collection<Object> doSynchronousClusterTask(ClusterTask task, boolean includeLocalMember);
+
+    /**
+     * Updates the statistics of the specified caches and publishes them into
+     * a cache for statistics. The statistics cache is already known to the application
+     * but this could change in the future (?). When not in cluster mode then
+     * do nothing.<p>
+     *
+     * The statistics cache must contain a long array of 5 positions for each cache
+     * with the following content:
+     * <ol>
+     *  <li>cache.getCacheSize()</li>
+     *  <li>cache.getMaxCacheSize()</li>
+     *  <li>cache.size()</li>
+     *  <li>cache.getCacheHits()</li>
+     *  <li>cache.getCacheMisses()</li>
+     * </ol>
+     *
+     * @param caches caches to get their stats and publish them in a statistics cache.
+     */
+    void updateCacheStats(Map<String, Cache> caches);
+
+    /**
+     * Locks the specified key in the locking map. The map should be clusterable
+     * thus locking a key is visible to the cluster. When not in cluster mode
+     * the lock is only visible to this JVM.
+     *
+     * @param key the key to lock.
+     * @param timeout number of milliseconds to wait to obtain the lock. -1 means wait forever.
+     */
+    void lockKey(Object key, long timeout);
+
+    /**
+     * Unlocks the specified key in the locking map. The map should be clusterable
+     * thus locking a key is visible to the cluster. When not in cluster mode
+     * the lock is only visible to this JVM.
+     *
+     * @param key the key to unlock.
+     */
+    void unlockKey(Object key);
+}

src/java/org/jivesoftware/util/CacheManager.java → src/java/org/jivesoftware/util/cache/CacheManager.java

@@ -7,7 +7,11 @@
  * Use is subject to license terms.
  */
 
-package org.jivesoftware.util;
+package org.jivesoftware.util.cache;
+
+import org.jivesoftware.util.cache.Cache;
+import org.jivesoftware.util.JiveConstants;
+import org.jivesoftware.util.JiveGlobals;
 
 import java.util.Collection;
 import java.util.HashMap;
@@ -73,7 +77,7 @@ public class CacheManager {
             size = JiveGlobals.getIntProperty("cache." + propertiesName + ".size", size);
             expirationTime = (long) JiveGlobals.getIntProperty(
                     "cache." + propertiesName + ".expirationTime", (int) expirationTime);
-            cache = new Cache<K,V>(name, size, expirationTime);
+            cache = new DefaultCache<K,V>(name, size, expirationTime);
             caches.put(name, cache);
         }
         return cache;

src/java/org/jivesoftware/util/CacheSizes.java → src/java/org/jivesoftware/util/cache/CacheSizes.java

@@ -9,7 +9,9 @@
  * a copy of which is included in this distribution.
  */
 
-package org.jivesoftware.util;
+package org.jivesoftware.util.cache;
+
+import org.jivesoftware.util.cache.Cacheable;
 
 import java.util.Map;
 import java.util.Collection;

src/java/org/jivesoftware/util/cache/CacheWrapper.java

+/**
+ * $Revision$
+ * $Date$
+ *
+ * Copyright (C) 1999-2005 Jive Software. All rights reserved.
+ * This software is the proprietary information of Jive Software. Use is subject to license terms.
+ */
+package org.jivesoftware.util.cache;
+
+import java.util.*;
+
+/**
+ * Acts as a proxy for a Cache implementation. The Cache implementation can be switched on the fly,
+ * which enables users to hold a reference to a CacheWrapper object, but for the underlying
+ * Cache implementation to switch from clustered to local, etc.
+ *
+ */
+public class CacheWrapper<K, V> implements Cache<K, V> {
+
+    private Cache<K, V> cache;
+
+    public CacheWrapper(Cache<K, V> cache) {
+        this.cache = cache;
+    }
+
+    public Cache<K, V> getWrappedCache() {
+        return cache;
+    }
+
+    public void setWrappedCache(Cache<K, V> cache) {
+        this.cache = cache;
+    }
+
+    public String getName() {
+        return cache.getName();
+    }
+
+    public void setName(String name) {
+        cache.setName(name);
+    }
+
+    public int getMaxCacheSize() {
+        return cache.getMaxCacheSize();
+    }
+
+    public void setMaxCacheSize(int maxSize) {
+        cache.setMaxCacheSize(maxSize);
+    }
+
+    public long getMaxLifetime() {
+        return cache.getMaxLifetime();
+    }
+
+    public void setMaxLifetime(long maxLifetime) {
+        cache.setMaxLifetime(maxLifetime);
+    }
+
+    public int getCacheSize() {
+        return cache.getCacheSize();
+    }
+
+    public long getCacheHits() {
+        return cache.getCacheHits();
+    }
+
+    public long getCacheMisses() {
+        return cache.getCacheMisses();
+    }
+
+    public int size() {
+        return cache.size();
+    }
+
+    public void clear() {
+        cache.clear();
+    }
+
+    public boolean isEmpty() {
+        return cache.isEmpty();
+    }
+
+    public boolean containsKey(Object key) {
+        return cache.containsKey(key);
+    }
+
+    public boolean containsValue(Object value) {
+        return cache.containsValue(value);
+    }
+
+    public Collection<V> values() {
+        return cache.values();
+    }
+
+    public void putAll(Map<? extends K, ? extends V> t) {
+        cache.putAll(t);
+    }
+
+    public Set<Map.Entry<K, V>> entrySet() {
+        return cache.entrySet();
+    }
+
+    public Set<K> keySet() {
+        return cache.keySet();
+    }
+
+    public V get(Object key) {
+        return cache.get(key);
+    }
+
+    public V remove(Object key) {
+        return cache.remove(key);
+    }
+
+    public V put(K key, V value) {
+        return cache.put(key, value);
+    }
+
+}
\ No newline at end of file

src/java/org/jivesoftware/util/Cacheable.java → src/java/org/jivesoftware/util/cache/Cacheable.java

@@ -9,7 +9,7 @@
  * a copy of which is included in this distribution.
  */
 
-package org.jivesoftware.util;
+package org.jivesoftware.util.cache;
 
 /**
  * Interface that defines the necessary behavior for objects added to a Cache.
@@ -22,7 +22,7 @@ package org.jivesoftware.util;
  * speedy.
  *
  * @author Jive Software
- * @see org.jivesoftware.util.Cache
+ * @see org.jivesoftware.util.cache.Cache
  */
 public interface Cacheable extends java.io.Serializable {
 

src/java/org/jivesoftware/util/cache/ClusterTask.java

+/**
+ * $Revision$
+ * $Date$
+ *
+ * Copyright (C) 1999-2005 Jive Software. All rights reserved.
+ * This software is the proprietary information of Jive Software. Use is subject to license terms.
+ */
+package org.jivesoftware.util.cache;
+
+import java.io.Serializable;
+
+/**
+ * An interface to mix in Serializable and Runnable, which are both required for
+ * sending invocable tasks across a cluster.
+ */
+public interface ClusterTask extends Runnable, Serializable {
+
+    public Object getResult();
+
+}
+

src/web/system-cache.jsp

-<%@ page import="org.jivesoftware.util.Cache"%>
+<%@ page import="org.jivesoftware.util.cache.Cache"%>
 <%@ page import="org.jivesoftware.util.ParamUtils"%>
 <%@ page import="java.text.DecimalFormat"%>
 <%--
@@ -90,17 +90,17 @@
     </head>
     <body>
 
-<%  // Get parameters
+<% // Get parameters
     boolean doClearCache = request.getParameter("clear") != null;
-    int refresh = ParamUtils.getIntParameter(request,"refresh",-1);
-    int[] cacheIDs = ParamUtils.getIntParameters(request,"cacheID",-1);
+    int refresh = ParamUtils.getIntParameter(request, "refresh", -1);
+    int[] cacheIDs = ParamUtils.getIntParameters(request, "cacheID", -1);
 
     // Get the list of existing caches
     Cache[] caches = webManager.getCaches();
 
     // Clear one or multiple caches if requested.
     if (doClearCache) {
-        for (int i=0; i<cacheIDs.length; i++) {
+        for (int i = 0; i < cacheIDs.length; i++) {
             caches[cacheIDs[i]].clear();
         }
     }