OF-1498: Monitoring plugin: Fix stanza reconstruction

1b5d8465 · Guus der Kinderen · 8c0da0f4 · 1b5d8465 · 1b5d8465
Commit 1b5d8465 authored Feb 25, 2018 by Guus der Kinderen
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

changelog.html src/plugins/monitoring/changelog.html +1 -0

IQQueryHandler.java ...eucon/openfire/plugin/archive/xep0313/IQQueryHandler.java +1 -1

No files found.
--- a/src/plugins/monitoring/changelog.html
+++ b/src/plugins/monitoring/changelog.html
@@ -49,6 +49,7 @@ Monitoring Plugin Changelog
    <li>[<a href='https://issues.igniterealtime.org/browse/OF-1486'>OF-1486</a>] - MAM RSM queries for MUC should allow for 'backwards-paging'.</li>
    <li>[<a href='https://issues.igniterealtime.org/browse/OF-1487'>OF-1487</a>] - Archived messages should become available in the database instantly.</li>
    <li>[<a href='https://issues.igniterealtime.org/browse/OF-1200'>OF-1200</a>] - Don't answer MAM queries before relevant archives have been stored.</li>
+    <li>[<a href='https://issues.igniterealtime.org/browse/OF-1498'>OF-1498</a>] - Fix for stanza reconstruction bug.</li>
 </ul>

 <p><b>1.5.9</b> -- Feb 13, 2018</p>

--- a/src/plugins/monitoring/src/java/com/reucon/openfire/plugin/archive/xep0313/IQQueryHandler.java
+++ b/src/plugins/monitoring/src/java/com/reucon/openfire/plugin/archive/xep0313/IQQueryHandler.java
@@ -339,7 +339,7 @@ abstract class IQQueryHandler extends AbstractIQHandler implements
        if(stanzaText == null || stanzaText.equals("")) {
            // Try creating a fake one from the body.
            if (archivedMessage.getBody() != null && !archivedMessage.getBody().equals("")) {
-                stanzaText = String.format("<message from=\"{}\" to=\"{}\" type=\"chat\"><body>{}</body>", archivedMessage.getWithJid(), archivedMessage.getWithJid(), archivedMessage.getBody());
+                stanzaText = String.format("<message from=\"%s\" to=\"%s\" type=\"chat\"><body>%s</body>", archivedMessage.getWithJid(), archivedMessage.getWithJid(), archivedMessage.getBody());
            } else {
                // Don't send legacy archived messages (that have no stanza)
                return;