1. 20 Apr, 2018 5 commits
    • Marius Volkhart's avatar
      Only allow Openable content in Storage Access Framework · ef5dac97
      Marius Volkhart authored
      Add the CATEGORY_OPENABLE to the Intent to launch the Storage Access Framework (SAF) when sending a file. Setting this category ensures that the OpenableColumns data contract is met by the opened data, which we rely upon during data upload.
      
      In practice, some content, such as Contacts, will no longer display in the SAF UI.
      
      Fixes #935
      ef5dac97
    • Filipe de Lima Brito's avatar
      Merge pull request #1141 from MariusVolkhart/mv/storagePermission · fab10670
      Filipe de Lima Brito authored
      Remove the request for READ_EXTERNAL_STORAGE permission
      fab10670
    • Filipe de Lima Brito's avatar
      Merge pull request #1139 from MariusVolkhart/mv/socketStatusStrings · 11ae4a67
      Filipe de Lima Brito authored
      Capitalize socket connection status strings
      11ae4a67
    • Marius Volkhart's avatar
      Remove the request for READ_EXTERNAL_STORAGE permission · e12c1a2a
      Marius Volkhart authored
      We use the Storage Access Framework (SAF) to enable users to send files. When using the SAF, READ_EXTERNAL_STORAGE permission is not needed to read from internal storage, SD Cards, or anything else. The Android System is the one accessing the storage, so applications do not need direct access. This is in fact one of the major selling points of the SAF.
      
      Note that no Google samples or apps by Google Developer Advocates that highlight the SAF request this permission.
      
      Removing this permission is a good thing. Firstly, there are many SAF providers such as Google Drive, Photos, Microsoft OneDrive, etc, that do not use external storage. Secondly, users are not prompted for a needless permission. Thirdly, it reduces the complexity of the ChatRoomFragment.
      e12c1a2a
    • Marius Volkhart's avatar
      Capitalize socket connection status strings · 74bec1fd
      Marius Volkhart authored
      These strings are displayed to users, and accordingly, should be match the capitalization of other text.
      74bec1fd
  2. 16 Apr, 2018 10 commits
  3. 14 Apr, 2018 12 commits
  4. 13 Apr, 2018 13 commits