Lint fixes

app/src/main/java/chat/rocket/android/chatroom/ui/ChatRoomFragment.kt

@@ -589,7 +589,7 @@ class ChatRoomFragment : Fragment(), ChatRoomView, EmojiKeyboardListener, EmojiR
 
     private fun setupRecyclerView() {
         // Initialize the endlessRecyclerViewScrollListener so we don't NPE at onDestroyView
-        val linearLayoutManager = LinearLayoutManager(context, LinearLayoutManager.VERTICAL, true)
+        val linearLayoutManager = LinearLayoutManager(context, RecyclerView.VERTICAL, true)
         linearLayoutManager.stackFromEnd = true
         recycler_view.layoutManager = linearLayoutManager
         recycler_view.itemAnimator = DefaultItemAnimator()

app/src/main/java/chat/rocket/android/chatroom/ui/bottomsheet/BottomSheetMenu.kt

@@ -11,7 +11,7 @@ class BottomSheetMenu(adapter: MenuAdapter) : SheetMenu(adapter = adapter) {
 
     override fun processRecycler(recycler: RecyclerView, dialog: BottomSheetDialog) {
         if (layoutManager == null) {
-            layoutManager = LinearLayoutManager(recycler.context, LinearLayoutManager.VERTICAL, false)
+            layoutManager = LinearLayoutManager(recycler.context)
         }
 
         // Superclass SheetMenu adapter property is nullable MenuAdapter? but this class enforces

app/src/main/java/chat/rocket/android/chatrooms/ui/ChatRoomsFragment.kt

@@ -104,7 +104,7 @@ class ChatRoomsFragment : Fragment(), ChatRoomsView {
                 }
             }
 
-            recycler_view.layoutManager = LinearLayoutManager(it, LinearLayoutManager.VERTICAL, false)
+            recycler_view.layoutManager = LinearLayoutManager(it)
             recycler_view.addItemDecoration(DividerItemDecoration(it,
                     resources.getDimensionPixelSize(R.dimen.divider_item_decorator_bound_start),
                     resources.getDimensionPixelSize(R.dimen.divider_item_decorator_bound_end)))

app/src/main/java/chat/rocket/android/members/ui/MembersFragment.kt

@@ -40,7 +40,7 @@ private const val BUNDLE_CHAT_ROOM_TYPE = "chat_room_type"
 class MembersFragment : Fragment(), MembersView {
     @Inject lateinit var presenter: MembersPresenter
     private val adapter: MembersAdapter = MembersAdapter { memberViewModel -> presenter.toMemberDetails(memberViewModel) }
-    private val linearLayoutManager = LinearLayoutManager(context, LinearLayoutManager.VERTICAL, false)
+    private val linearLayoutManager = LinearLayoutManager(context)
 
     private lateinit var chatRoomId: String
     private lateinit var chatRoomType: String

app/src/main/java/chat/rocket/android/pinnedmessages/ui/PinnedMessagesFragment.kt

@@ -71,7 +71,7 @@ class PinnedMessagesFragment : Fragment(), PinnedMessagesView {
             if (recycler_view_pinned.adapter == null){
                 adapter = ChatRoomAdapter(chatRoomType,"",null,false)
                 recycler_view_pinned.adapter = adapter
-                val linearLayoutManager = LinearLayoutManager(context, LinearLayoutManager.VERTICAL, false)
+                val linearLayoutManager = LinearLayoutManager(context)
                 recycler_view_pinned.layoutManager = linearLayoutManager
                 recycler_view_pinned.itemAnimator = DefaultItemAnimator()
                 if (pinnedMessages.size > 10){

app/src/main/java/chat/rocket/android/widget/autocompletion/ui/SuggestionsView.kt

@@ -46,8 +46,7 @@ class SuggestionsView : FrameLayout, TextWatcher {
     constructor(context: Context, attrs: AttributeSet?) : this(context, attrs, 0)
     constructor(context: Context, attrs: AttributeSet?, defStyleAttr: Int) : super(context, attrs, defStyleAttr, 0) {
         recyclerView = RecyclerView(context)
-        val layoutManager = LinearLayoutManager(context, LinearLayoutManager.VERTICAL,
-                false)
+        val layoutManager = LinearLayoutManager(context)
         recyclerView.itemAnimator = DefaultItemAnimator()
         recyclerView.addItemDecoration(TopItemDecoration(context, R.drawable.suggestions_menu_decorator))
         recyclerView.layoutManager = layoutManager

app/src/main/java/chat/rocket/android/widget/emoji/EmojiRepository.kt

@@ -119,17 +119,12 @@ object EmojiRepository {
      */
     fun shortnameToUnicode(input: CharSequence, removeIfUnsupported: Boolean): String {
         val matcher = SHORTNAME_PATTERN.matcher(input)
-        val supported = Build.VERSION.SDK_INT >= 16
         var result: String = input.toString()
 
         while (matcher.find()) {
             val unicode = shortNameToUnicode.get(":${matcher.group(1)}:") ?: continue
 
-            if (supported) {
-                result = result.replace(":" + matcher.group(1) + ":", unicode)
-            } else if (!supported && removeIfUnsupported) {
-                result = result.replace(":" + matcher.group(1) + ":", "")
-            }
+            result = result.replace(":" + matcher.group(1) + ":", unicode)
         }
 
         return result