Add jitsi call started system message support.

app/src/main/java/chat/rocket/android/authentication/login/ui/LoginFragment.kt

@@ -93,7 +93,7 @@ class LoginFragment : Fragment(), LoginView {
                             text_username_or_email.setText(credential.first)
                             text_password.setText(credential.second)
                         }
-                    REQUEST_CODE_FOR_SAVE_RESOLUTION -> showMessage(getString(R.string.message_credentials_saved_successfully))
+                    REQUEST_CODE_FOR_SAVE_RESOLUTION -> showMessage(getString(R.string.msg_credentials_saved_successfully))
                 }
             }
         }

app/src/main/java/chat/rocket/android/authentication/signup/ui/SignupFragment.kt

@@ -63,7 +63,7 @@ class SignupFragment : Fragment(), SignupView {
         if (resultCode == Activity.RESULT_OK) {
             if (data != null) {
                 if (requestCode == SAVE_CREDENTIALS) {
-                    showMessage(getString(R.string.message_credentials_saved_successfully))
+                    showMessage(getString(R.string.msg_credentials_saved_successfully))
                 }
             }
         }

app/src/main/java/chat/rocket/android/chatdetails/presentation/ChatDetailsPresenter.kt

@@ -30,8 +30,8 @@ class ChatDetailsPresenter @Inject constructor(
     fun toggleFavoriteChatRoom(roomId: String, isFavorite: Boolean) {
         launchUI(strategy) {
             try {
-                // Note that if it is favorite then the user wants to unfavorite - and vice versa.
-                retryIO("favorite($roomId, $isFavorite)") {
+                // Note: If it is favorite then the user wants to remove the favorite - and vice versa.
+                retryIO("favorite($roomId, ${!isFavorite})") {
                     client.favorite(roomId, !isFavorite)
                 }
                 view.showFavoriteIcon(!isFavorite)
@@ -46,6 +46,9 @@ class ChatDetailsPresenter @Inject constructor(
         }
     }
 
+    // TODO
+    fun startVideoCall() {}
+
     fun getDetails(chatRoomId: String, chatRoomType: String) {
         launchUI(strategy) {
             try {

app/src/main/java/chat/rocket/android/chatdetails/ui/ChatDetailsFragment.kt

@@ -37,10 +37,11 @@ fun newInstance(
     disableMenu: Boolean
 ): ChatDetailsFragment {
     return ChatDetailsFragment().apply {
-        arguments = Bundle(4).apply {
+        arguments = Bundle(5).apply {
             putString(BUNDLE_CHAT_ROOM_ID, chatRoomId)
             putString(BUNDLE_CHAT_ROOM_TYPE, chatRoomType)
             putBoolean(BUNDLE_IS_SUBSCRIBED, isSubscribed)
+            putBoolean(BUNDLE_IS_FAVORITE, isFavorite)
             putBoolean(BUNDLE_DISABLE_MENU, disableMenu)
         }
     }

app/src/main/java/chat/rocket/android/chatdetails/ui/Menu.kt

@@ -31,10 +31,7 @@ internal fun ChatDetailsFragment.setupMenu(menu: Menu) {
 
 internal fun ChatDetailsFragment.setOnMenuItemClickListener(item: MenuItem) {
     if (item.itemId == MENU_ACTION_FAVORITE_REMOVE_FAVORITE) {
-        presenter.toggleFavoriteChatRoom(
-            chatRoomId,
-            isFavorite
-        )
+        presenter.toggleFavoriteChatRoom(chatRoomId, isFavorite)
     } else if (item.itemId == MENU_ACTION_VIDEO_CALL) {
         // TODO
     }

app/src/main/java/chat/rocket/android/chatroom/ui/ChatRoomFragment.kt

@@ -158,7 +158,7 @@ class ChatRoomFragment : Fragment(), ChatRoomView, EmojiKeyboardListener, EmojiR
     internal lateinit var chatRoomType: String
     private var newMessageCount: Int = 0
     private var chatRoomMessage: String? = null
-    internal var isSubscribed: Boolean = true
+    private var isSubscribed: Boolean = true
     private var isReadOnly: Boolean = false
     private var isCreator: Boolean = false
     internal var isFavorite: Boolean = false
@@ -168,7 +168,7 @@ class ChatRoomFragment : Fragment(), ChatRoomView, EmojiKeyboardListener, EmojiR
     private lateinit var actionSnackbar: ActionSnackbar
     internal var citation: String? = null
     private var editingMessageId: String? = null
-    internal var disableMenu: Boolean = false
+    private var disableMenu: Boolean = false
 
     private val compositeDisposable = CompositeDisposable()
     private var playComposeMessageButtonsAnimation = true

app/src/main/java/chat/rocket/android/chatroom/uimodel/UiModelMapper.kt

@@ -542,30 +542,67 @@ class UiModelMapper @Inject constructor(
         }
     }
 
-    private fun getSystemMessage(message: Message): CharSequence {
+    private fun s(message: Message): CharSequence {
         val content = when (message.type) {
             //TODO: Add implementation for Welcome type.
             is MessageType.MessageRemoved -> context.getString(R.string.message_removed)
             is MessageType.UserJoined -> context.getString(R.string.message_user_joined_channel)
             is MessageType.UserLeft -> context.getString(R.string.message_user_left)
-            is MessageType.UserAdded -> context.getString(R.string.message_user_added_by, message.message, message.sender?.username)
-            is MessageType.RoomNameChanged -> context.getString(R.string.message_room_name_changed, message.message, message.sender?.username)
-            is MessageType.UserRemoved -> context.getString(R.string.message_user_removed_by, message.message, message.sender?.username)
+            is MessageType.UserAdded -> context.getString(
+                R.string.message_user_added_by,
+                message.message,
+                message.sender?.username
+            )
+            is MessageType.RoomNameChanged -> context.getString(
+                R.string.message_room_name_changed, message.message, message.sender?.username
+            )
+            is MessageType.UserRemoved -> context.getString(
+                R.string.message_user_removed_by,
+                message.message,
+                message.sender?.username
+            )
             is MessageType.MessagePinned -> context.getString(R.string.message_pinned)
-            is MessageType.UserMuted -> context.getString(R.string.message_muted, message.message, message.sender?.username)
-            is MessageType.UserUnMuted -> context.getString(R.string.message_unmuted, message.message, message.sender?.username)
-            is MessageType.SubscriptionRoleAdded -> context.getString(R.string.message_role_add, message.message, message.role, message.sender?.username)
-            is MessageType.SubscriptionRoleRemoved -> context.getString(R.string.message_role_removed, message.message, message.role, message.sender?.username)
-            is MessageType.RoomChangedPrivacy -> context.getString(R.string.message_room_changed_privacy, message.message, message.sender?.username)
+            is MessageType.UserMuted -> context.getString(
+                R.string.message_muted,
+                message.message,
+                message.sender?.username
+            )
+            is MessageType.UserUnMuted -> context.getString(
+                R.string.message_unmuted,
+                message.message,
+                message.sender?.username
+            )
+            is MessageType.SubscriptionRoleAdded -> context.getString(
+                R.string.message_role_add,
+                message.message,
+                message.role,
+                message.sender?.username
+            )
+            is MessageType.SubscriptionRoleRemoved -> context.getString(
+                R.string.message_role_removed,
+                message.message,
+                message.role,
+                message.sender?.username
+            )
+            is MessageType.RoomChangedPrivacy -> context.getString(
+                R.string.message_room_changed_privacy,
+                message.message,
+                message.sender?.username
+            )
+            is MessageType.JitsiCallStarted -> context.getString(
+                R.string.message_video_call_started, message.sender?.username
+            )
             else -> {
                 throw InvalidParameterException("Invalid message type: ${message.type}")
             }
         }
         val spannableMsg = SpannableStringBuilder(content)
-        spannableMsg.setSpan(StyleSpan(Typeface.ITALIC), 0, spannableMsg.length,
-            0)
-        spannableMsg.setSpan(ForegroundColorSpan(Color.GRAY), 0, spannableMsg.length,
-            0)
+        spannableMsg.setSpan(
+            StyleSpan(Typeface.ITALIC), 0, spannableMsg.length, 0
+        )
+        spannableMsg.setSpan(
+            ForegroundColorSpan(Color.GRAY), 0, spannableMsg.length, 0
+        )
 
         return spannableMsg
     }

app/src/main/res/values-de/strings.xml

@@ -176,6 +176,7 @@
         <item quantity="one">%1$ s reagierte mit %2$s</item>
         <item quantity="other">%1$s reagierte mit %2$s</item>
     </plurals>
+    <string name="msg_credentials_saved_successfully">Login-Daten erfolgreich gespeichert</string>
 
 
     <!-- Create channel messages -->
@@ -219,7 +220,7 @@
     <string name="message_unmuted">Benutzer %1$s nicht mehr stumm geschaltet von %2$s</string>
     <string name="message_role_add">%1$s wurde gesetzt %2$s von %3$s</string>
     <string name="message_role_removed">%1$s ist nicht länger %2$s von %3$s</string>
-    <string name="message_credentials_saved_successfully">Login-Daten erfolgreich gespeichert</string>
+    <string name="message_video_call_started">Video call started by %1$s</string> <!-- TODO Add translation -->
 
     <!-- Message actions -->
     <string name="action_msg_reply">Antworten</string>

app/src/main/res/values-es/strings.xml

@@ -188,6 +188,7 @@
         <item quantity="one">%1$s reacted with %2$s</item> <!-- TODO - Add proper translation -->
         <item quantity="other">%1$s reacted with %2$s</item> <!-- TODO - Add proper translation -->
     </plurals>
+    <string name="msg_credentials_saved_successfully">Credenciales guardadas con éxito</string>
 
     <!-- Preferences messages -->
     <string name="msg_analytics_tracking">Analytics tracking</string> <!-- TODO Add translation -->
@@ -208,7 +209,7 @@
     <string name="message_unmuted">Usuario %1$s no silenciado por %2$s</string>
     <string name="message_role_add">%1$s fue establecido %2$s por %3$s</string>
     <string name="message_role_removed">%1$s ya no es %2$s por %3$s</string>
-    <string name="message_credentials_saved_successfully">Credenciales guardadas con éxito</string>
+    <string name="message_video_call_started">Video call started by %1$s</string> <!-- TODO Add translation -->
 
     <!-- Message actions -->
     <string name="action_msg_reply">Respuesta</string>

app/src/main/res/values-fa/strings.xml

@@ -175,6 +175,7 @@
         <item quantity="one">%1$s reacted with %2$s</item>
         <item quantity="other">%1$s reacted with %2$s</item>
     </plurals> <!-- TODO Add translation -->
+    <string name="msg_credentials_saved_successfully">اختیارها با موفقیت ذخیره شد</string>
 
     <!-- Create channel messages -->
     <string name="msg_private_channel">خصوصی</string>
@@ -213,7 +214,7 @@
     <string name="message_unmuted">User %1$s unmuted by %2$s</string> <!-- TODO Add translation -->
     <string name="message_role_add">%1$s was set %2$s by %3$s</string> <!-- TODO Add translation -->
     <string name="message_role_removed">%1$s is no longer %2$s by %3$s</string> <!-- TODO Add translation -->
-    <string name="message_credentials_saved_successfully">اختیارها با موفقیت ذخیره شد</string>
+    <string name="message_video_call_started">Video call started by %1$s</string> <!-- TODO Add translation -->
 
     <!-- Message actions -->
     <string name="action_msg_reply">جواب</string>

app/src/main/res/values-fr/strings.xml

@@ -179,6 +179,7 @@
         <item quantity="one">%1$s reacted with %2$s</item> <!-- TODO - Add proper translation -->
         <item quantity="other">%1$s reacted with %2$s</item> <!-- TODO - Add proper translation -->
     </plurals>
+    <string name="msg_credentials_saved_successfully">Certificats sauvegardés</string>
 
     <!-- Create channel messages -->
     <string name="msg_private_channel">Privé</string>
@@ -211,8 +212,7 @@
     <string name="message_unmuted">Utilisateur %1$s a retrouvé la parole grâce à %2$s</string>
     <string name="message_role_add">%1$s a été défini %2$s par %3$s</string>
     <string name="message_role_removed">%1$s n\'est plus %2$s par %3$s</string>
-
-    <string name="message_credentials_saved_successfully">Certificats sauvegardés</string>
+    <string name="message_video_call_started">Video call started by %1$s</string> <!-- TODO Add translation -->
 
     <!-- Message actions -->
     <string name="action_msg_reply">Répondre</string>

app/src/main/res/values-hi-rIN/strings.xml

@@ -194,6 +194,7 @@
         <item quantity="few">%1$s ने %2$s के साथ प्रतिक्रिया व्यक्त की</item>
         <item quantity="many">%1$s ने %2$s के साथ प्रतिक्रिया व्यक्त की</item>
     </plurals>
+    <string name="msg_credentials_saved_successfully">प्रमाण पत्र सफलतापूर्वक सहेजे गए</string>
 
     <!-- Preferences messages -->
     <string name="msg_analytics_tracking">एनालिटिक्स ट्रैकिंग</string>
@@ -214,7 +215,7 @@
     <string name="message_unmuted">उपयोगकर्ता %1$s %2$s द्वारा अनम्यूट किया गया</string>
     <string name="message_role_add">%1$s %3$s द्वारा %2$s सेट किया गया था</string>
     <string name="message_role_removed">%1$s अब %3$s द्वारा %2$s नहीं है</string>
-    <string name="message_credentials_saved_successfully">प्रमाण पत्र सफलतापूर्वक सहेजे गए</string>
+    <string name="message_video_call_started">Video call started by %1$s</string> <!-- TODO Add translation -->
 
     <!-- Message actions -->
     <string name="action_msg_reply">जवाब दें</string>

app/src/main/res/values-it/strings.xml

@@ -172,6 +172,7 @@
         <item quantity="one">%1$s ha reagito con %2$s</item>
         <item quantity="other">%1$s ha reagito con %2$s</item>
     </plurals>
+    <string name="msg_credentials_saved_successfully">Credenziali salvate con successo</string>
 
     <!-- Create channel messages -->
     <string name="msg_private_channel">Privato</string>
@@ -210,7 +211,7 @@
     <string name="message_unmuted">Utente %1$s riattivato da %2$s</string>
     <string name="message_role_add">%1$s ha il ruolo %2$s aggiunto da %3$s</string>
     <string name="message_role_removed">%1$s ha il ruolo %2$s rimosso da %3$s</string>
-    <string name="message_credentials_saved_successfully">Credenziali salvate con successo</string>
+    <string name="message_video_call_started">Video call started by %1$s</string> <!-- TODO Add translation -->
 
     <!-- Message actions -->
     <string name="action_msg_reply">Rispondi</string>

app/src/main/res/values-ja/strings.xml

@@ -175,6 +175,7 @@
         <item quantity="one">%1$s reacted with %2$s</item> <!-- TODO - Add proper translation -->
         <item quantity="other">%1$s reacted with %2$s</item> <!-- TODO - Add proper translation -->
     </plurals>
+    <string name="msg_credentials_saved_successfully">資格情報を正常に保存しました</string>
 
     <!-- Create channel messages -->
     <string name="msg_private_channel">プライベート</string>
@@ -213,7 +214,7 @@
     <string name="message_unmuted">ユーザー %1$s は %2$s によってミュートされていません</string>
     <string name="message_role_add">%1$s は %3$s によって %2$s に設定されました</string>
     <string name="message_role_removed">%1$s は %3$s で、もう %2$s ではありません</string>
-    <string name="message_credentials_saved_successfully">資格情報を正常に保存しました</string>
+    <string name="message_video_call_started">Video call started by %1$s</string> <!-- TODO Add translation -->
 
     <!-- Message actions -->
     <string name="action_msg_reply">返信</string>

app/src/main/res/values-pt-rBR/strings.xml

@@ -181,6 +181,7 @@
         <item quantity="one">%1$s reagiu com %2$s</item>
         <item quantity="other">%1$s reagiram com %2$s</item>
     </plurals>
+    <string name="msg_credentials_saved_successfully">Credenciais salvas com sucesso</string>
 
     <!-- Create channel messages -->
     <string name="msg_private_channel">Privado</string>
@@ -213,7 +214,7 @@
     <string name="message_unmuted">Usuário %1$s saiu do modo silenciado por %2$s</string>
     <string name="message_role_add">%1$s foi definido %2$s por %3$s</string>
     <string name="message_role_removed">%1$s não é mais %2$s por %3$s</string>
-    <string name="message_credentials_saved_successfully">Credenciais salvas com sucesso</string>
+    <string name="message_video_call_started">Videochamada iniciada por %1$s</string>
 
     <!-- Message actions -->
     <string name="action_msg_reply">Responder</string>

app/src/main/res/values-ru-rRU/strings.xml

@@ -178,6 +178,7 @@
         <item quantity="few">%1$s реагируют с %2$s</item>
         <item quantity="many">%1$s реагируют с %2$s</item>
     </plurals>
+    <string name="msg_credentials_saved_successfully">Учетные данные успешно сохранены</string>
 
     <!-- Create channel messages -->
     <string name="msg_private_channel">Приватный</string>
@@ -210,7 +211,7 @@
     <string name="message_unmuted">Пользователю %1$s вернули дар речи по решению %2$s</string>
     <string name="message_role_add">%1$s был назначен %2$s пользователем %3$s</string>
     <string name="message_role_removed">%1$s больше не %2$s по решению %3$s</string>
-    <string name="message_credentials_saved_successfully">Учетные данные успешно сохранены</string>
+    <string name="message_video_call_started">Video call started by %1$s</string> <!-- TODO Add translation -->
 
     <!-- Message actions -->
     <string name="action_msg_reply">Ответить</string>

app/src/main/res/values-tr/strings.xml

@@ -193,6 +193,7 @@
         <item quantity="one">%1$s reacted with %2$s</item> <!-- TODO - Add proper translation -->
         <item quantity="other">%1$s reacted with %2$s</item> <!-- TODO - Add proper translation -->
     </plurals>
+    <string name="msg_credentials_saved_successfully">Kimlik bilgileri başarıyla kaydedildi</string>
 
     <!-- Preferences messages -->
     <string name="msg_analytics_tracking">İstatistik takibi</string>
@@ -213,7 +214,7 @@
     <string name="message_unmuted">%1$s kullanıcısı %2$s tarafından sessizden çıkarıldı</string>
     <string name="message_role_add">%1$s, %3$s tarafından %2$s olacak şekilde değiştirildi</string>
     <string name="message_role_removed">%1$s, artık %2$s olmayacak şekilde %3$s tarafından değiştirildi</string>
-    <string name="message_credentials_saved_successfully">Kimlik bilgileri başarıyla kaydedildi</string>
+    <string name="message_video_call_started">Video call started by %1$s</string> <!-- TODO Add translation -->
 
     <!-- Message actions -->
     <string name="action_msg_reply">Kaydet</string>

app/src/main/res/values-uk/strings.xml

@@ -177,6 +177,7 @@
         <item quantity="few">%1$s reacted with %2$s</item> <!-- TODO - Add proper translation -->
         <item quantity="many">%1$s reacted with %2$s</item> <!-- TODO - Add proper translation -->
     </plurals>
+    <string name="msg_credentials_saved_successfully">Облікові дані було успішно збережено</string>
 
     <!-- Create channel messages -->
     <string name="msg_private_channel">Приватний</string>
@@ -209,7 +210,7 @@
     <string name="message_unmuted">Користувачу і%1$s повернули дар мови за рішенням %2$s</string>
     <string name="message_role_add">%1$s був призначений як %2$s користувачем %3$s</string>
     <string name="message_role_removed">%1$s більше не %2$s за рішенням %3$s</string>
-    <string name="message_credentials_saved_successfully">Облікові дані було успішно збережено</string>
+    <string name="message_video_call_started">Video call started by %1$s</string> <!-- TODO Add translation -->
 
     <!-- Message actions -->
     <string name="action_msg_reply">Відповісти</string>

app/src/main/res/values-zh-rCN/strings.xml

@@ -172,6 +172,7 @@
         <item quantity="one">%1$s 使用了 %2$s</item>
         <item quantity="other">%1$s 使用了 %2$s</item>
     </plurals>
+    <string name="msg_credentials_saved_successfully">凭证成功保存</string>
 
     <!-- Create channel messages -->
     <string name="msg_private_channel">隐私</string>
@@ -210,7 +211,7 @@
     <string name="message_unmuted">用户 %1$s被%2$s取消禁言</string>
     <string name="message_role_add">%1$s被设置为%2$s 由%3$s操作</string>
     <string name="message_role_removed">%1$s不在是%2$s 由%3$s操作</string>
-    <string name="message_credentials_saved_successfully">凭证成功保存</string>
+    <string name="message_video_call_started">Video call started by %1$s</string> <!-- TODO Add translation -->
 
     <!-- Message actions -->
     <string name="action_msg_reply">回复</string>

app/src/main/res/values/strings.xml

@@ -188,6 +188,7 @@ https://github.com/RocketChat/java-code-styles/blob/master/CODING_STYLE.md#strin
         <item quantity="one">%1$s reacted with %2$s</item>
         <item quantity="other">%1$s reacted with %2$s</item>
     </plurals>
+    <string name="msg_credentials_saved_successfully">Credentials saved successfully</string>
 
     <!-- Create channel messages -->
     <string name="msg_private_channel">Private</string>
@@ -226,7 +227,7 @@ https://github.com/RocketChat/java-code-styles/blob/master/CODING_STYLE.md#strin
     <string name="message_unmuted">User %1$s unmuted by %2$s</string>
     <string name="message_role_add">%1$s was set %2$s by %3$s</string>
     <string name="message_role_removed">%1$s is no longer %2$s by %3$s</string>
-    <string name="message_credentials_saved_successfully">Credentials saved successfully</string>
+    <string name="message_video_call_started">Video call started by %1$s</string>
 
     <!-- Message actions -->
     <string name="action_msg_reply">Reply</string>