Unverified Commit 5b9e6f54 authored by Lucio Maciel's avatar Lucio Maciel Committed by GitHub

Merge branch 'beta' into patch-10

parents b1abb5ca 7ff96cd6
...@@ -16,8 +16,8 @@ android { ...@@ -16,8 +16,8 @@ android {
applicationId "chat.rocket.android" applicationId "chat.rocket.android"
minSdkVersion versions.minSdk minSdkVersion versions.minSdk
targetSdkVersion versions.targetSdk targetSdkVersion versions.targetSdk
versionCode 2043 versionCode 2044
versionName "2.6.1" versionName "3.0.0"
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
multiDexEnabled true multiDexEnabled true
......
...@@ -59,4 +59,9 @@ interface Analytics { ...@@ -59,4 +59,9 @@ interface Analytics {
* @param serverCount The number of server(s) the use own. * @param serverCount The number of server(s) the use own.
*/ */
fun logServerSwitch(serverUrl: String, serverCount: Int) fun logServerSwitch(serverUrl: String, serverCount: Int)
/**
* Logs the admin opening.
*/
fun logOpenAdmin()
} }
...@@ -64,4 +64,10 @@ class AnalyticsManager @Inject constructor( ...@@ -64,4 +64,10 @@ class AnalyticsManager @Inject constructor(
analytics.forEach { it.logServerSwitch(serverUrl, accounts.size) } analytics.forEach { it.logServerSwitch(serverUrl, accounts.size) }
} }
} }
fun logOpenAdmin() {
if (analyticsTrackingInteractor.get()) {
analytics.forEach { it.logOpenAdmin() }
}
}
} }
...@@ -66,6 +66,7 @@ class MembersFragment : Fragment(), MembersView { ...@@ -66,6 +66,7 @@ class MembersFragment : Fragment(), MembersView {
override fun onViewCreated(view: View, savedInstanceState: Bundle?) { override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
super.onViewCreated(view, savedInstanceState) super.onViewCreated(view, savedInstanceState)
setupToolbar()
setupRecyclerView() setupRecyclerView()
presenter.loadChatRoomsMembers(chatRoomId) presenter.loadChatRoomsMembers(chatRoomId)
...@@ -125,9 +126,13 @@ class MembersFragment : Fragment(), MembersView { ...@@ -125,9 +126,13 @@ class MembersFragment : Fragment(), MembersView {
} }
} }
private fun setupToolbar(totalMembers: Long) { private fun setupToolbar(totalMembers: Long? = null) {
(activity as ChatRoomActivity).let { (activity as ChatRoomActivity).let {
it.showToolbarTitle(getString(R.string.title_members, totalMembers)) if (totalMembers != null) {
it.showToolbarTitle(getString(R.string.title_counted_members, totalMembers))
} else {
it.showToolbarTitle(getString(R.string.title_members))
}
it.hideToolbarChatRoomIcon() it.hideToolbarChatRoomIcon()
} }
} }
......
...@@ -10,9 +10,11 @@ import android.webkit.WebViewClient ...@@ -10,9 +10,11 @@ import android.webkit.WebViewClient
import androidx.appcompat.app.AppCompatActivity import androidx.appcompat.app.AppCompatActivity
import androidx.fragment.app.Fragment import androidx.fragment.app.Fragment
import chat.rocket.android.R import chat.rocket.android.R
import chat.rocket.android.analytics.AnalyticsManager
import chat.rocket.android.util.extensions.inflate import chat.rocket.android.util.extensions.inflate
import chat.rocket.android.util.extensions.ui import chat.rocket.android.util.extensions.ui
import kotlinx.android.synthetic.main.fragment_admin_panel_web_view.* import kotlinx.android.synthetic.main.fragment_admin_panel_web_view.*
import javax.inject.Inject
private const val BUNDLE_WEB_PAGE_URL = "web_page_url" private const val BUNDLE_WEB_PAGE_URL = "web_page_url"
private const val BUNDLE_USER_TOKEN = "user_token" private const val BUNDLE_USER_TOKEN = "user_token"
...@@ -20,6 +22,8 @@ private const val BUNDLE_USER_TOKEN = "user_token" ...@@ -20,6 +22,8 @@ private const val BUNDLE_USER_TOKEN = "user_token"
class AdminPanelWebViewFragment : Fragment() { class AdminPanelWebViewFragment : Fragment() {
private lateinit var webPageUrl: String private lateinit var webPageUrl: String
private lateinit var userToken: String private lateinit var userToken: String
@Inject
lateinit var analyticsManager: AnalyticsManager
override fun onCreate(savedInstanceState: Bundle?) { override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState) super.onCreate(savedInstanceState)
...@@ -42,6 +46,8 @@ class AdminPanelWebViewFragment : Fragment() { ...@@ -42,6 +46,8 @@ class AdminPanelWebViewFragment : Fragment() {
super.onViewCreated(view, savedInstanceState) super.onViewCreated(view, savedInstanceState)
setupToolbar() setupToolbar()
setupWebView() setupWebView()
analyticsManager.logOpenAdmin()
} }
private fun setupToolbar() { private fun setupToolbar() {
......
...@@ -10,7 +10,8 @@ ...@@ -10,7 +10,8 @@
<string name="title_legal_terms">Legal Terms</string> <string name="title_legal_terms">Legal Terms</string>
<string name="title_chats">Chats</string> <string name="title_chats">Chats</string>
<string name="title_profile">Profil</string> <string name="title_profile">Profil</string>
<string name="title_members">Benutzer (%d)</string> <string name="title_members">Benutzer</string>
<string name="title_counted_members">Benutzer (%d)</string>
<string name="title_settings">Einstellungen</string> <string name="title_settings">Einstellungen</string>
<string name="title_preferences">Preferences</string> <!-- TODO Add translation --> <string name="title_preferences">Preferences</string> <!-- TODO Add translation -->
<string name="title_change_password">Ändere Passwort</string> <string name="title_change_password">Ändere Passwort</string>
......
...@@ -9,7 +9,8 @@ ...@@ -9,7 +9,8 @@
<string name="title_legal_terms">Términos legales</string> <string name="title_legal_terms">Términos legales</string>
<string name="title_chats">Chats</string> <string name="title_chats">Chats</string>
<string name="title_profile">Perfil</string> <string name="title_profile">Perfil</string>
<string name="title_members">Miembros (%d)</string> <string name="title_members">Miembros</string>
<string name="title_counted_members">Miembros (%d)</string>
<string name="title_settings">Configuraciones</string> <string name="title_settings">Configuraciones</string>
<string name="title_preferences">Preferences</string> <!-- TODO Add translation --> <string name="title_preferences">Preferences</string> <!-- TODO Add translation -->
<string name="title_change_password">Cambia la contraseña</string> <string name="title_change_password">Cambia la contraseña</string>
......
...@@ -10,7 +10,8 @@ ...@@ -10,7 +10,8 @@
<string name="title_legal_terms">Termes juridiques</string> <string name="title_legal_terms">Termes juridiques</string>
<string name="title_chats">Chats</string> <string name="title_chats">Chats</string>
<string name="title_profile">Profil</string> <string name="title_profile">Profil</string>
<string name="title_members">Membres (%d)</string> <string name="title_members">Membres</string>
<string name="title_counted_members">Membres (%d)</string>
<string name="title_settings">Paramètres</string> <string name="title_settings">Paramètres</string>
<string name="title_preferences">Préférences</string> <string name="title_preferences">Préférences</string>
<string name="title_change_password">Changer le mot de passe</string> <string name="title_change_password">Changer le mot de passe</string>
......
...@@ -10,7 +10,8 @@ ...@@ -10,7 +10,8 @@
<string name="title_legal_terms">कानूनी शर्तें</string> <string name="title_legal_terms">कानूनी शर्तें</string>
<string name="title_chats">चैट</string> <string name="title_chats">चैट</string>
<string name="title_profile">प्रोफाइल</string> <string name="title_profile">प्रोफाइल</string>
<string name="title_members">सदस्य (%d)</string> <string name="title_members">सदस्य</string>
<string name="title_counted_members">सदस्य (%d)</string>
<string name="title_settings">सेटिंग्स</string> <string name="title_settings">सेटिंग्स</string>
<string name="title_preferences">प्राथमिकताएँ</string> <string name="title_preferences">प्राथमिकताएँ</string>
<string name="title_change_password">पासवर्ड बदलें</string> <string name="title_change_password">पासवर्ड बदलें</string>
......
...@@ -12,7 +12,8 @@ ...@@ -12,7 +12,8 @@
<string name="title_legal_terms">Legal Terms</string> <string name="title_legal_terms">Legal Terms</string>
<string name="title_chats">チャット</string> <string name="title_chats">チャット</string>
<string name="title_profile">プロフィール</string> <string name="title_profile">プロフィール</string>
<string name="title_members">メンバー (%d)</string> <string name="title_members">メンバー</string>
<string name="title_counted_members">メンバー (%d)</string>
<string name="title_settings">設定</string> <string name="title_settings">設定</string>
<string name="title_preferences">Preferences</string> <!-- TODO Add translation --> <string name="title_preferences">Preferences</string> <!-- TODO Add translation -->
<string name="title_change_password">Change Password</string> <!-- TODO Add translation --> <string name="title_change_password">Change Password</string> <!-- TODO Add translation -->
......
...@@ -10,7 +10,8 @@ ...@@ -10,7 +10,8 @@
<string name="title_legal_terms">Termos Legais</string> <string name="title_legal_terms">Termos Legais</string>
<string name="title_chats">Chats</string> <string name="title_chats">Chats</string>
<string name="title_profile">Perfil</string> <string name="title_profile">Perfil</string>
<string name="title_members">Membros (%d)</string> <string name="title_members">Membros</string>
<string name="title_counted_members">Membros (%d)</string>
<string name="title_settings">Configurações</string> <string name="title_settings">Configurações</string>
<string name="title_preferences">Preferencias</string> <string name="title_preferences">Preferencias</string>
<string name="title_change_password">Alterar senha</string> <string name="title_change_password">Alterar senha</string>
......
...@@ -10,7 +10,8 @@ ...@@ -10,7 +10,8 @@
<string name="title_legal_terms">Юридические условия</string> <string name="title_legal_terms">Юридические условия</string>
<string name="title_chats">Чаты</string> <string name="title_chats">Чаты</string>
<string name="title_profile">Профиль</string> <string name="title_profile">Профиль</string>
<string name="title_members">Пользователи (%d)</string> <string name="title_members">Пользователи</string>
<string name="title_counted_members">Пользователи (%d)</string>
<string name="title_settings">Настройки</string> <string name="title_settings">Настройки</string>
<string name="title_preferences">Персональные</string> <string name="title_preferences">Персональные</string>
<string name="title_change_password">Изменить пароль</string> <string name="title_change_password">Изменить пароль</string>
......
...@@ -10,7 +10,8 @@ ...@@ -10,7 +10,8 @@
<string name="title_legal_terms">Yasal Şartlar</string> <string name="title_legal_terms">Yasal Şartlar</string>
<string name="title_chats">Sohbetler</string> <string name="title_chats">Sohbetler</string>
<string name="title_profile">Profil</string> <string name="title_profile">Profil</string>
<string name="title_members">Üyeler (%d)</string> <string name="title_members">Üyeler</string>
<string name="title_counted_members">Üyeler (%d)</string>
<string name="title_settings">Ayarlar</string> <string name="title_settings">Ayarlar</string>
<string name="title_preferences">Tercihler</string> <string name="title_preferences">Tercihler</string>
<string name="title_change_password">Şifre Değişikliği</string> <string name="title_change_password">Şifre Değişikliği</string>
......
...@@ -10,7 +10,8 @@ ...@@ -10,7 +10,8 @@
<string name="title_legal_terms">Юридичні умови</string> <string name="title_legal_terms">Юридичні умови</string>
<string name="title_chats">Чати</string> <string name="title_chats">Чати</string>
<string name="title_profile">Профіль</string> <string name="title_profile">Профіль</string>
<string name="title_members">Користувачі (%d)</string> <string name="title_members">Користувачі</string>
<string name="title_counted_members">Користувачі (%d)</string>
<string name="title_settings">Налаштування</string> <string name="title_settings">Налаштування</string>
<string name="title_preferences">Персональні</string> <string name="title_preferences">Персональні</string>
<string name="title_change_password">Змінити пароль</string> <string name="title_change_password">Змінити пароль</string>
......
...@@ -22,7 +22,8 @@ https://github.com/RocketChat/java-code-styles/blob/master/CODING_STYLE.md#strin ...@@ -22,7 +22,8 @@ https://github.com/RocketChat/java-code-styles/blob/master/CODING_STYLE.md#strin
<string name="title_legal_terms">Legal Terms</string> <string name="title_legal_terms">Legal Terms</string>
<string name="title_chats">Chats</string> <string name="title_chats">Chats</string>
<string name="title_profile">Profile</string> <string name="title_profile">Profile</string>
<string name="title_members">Members (%d)</string> <string name="title_members">Members</string>
<string name="title_counted_members">Members (%d)</string>
<string name="title_settings">Settings</string> <string name="title_settings">Settings</string>
<string name="title_preferences">Preferences</string> <string name="title_preferences">Preferences</string>
<string name="title_change_password">Change Password</string> <string name="title_change_password">Change Password</string>
......
...@@ -65,4 +65,6 @@ class AnswersAnalytics : Analytics { ...@@ -65,4 +65,6 @@ class AnswersAnalytics : Analytics {
.putCustomAttribute("server_url", serverUrl) .putCustomAttribute("server_url", serverUrl)
.putCustomAttribute("server_count", serverCount) .putCustomAttribute("server_count", serverCount)
) )
override fun logOpenAdmin() = Answers.getInstance().logCustom(CustomEvent("open_admin"))
} }
...@@ -58,4 +58,6 @@ class GoogleAnalyticsForFirebase @Inject constructor(val context: Context) : ...@@ -58,4 +58,6 @@ class GoogleAnalyticsForFirebase @Inject constructor(val context: Context) :
putInt("server_count", serverCount) putInt("server_count", serverCount)
}) })
} }
override fun logOpenAdmin() = firebaseAnalytics.logEvent("open_admin", null)
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment