Fix PMD stuff

app/src/main/java/chat/rocket/android/RocketChatCache.java

@@ -23,14 +23,14 @@ public class RocketChatCache {
 
   public static String getPushId(Context context) {
     SharedPreferences preferences = get(context);
-    String id = null;
+    String pushId = null;
     if (!preferences.contains(PUSH_ID)) {
       // generates one and save
-      id = UUID.randomUUID().toString();
+      pushId = UUID.randomUUID().toString();
       SharedPreferences.Editor editor = preferences.edit();
-      editor.putString(PUSH_ID, id);
+      editor.putString(PUSH_ID, pushId);
       editor.apply();
     }
-    return preferences.getString(PUSH_ID, id);
+    return preferences.getString(PUSH_ID, pushId);
   }
 }

app/src/main/java/chat/rocket/android/model/ServerConfig.java

@@ -14,6 +14,7 @@ import hugo.weaving.DebugLog;
  */
 public class ServerConfig extends RealmObject {
 
+  @SuppressWarnings({"PMD.ShortVariable"})
   public static final String ID = "serverConfigId";
   public static final String HOSTNAME = "hostname";
   public static final String STATE = "state";

app/src/main/java/chat/rocket/android/model/ddp/Message.java

@@ -21,6 +21,8 @@ public class Message extends RealmObject {
   public static final String ROOM_ID = "rid";
   public static final String SYNC_STATE = "syncstate";
   public static final String TIMESTAMP = "ts";
+
+  @SuppressWarnings({"PMD.AvoidFieldNameMatchingTypeName"})
   public static final String MESSAGE = "msg";
   public static final String USER = "u";
   public static final String GROUPABLE = "groupable";

app/src/main/java/chat/rocket/android/model/ddp/PublicSettingsConstants.java

 package chat.rocket.android.model.ddp;
 
+@SuppressWarnings({"PMD.ShortClassName"})
 public interface PublicSettingsConstants {
   interface Message {
     String API_EMBED = "API_Embed";
@@ -97,8 +98,7 @@ public interface PublicSettingsConstants {
     String PASSWORD_RESET = "Accounts_PasswordReset";
     String REGISTRATION_FORM = "Accounts_RegistrationForm";
     String REGISTRATON_FORM_LINK_REPLACEMENT_TEXT = "Accounts_RegistrationForm_LinkReplacementText";
-    String
-        REGISTRATION_AUTH_SERVICES_ENABLED =
+    String REGISTRATION_AUTH_SERVICES_ENABLED =
         "Accounts_Registration_AuthenticationServices_Enabled";
     String REQUIRE_NAME_FOR_SIGN_UP = "Accounts_RequireNameForSignUp";
     String REQUIRE_PASSWORD_CONFIRMATION = "Accounts_RequirePasswordConfirmation";

app/src/main/java/chat/rocket/android/model/internal/FileUploading.java

@@ -8,6 +8,7 @@ import io.realm.annotations.PrimaryKey;
  */
 public class FileUploading extends RealmObject {
 
+  @SuppressWarnings({"PMD.ShortVariable"})
   public static final String ID = "uplId";
   public static final String SYNC_STATE = "syncstate";
   public static final String STORAGE_TYPE = "storageType";

app/src/main/java/chat/rocket/android/model/internal/GetUsersOfRoomsProcedure.java

@@ -8,6 +8,7 @@ import io.realm.annotations.PrimaryKey;
  */
 public class GetUsersOfRoomsProcedure extends RealmObject {
 
+  @SuppressWarnings({"PMD.ShortVariable"})
   public static final String ID = "roomId";
   public static final String SYNC_STATE = "syncstate";
   public static final String SHOW_ALL = "showAll";

app/src/main/java/chat/rocket/android/model/internal/LoadMessageProcedure.java

@@ -8,6 +8,7 @@ import io.realm.annotations.PrimaryKey;
  */
 public class LoadMessageProcedure extends RealmObject {
 
+  @SuppressWarnings({"PMD.ShortVariable"})
   public static final String ID = "roomId";
   public static final String SYNC_STATE = "syncstate";
   public static final String RESET = "reset";

app/src/main/java/chat/rocket/android/model/internal/MethodCall.java

@@ -20,6 +20,7 @@ import chat.rocket.android.service.RocketChatService;
 
 public class MethodCall extends RealmObject {
 
+  @SuppressWarnings({"PMD.ShortVariable"})
   public static final String ID = "methodCallId";
   public static final String SYNC_STATE = "syncstate";
   public static final String NAME = "name";

app/src/main/java/chat/rocket/android/model/internal/NotificationItem.java

@@ -8,6 +8,7 @@ import io.realm.annotations.PrimaryKey;
  */
 public class NotificationItem extends RealmObject {
 
+  @SuppressWarnings({"PMD.ShortVariable"})
   public static final String ID = "roomId";
   public static final String TITLE = "title";
   public static final String DESCRIPTION = "description";

app/src/main/java/chat/rocket/android/model/internal/Session.java

@@ -16,6 +16,7 @@ import hugo.weaving.DebugLog;
  */
 public class Session extends RealmObject {
 
+  @SuppressWarnings({"PMD.ShortVariable"})
   public static final String ID = "sessionId";
   public static final String TOKEN = "token";
   public static final String TOKEN_VERIFIED = "tokenVerified";