Merge pull request #827 from RocketChat/feature/member-details

[NEW] Shows chat room member list.

app/src/main/java/chat/rocket/android/chatroom/di/ChatRoomFragmentModule.kt

 package chat.rocket.android.chatroom.di
 
 import android.arch.lifecycle.LifecycleOwner
+import chat.rocket.android.chatroom.presentation.ChatRoomNavigator
 import chat.rocket.android.chatroom.presentation.ChatRoomView
+import chat.rocket.android.chatroom.ui.ChatRoomActivity
 import chat.rocket.android.chatroom.ui.ChatRoomFragment
 import chat.rocket.android.core.lifecycle.CancelStrategy
 import chat.rocket.android.dagger.scope.PerFragment
@@ -13,6 +15,9 @@ import kotlinx.coroutines.experimental.Job
 @PerFragment
 class ChatRoomFragmentModule {
 
+    @Provides
+    fun provideChatRoomNavigator(activity: ChatRoomActivity) = ChatRoomNavigator(activity)
+
     @Provides
     fun chatRoomView(frag: ChatRoomFragment): ChatRoomView {
         return frag

app/src/main/java/chat/rocket/android/chatroom/presentation/ChatRoomNavigator.kt

+package chat.rocket.android.chatroom.presentation
+
+import chat.rocket.android.R
+import chat.rocket.android.chatroom.ui.ChatRoomActivity
+import chat.rocket.android.members.ui.newInstance
+import chat.rocket.android.util.extensions.addFragmentBackStack
+
+class ChatRoomNavigator(internal val activity: ChatRoomActivity) {
+
+    fun toMembersList(chatRoomId: String, chatRoomType: String) {
+        activity.addFragmentBackStack("MembersFragment", R.id.fragment_container) {
+            newInstance(chatRoomId, chatRoomType)
+        }
+    }
+}
\ No newline at end of file

app/src/main/java/chat/rocket/android/chatroom/presentation/ChatRoomPresenter.kt

@@ -27,6 +27,7 @@ import timber.log.Timber
 import javax.inject.Inject
 
 class ChatRoomPresenter @Inject constructor(private val view: ChatRoomView,
+                                            private val navigator: ChatRoomNavigator,
                                             private val strategy: CancelStrategy,
                                             getSettingsInteractor: GetSettingsInteractor,
                                             private val serverInteractor: GetCurrentServerInteractor,
@@ -339,6 +340,8 @@ class ChatRoomPresenter @Inject constructor(private val view: ChatRoomView,
         }
     }
 
+    fun toMembersList(chatRoomId: String, chatRoomType: String) = navigator.toMembersList(chatRoomId, chatRoomType)
+
     private fun updateMessage(streamedMessage: Message) {
         launchUI(strategy) {
             val viewModelStreamedMessage = mapper.map(streamedMessage)

app/src/main/java/chat/rocket/android/chatroom/ui/ChatRoomActivity.kt

@@ -64,7 +64,7 @@ class ChatRoomActivity : AppCompatActivity(), HasSupportFragmentInjector {
         isChatRoomReadOnly = intent.getBooleanExtra(INTENT_IS_CHAT_ROOM_READ_ONLY, true)
         requireNotNull(chatRoomType) { "no is_chat_room_read_only provided in Intent extras" }
 
-        setupToolbar(chatRoomName)
+        setupToolbar()
 
         addFragment("ChatRoomFragment", R.id.fragment_container) {
             newInstance(chatRoomId, chatRoomName, chatRoomType, isChatRoomReadOnly)
@@ -79,15 +79,18 @@ class ChatRoomActivity : AppCompatActivity(), HasSupportFragmentInjector {
         return fragmentDispatchingAndroidInjector
     }
 
-    private fun setupToolbar(chatRoomName: String) {
+    private fun setupToolbar() {
         setSupportActionBar(toolbar)
         supportActionBar?.setDisplayShowTitleEnabled(false)
-        text_room_name.textContent = chatRoomName
         toolbar.setNavigationOnClickListener {
             finishActivity()
         }
     }
 
+    fun setupToolbarTitle(toolbarTitle: String) {
+        text_room_name.textContent = toolbarTitle
+    }
+
     private fun finishActivity() {
         super.onBackPressed()
         overridePendingTransition(R.anim.close_enter, R.anim.close_exit)

app/src/main/java/chat/rocket/android/chatroom/ui/ChatRoomFragment.kt

@@ -99,6 +99,8 @@ class ChatRoomFragment : Fragment(), ChatRoomView, EmojiKeyboardPopup.Listener {
 
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
+        setupToolbar(chatRoomName)
+
         presenter.loadMessages(chatRoomId, chatRoomType)
 
         setupRecyclerView()
@@ -134,6 +136,9 @@ class ChatRoomFragment : Fragment(), ChatRoomView, EmojiKeyboardPopup.Listener {
 
     override fun onOptionsItemSelected(item: MenuItem): Boolean {
         when (item.itemId) {
+            R.id.action_members_list -> {
+                presenter.toMembersList(chatRoomId, chatRoomType)
+            }
             R.id.action_pinned_messages -> {
                 val intent = Intent(activity, PinnedMessagesActivity::class.java).apply {
                     putExtra(BUNDLE_CHAT_ROOM_ID, chatRoomId)
@@ -471,4 +476,8 @@ class ChatRoomFragment : Fragment(), ChatRoomView, EmojiKeyboardPopup.Listener {
 
         view_dim.setVisible(false)
     }
+
+    private fun setupToolbar(toolbarTitle: String) {
+        (activity as ChatRoomActivity).setupToolbarTitle(toolbarTitle)
+    }
 }
\ No newline at end of file

app/src/main/java/chat/rocket/android/dagger/module/ActivityBuilder.kt

@@ -16,6 +16,7 @@ import chat.rocket.android.dagger.scope.PerActivity
 import chat.rocket.android.main.di.MainActivityProvider
 import chat.rocket.android.main.di.MainModule
 import chat.rocket.android.main.ui.MainActivity
+import chat.rocket.android.members.di.MembersFragmentProvider
 import chat.rocket.android.profile.di.ProfileFragmentProvider
 import dagger.Module
 import dagger.android.ContributesAndroidInjector
@@ -42,7 +43,7 @@ abstract class ActivityBuilder {
     abstract fun bindMainActivity(): MainActivity
 
     @PerActivity
-    @ContributesAndroidInjector(modules = [ChatRoomFragmentProvider::class])
+    @ContributesAndroidInjector(modules = [ChatRoomFragmentProvider::class, MembersFragmentProvider::class])
     abstract fun bindChatRoomActivity(): ChatRoomActivity
 
     @PerActivity

app/src/main/java/chat/rocket/android/members/adapter/MembersAdapter.kt

+package chat.rocket.android.members.adapter
+
+import android.support.v7.widget.RecyclerView
+import android.view.View
+import android.view.ViewGroup
+import chat.rocket.android.R
+import chat.rocket.android.members.viewmodel.MemberViewModel
+import chat.rocket.android.util.extensions.content
+import chat.rocket.android.util.extensions.inflate
+import kotlinx.android.synthetic.main.avatar.view.*
+import kotlinx.android.synthetic.main.item_member.view.*
+
+class MembersAdapter(private var dataSet: List<MemberViewModel>) : RecyclerView.Adapter<MembersAdapter.ViewHolder>() {
+
+    override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): MembersAdapter.ViewHolder = ViewHolder(parent.inflate(R.layout.item_member))
+
+    override fun onBindViewHolder(holder: MembersAdapter.ViewHolder, position: Int) = holder.bind(dataSet[position])
+
+    override fun getItemCount(): Int = dataSet.size
+
+    override fun getItemViewType(position: Int): Int = position
+
+    fun appendData(dataSet: List<MemberViewModel>) {
+        val previousDataSetSize = this.dataSet.size
+        this.dataSet += dataSet
+        notifyItemRangeInserted(previousDataSetSize, dataSet.size)
+    }
+
+    class ViewHolder(itemView: View) : RecyclerView.ViewHolder(itemView) {
+
+        fun bind(memberViewModel: MemberViewModel) = with(itemView) {
+            image_avatar.setImageURI(memberViewModel.avatarUri)
+            text_member.content = memberViewModel.memberName
+        }
+    }
+}
\ No newline at end of file

app/src/main/java/chat/rocket/android/members/di/MembersFragmentModule.kt

+package chat.rocket.android.members.di
+
+import android.arch.lifecycle.LifecycleOwner
+import chat.rocket.android.core.lifecycle.CancelStrategy
+import chat.rocket.android.dagger.scope.PerFragment
+import chat.rocket.android.members.presentation.MembersView
+import chat.rocket.android.members.ui.MembersFragment
+import dagger.Module
+import dagger.Provides
+import kotlinx.coroutines.experimental.Job
+
+@Module
+@PerFragment
+class MembersFragmentModule {
+
+    @Provides
+    fun membersView(frag: MembersFragment): MembersView {
+        return frag
+    }
+
+    @Provides
+    fun provideLifecycleOwner(frag: MembersFragment): LifecycleOwner {
+        return frag
+    }
+
+    @Provides
+    fun provideCancelStrategy(owner: LifecycleOwner, jobs: Job): CancelStrategy {
+        return CancelStrategy(owner, jobs)
+    }
+}
\ No newline at end of file

app/src/main/java/chat/rocket/android/members/di/MembersFragmentProvider.kt

+package chat.rocket.android.members.di
+
+import chat.rocket.android.members.ui.MembersFragment
+import dagger.Module
+import dagger.android.ContributesAndroidInjector
+
+@Module
+abstract class MembersFragmentProvider {
+
+    @ContributesAndroidInjector(modules = [MembersFragmentModule::class])
+    abstract fun provideMembersFragment(): MembersFragment
+}
\ No newline at end of file

app/src/main/java/chat/rocket/android/members/presentation/MembersPresenter.kt

+package chat.rocket.android.members.presentation
+
+import chat.rocket.android.core.lifecycle.CancelStrategy
+import chat.rocket.android.members.viewmodel.MemberViewModelMapper
+import chat.rocket.android.server.domain.GetCurrentServerInteractor
+import chat.rocket.android.server.infraestructure.RocketChatClientFactory
+import chat.rocket.android.util.extensions.launchUI
+import chat.rocket.common.RocketChatException
+import chat.rocket.common.model.roomTypeOf
+import chat.rocket.common.util.ifNull
+import chat.rocket.core.RocketChatClient
+import chat.rocket.core.internal.rest.getMembers
+import javax.inject.Inject
+
+class MembersPresenter @Inject constructor(private val view: MembersView,
+                                           private val strategy: CancelStrategy,
+                                           private val serverInteractor: GetCurrentServerInteractor,
+                                           factory: RocketChatClientFactory,
+                                           private val mapper: MemberViewModelMapper) {
+    private val client: RocketChatClient = factory.create(serverInteractor.get()!!)
+
+    fun loadChatRoomsMembers(chatRoomId: String, chatRoomType: String, offset: Long = 0) {
+        launchUI(strategy) {
+            try {
+                view.showLoading()
+
+                val members = client.getMembers(chatRoomId, roomTypeOf(chatRoomType), offset, 30)
+                val memberViewModels = mapper.mapToViewModelList(members.result)
+                view.showMembers(memberViewModels, members.total)
+            } catch (ex: RocketChatException) {
+                ex.message?.let {
+                    view.showMessage(it)
+                }.ifNull {
+                    view.showGenericErrorMessage()
+                }
+            } finally {
+                view.hideLoading()
+            }
+        }
+    }
+}
\ No newline at end of file

app/src/main/java/chat/rocket/android/members/presentation/MembersView.kt

+package chat.rocket.android.members.presentation
+
+import chat.rocket.android.core.behaviours.LoadingView
+import chat.rocket.android.core.behaviours.MessageView
+import chat.rocket.android.members.viewmodel.MemberViewModel
+
+interface MembersView: LoadingView, MessageView {
+
+    /**
+     * Shows a list of members of a room.
+     *
+     * @param dataSet The data set to show.
+     * @param total The total number of members.
+     */
+    fun showMembers(dataSet: List<MemberViewModel>, total: Long)
+}
\ No newline at end of file

app/src/main/java/chat/rocket/android/members/ui/MembersFragment.kt

+package chat.rocket.android.members.ui
+
+import android.os.Bundle
+import android.support.v4.app.Fragment
+import android.support.v7.app.AppCompatActivity
+import android.support.v7.widget.LinearLayoutManager
+import android.support.v7.widget.RecyclerView
+import android.view.LayoutInflater
+import android.view.View
+import android.view.ViewGroup
+import chat.rocket.android.R
+import chat.rocket.android.chatroom.ui.ChatRoomActivity
+import chat.rocket.android.helper.EndlessRecyclerViewScrollListener
+import chat.rocket.android.members.adapter.MembersAdapter
+import chat.rocket.android.members.presentation.MembersPresenter
+import chat.rocket.android.members.presentation.MembersView
+import chat.rocket.android.members.viewmodel.MemberViewModel
+import chat.rocket.android.util.extensions.inflate
+import chat.rocket.android.util.extensions.setVisible
+import chat.rocket.android.util.extensions.showToast
+import chat.rocket.android.widget.DividerItemDecoration
+import chat.rocket.common.model.User
+import dagger.android.support.AndroidSupportInjection
+import kotlinx.android.synthetic.main.fragment_members.*
+import javax.inject.Inject
+
+fun newInstance(chatRoomId: String, chatRoomType: String): Fragment {
+    return MembersFragment().apply {
+        arguments = Bundle(1).apply {
+            putString(BUNDLE_CHAT_ROOM_ID, chatRoomId)
+            putString(BUNDLE_CHAT_ROOM_TYPE, chatRoomType)
+        }
+    }
+}
+
+private const val BUNDLE_CHAT_ROOM_ID = "chat_room_id"
+private const val BUNDLE_CHAT_ROOM_TYPE = "chat_room_type"
+
+class MembersFragment : Fragment(), MembersView {
+    @Inject lateinit var presenter: MembersPresenter
+    private lateinit var adapter: MembersAdapter
+
+    private lateinit var chatRoomId: String
+    private lateinit var chatRoomType: String
+
+    override fun onCreate(savedInstanceState: Bundle?) {
+        super.onCreate(savedInstanceState)
+        AndroidSupportInjection.inject(this)
+
+        val bundle = arguments
+        if (bundle != null) {
+            chatRoomId = bundle.getString(BUNDLE_CHAT_ROOM_ID)
+            chatRoomType = bundle.getString(BUNDLE_CHAT_ROOM_TYPE)
+        } else {
+            requireNotNull(bundle) { "no arguments supplied when the fragment was instantiated" }
+        }
+    }
+
+    override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View? = container?.inflate(R.layout.fragment_members)
+
+    override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
+        super.onViewCreated(view, savedInstanceState)
+        (activity as AppCompatActivity).supportActionBar?.title = ""
+        presenter.loadChatRoomsMembers(chatRoomId, chatRoomType)
+    }
+
+    override fun showMembers(dataSet: List<MemberViewModel>, total: Long) {
+        activity?.apply {
+            setupToolbar(total)
+            if (recycler_view.adapter == null) {
+                adapter = MembersAdapter(dataSet)
+                recycler_view.adapter = adapter
+                val linearLayoutManager = LinearLayoutManager(context, LinearLayoutManager.VERTICAL, false)
+                recycler_view.layoutManager = linearLayoutManager
+                recycler_view.addItemDecoration(DividerItemDecoration(this))
+                if (dataSet.size >= 30) {
+                    recycler_view.addOnScrollListener(object : EndlessRecyclerViewScrollListener(linearLayoutManager) {
+                        override fun onLoadMore(page: Int, totalItemsCount: Int, recyclerView: RecyclerView?) {
+                            presenter.loadChatRoomsMembers(chatRoomId, chatRoomType, page * 30L)
+                        }
+                    })
+                }
+            } else {
+                adapter.appendData(dataSet)
+            }
+        }
+    }
+
+    override fun showLoading() = view_loading.setVisible(true)
+
+    override fun hideLoading() = view_loading.setVisible(false)
+
+    override fun showMessage(resId: Int) = showToast(resId)
+
+    override fun showMessage(message: String) = showToast(message)
+
+    override fun showGenericErrorMessage() = showMessage(getString(R.string.msg_generic_error))
+
+    private fun setupToolbar(totalMembers: Long) {
+        (activity as ChatRoomActivity).setupToolbarTitle(getString(R.string.title_members, totalMembers))
+    }
+}
\ No newline at end of file

app/src/main/java/chat/rocket/android/members/viewmodel/MemberViewModel.kt

+package chat.rocket.android.members.viewmodel
+
+import chat.rocket.android.helper.UrlHelper
+import chat.rocket.android.server.domain.useRealName
+import chat.rocket.common.model.User
+import chat.rocket.core.model.Value
+
+class MemberViewModel(private val member: User, private val settings: Map<String, Value<Any>>, private val baseUrl: String?) {
+    val avatarUri: String?
+    val memberName: CharSequence
+
+    init {
+        avatarUri = getUserAvatar()
+        memberName = getUserName()
+    }
+
+    private fun getUserAvatar(): String? {
+        val username = member.username ?: "?"
+        return baseUrl?.let {
+            UrlHelper.getAvatarUrl(baseUrl, username)
+        }
+    }
+
+    private fun getUserName(): CharSequence {
+        val username = member.username
+        val realName = member.name
+        val senderName = if (settings.useRealName()) realName else username
+        return senderName ?: username.toString()
+    }
+}
\ No newline at end of file

app/src/main/java/chat/rocket/android/members/viewmodel/MemberViewModelMapper.kt

+package chat.rocket.android.members.viewmodel
+
+import chat.rocket.android.server.domain.GetCurrentServerInteractor
+import chat.rocket.android.server.domain.GetSettingsInteractor
+import chat.rocket.android.server.domain.baseUrl
+import chat.rocket.common.model.User
+import chat.rocket.core.model.Value
+import javax.inject.Inject
+
+class MemberViewModelMapper @Inject constructor(serverInteractor: GetCurrentServerInteractor, getSettingsInteractor: GetSettingsInteractor) {
+    private var settings: Map<String, Value<Any>> = getSettingsInteractor.get(serverInteractor.get()!!)!!
+    private val baseUrl = settings.baseUrl()
+
+    fun mapToViewModelList(memberList: List<User>): List<MemberViewModel> {
+        return memberList.map { MemberViewModel(it, settings, baseUrl) }
+    }
+}
\ No newline at end of file

app/src/main/res/layout/fragment_members.xml

+<?xml version="1.0" encoding="utf-8"?>
+<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:app="http://schemas.android.com/apk/res-auto"
+    xmlns:tools="http://schemas.android.com/tools"
+    android:layout_width="match_parent"
+    android:layout_height="match_parent"
+    tools:context=".members.ui.MembersFragment">
+
+    <android.support.v7.widget.RecyclerView
+        android:id="@+id/recycler_view"
+        android:layout_width="match_parent"
+        android:layout_height="match_parent" />
+
+    <com.wang.avi.AVLoadingIndicatorView
+        android:id="@+id/view_loading"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:layout_centerInParent="true"
+        app:indicatorColor="@color/black"
+        app:indicatorName="BallPulseIndicator" />
+
+</RelativeLayout>
\ No newline at end of file

app/src/main/res/layout/item_member.xml

+<?xml version="1.0" encoding="utf-8"?>
+<android.support.constraint.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:app="http://schemas.android.com/apk/res-auto"
+    xmlns:tools="http://schemas.android.com/tools"
+    android:layout_width="match_parent"
+    android:layout_height="wrap_content"
+    android:layout_marginBottom="6dp"
+    android:layout_marginEnd="@dimen/screen_edge_left_and_right_margins"
+    android:layout_marginStart="@dimen/screen_edge_left_and_right_margins"
+    android:layout_marginTop="6dp">
+
+    <include
+        android:id="@+id/layout_avatar"
+        layout="@layout/avatar"
+        android:layout_width="40dp"
+        android:layout_height="40dp"
+        app:layout_constraintLeft_toLeftOf="parent"
+        app:layout_constraintTop_toTopOf="parent" />
+
+    <TextView
+        android:id="@+id/text_member"
+        style="@style/Sender.Name.TextView"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:layout_marginStart="16dp"
+        app:layout_constraintBottom_toBottomOf="@+id/layout_avatar"
+        app:layout_constraintLeft_toRightOf="@+id/layout_avatar"
+        app:layout_constraintTop_toTopOf="@+id/layout_avatar"
+        tools:text="Ronald Perkins" />
+
+</android.support.constraint.ConstraintLayout>
\ No newline at end of file

app/src/main/res/menu/chatroom_actions.xml

@@ -2,6 +2,11 @@
 <menu xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto">
 
+    <item
+        android:id="@+id/action_members_list"
+        android:title="@string/title_members_list"
+        app:showAsAction="never" />
+
     <item
         android:id="@+id/action_pinned_messages"
         android:title="@string/title_pinned_messages"

app/src/main/res/values-pt-rBR/strings.xml

@@ -7,6 +7,7 @@
     <string name="title_legal_terms">Termos Legais</string>
     <string name="title_chats">Chats</string>
     <string name="title_profile">Perfil</string>
+    <string name="title_members">Membros (%d)</string>
     <string name="title_update_profile">Editar perfil</string>
 
     <!-- Actions -->
@@ -78,6 +79,9 @@
     <string name="permission_deleting_not_allowed">Remoção não permitida</string>
     <string name="permission_pinning_not_allowed">Fixar não permitido</string>
 
+    <!-- Members List -->
+    <string name="title_members_list">Lista de Membros</string>
+
     <!-- Pinned Messages -->
     <string name="title_pinned_messages">Mensagens Pinadas</string>
 

app/src/main/res/values/strings.xml

@@ -8,6 +8,7 @@
     <string name="title_legal_terms">Legal Terms</string>
     <string name="title_chats">Chats</string>
     <string name="title_profile">Profile</string>
+    <string name="title_members">Members (%d)</string>
     <string name="title_update_profile">Update profile</string>
 
     <!-- Actions -->
@@ -80,6 +81,9 @@
     <string name="permission_deleting_not_allowed">Deleting is not allowed</string>
     <string name="permission_pinning_not_allowed">Pinning is not allowed</string>
 
+    <!-- Members List -->
+    <string name="title_members_list">Members List</string>
+
     <!-- Pinned Messages -->
     <string name="title_pinned_messages">Pinned Messages</string>