implements rxbinders in edit text textwatchers

app/src/main/java/chat/rocket/android/LaunchUtil.java

@@ -12,31 +12,31 @@ import chat.rocket.android.activity.MainActivity;
  */
 public class LaunchUtil {
 
-  /**
-   * launch MainActivity with proper flags.
-   */
-  public static void showMainActivity(Context context) {
-    Intent intent = new Intent(context, MainActivity.class);
-    intent.setFlags(Intent.FLAG_ACTIVITY_REORDER_TO_FRONT | Intent.FLAG_ACTIVITY_CLEAR_TOP | Intent.FLAG_ACTIVITY_SINGLE_TOP);
-    context.startActivity(intent);
-  }
+    /**
+     * launch MainActivity with proper flags.
+     */
+    public static void showMainActivity(Context context) {
+        Intent intent = new Intent(context, MainActivity.class);
+        intent.setFlags(Intent.FLAG_ACTIVITY_REORDER_TO_FRONT | Intent.FLAG_ACTIVITY_CLEAR_TOP | Intent.FLAG_ACTIVITY_SINGLE_TOP);
+        context.startActivity(intent);
+    }
 
-  /**
-   * launch AddServerActivity with proper flags.
-   */
-  public static void showAddServerActivity(Context context) {
-    Intent intent = new Intent(context, AddServerActivity.class);
-    intent.setFlags(Intent.FLAG_ACTIVITY_REORDER_TO_FRONT | Intent.FLAG_ACTIVITY_CLEAR_TOP | Intent.FLAG_ACTIVITY_SINGLE_TOP);
-    context.startActivity(intent);
-  }
+    /**
+     * launch AddServerActivity with proper flags.
+     */
+    public static void showAddServerActivity(Context context) {
+        Intent intent = new Intent(context, AddServerActivity.class);
+        intent.setFlags(Intent.FLAG_ACTIVITY_REORDER_TO_FRONT | Intent.FLAG_ACTIVITY_CLEAR_TOP | Intent.FLAG_ACTIVITY_SINGLE_TOP);
+        context.startActivity(intent);
+    }
 
-  /**
-   * launch ServerConfigActivity with proper flags.
-   */
-  public static void showLoginActivity(Context context, String hostname) {
-    Intent intent = new Intent(context, LoginActivity.class);
-    intent.setFlags(Intent.FLAG_ACTIVITY_REORDER_TO_FRONT | Intent.FLAG_ACTIVITY_CLEAR_TOP | Intent.FLAG_ACTIVITY_SINGLE_TOP);
-    intent.putExtra(LoginActivity.KEY_HOSTNAME, hostname);
-    context.startActivity(intent);
-  }
+    /**
+     * launch ServerConfigActivity with proper flags.
+     */
+    public static void showLoginActivity(Context context, String hostname) {
+        Intent intent = new Intent(context, LoginActivity.class);
+        intent.setFlags(Intent.FLAG_ACTIVITY_REORDER_TO_FRONT | Intent.FLAG_ACTIVITY_CLEAR_TOP | Intent.FLAG_ACTIVITY_SINGLE_TOP);
+        intent.putExtra(LoginActivity.KEY_HOSTNAME, hostname);
+        context.startActivity(intent);
+    }
 }

app/src/main/java/chat/rocket/android/fragment/server_config/LoginFragment.kt

@@ -5,9 +5,7 @@ import android.support.constraint.ConstraintLayout
 import android.support.design.widget.Snackbar
 import android.support.design.widget.TextInputLayout
 import android.support.v4.app.Fragment
-import android.text.Editable
 import android.text.TextUtils
-import android.text.TextWatcher
 import android.view.View
 import android.widget.Button
 import android.widget.TextView
@@ -18,8 +16,10 @@ import chat.rocket.android.log.RCLog
 import chat.rocket.core.models.LoginServiceConfiguration
 import chat.rocket.persistence.realm.repositories.RealmLoginServiceConfigurationRepository
 import chat.rocket.persistence.realm.repositories.RealmPublicSettingRepository
+import com.jakewharton.rxbinding2.widget.RxTextView
 import java.util.*
 
+
 /**
  * Login screen.
  */
@@ -57,35 +57,8 @@ class LoginFragment : AbstractServerConfigFragment(), LoginContract.View {
         textInputUsername = rootView.findViewById(R.id.text_input_username)
         textInputPassword = rootView.findViewById(R.id.text_input_passwd)
 
-        //setting text change listeners to username and password edit texts
-        txtUsername.addTextChangedListener(object :TextWatcher
-        {
-            override fun afterTextChanged(p0: Editable?) {
-            }
+        setUpRxBinders()
 
-            override fun beforeTextChanged(p0: CharSequence?, p1: Int, p2: Int, p3: Int) {
-            }
-
-            override fun onTextChanged(p0: CharSequence?, p1: Int, p2: Int, p3: Int) {
-                if(!TextUtils.isEmpty(txtUsername.text.toString()) && textInputUsername.isErrorEnabled)
-                    textInputUsername.setErrorEnabled(false)
-            }
-        })
-
-        txtPasswd.addTextChangedListener(object :TextWatcher
-        {
-            override fun afterTextChanged(p0: Editable?) {
-            }
-
-            override fun beforeTextChanged(p0: CharSequence?, p1: Int, p2: Int, p3: Int) {
-            }
-
-            override fun onTextChanged(p0: CharSequence?, p1: Int, p2: Int, p3: Int) {
-                if(!TextUtils.isEmpty(txtPasswd.text.toString()) && textInputPassword.isErrorEnabled)
-                    textInputPassword.setErrorEnabled(false)
-            }
-        })
-        
         waitingView = rootView.findViewById(R.id.waiting)
 
         btnEmail.setOnClickListener { _ -> presenter.login(txtUsername.text.toString(), txtPasswd.text.toString()) }
@@ -96,17 +69,30 @@ class LoginFragment : AbstractServerConfigFragment(), LoginContract.View {
         }
     }
 
+    fun setUpRxBinders() {
+        RxTextView.textChanges(txtUsername).subscribe { text ->
+            if (!TextUtils.isEmpty(text) && textInputUsername.isErrorEnabled)
+                textInputUsername.setErrorEnabled(false)
+        }
+
+        RxTextView.textChanges(txtPasswd).subscribe { text ->
+            if (!TextUtils.isEmpty(text) && textInputPassword.isErrorEnabled)
+                textInputPassword.setErrorEnabled(false)
+        }
+
+    }
+
     override fun showLoader() {
         container.visibility = View.GONE
         waitingView.visibility = View.VISIBLE
     }
 
-    override fun showErrorInUsernameEditText(){
+    override fun showErrorInUsernameEditText() {
         textInputUsername.setErrorEnabled(true);
         textInputUsername.setError("Enter a Username")
     }
 
-    override fun showErrorInPasswordEditText(){
+    override fun showErrorInPasswordEditText() {
         textInputPassword.setErrorEnabled(true);
         textInputPassword.setError("Enter a Password")
     }

app/src/main/java/chat/rocket/android/fragment/server_config/LoginPresenter.kt

@@ -32,7 +32,6 @@ class LoginPresenter(private val loginServiceConfigurationRepository: LoginServi
     }
 
 
-
     override fun goBack() {
         val context = RocketChatApplication.getInstance()
         val hostname = RocketChatCache.getSelectedServerHostname()
@@ -47,7 +46,7 @@ class LoginPresenter(private val loginServiceConfigurationRepository: LoginServi
     override fun login(username: String, password: String) {
 
         //set error to edit texts
-        if (TextUtils.isEmpty(username)&&TextUtils.isEmpty(password)) {
+        if (TextUtils.isEmpty(username) && TextUtils.isEmpty(password)) {
             view.showErrorInUsernameEditText()
             view.showErrorInPasswordEditText()
             return
@@ -56,7 +55,7 @@ class LoginPresenter(private val loginServiceConfigurationRepository: LoginServi
             view.showErrorInUsernameEditText()
             return
         }
-        if (TextUtils.isEmpty(password)){
+        if (TextUtils.isEmpty(password)) {
             view.showErrorInPasswordEditText()
             return
         }