fix login is called many times.

app/src/main/java/chat/rocket/android/fragment/oauth/GitHubOAuthFragment.java

@@ -55,7 +55,7 @@ public class GitHubOAuthFragment extends AbstractWebViewFragment {
     MeteorLoginServiceConfiguration oauthConfig = RealmHelper.executeTransactionForRead(realm ->
         realm.where(MeteorLoginServiceConfiguration.class)
             .equalTo("service", "github")
-            .equalTo("serverConfig.id", serverConfigId)
+            .equalTo("serverConfigId", serverConfigId)
             .findFirst());
     if (serverConfig == null || oauthConfig == null) {
       throw new IllegalArgumentException(

app/src/main/java/chat/rocket/android/fragment/server_config/LoginFragment.java

@@ -25,7 +25,7 @@ public class LoginFragment extends AbstractServerConfigFragment {
       new RealmListObserver<MeteorLoginServiceConfiguration>() {
         @Override protected RealmResults<MeteorLoginServiceConfiguration> queryItems(Realm realm) {
           return realm.where(MeteorLoginServiceConfiguration.class)
-              .equalTo("serverConfig.id", serverConfigId)
+              .equalTo("serverConfigId", serverConfigId)
               .findAll();
         }
 

app/src/main/java/chat/rocket/android/model/MeteorLoginServiceConfiguration.java

@@ -10,7 +10,7 @@ import io.realm.annotations.PrimaryKey;
 public class MeteorLoginServiceConfiguration
     extends RealmObject {
   @PrimaryKey private String id;
-  private ServerConfig serverConfig;
+  private String serverConfigId;
   private String service;
   private String consumerKey; //for Twitter
   private String appId; //for Facebook
@@ -24,12 +24,12 @@ public class MeteorLoginServiceConfiguration
     this.id = id;
   }
 
-  public ServerConfig getServerConfig() {
-    return serverConfig;
+  public String getServerConfigId() {
+    return serverConfigId;
   }
 
-  public void setServerConfig(ServerConfig serverConfig) {
-    this.serverConfig = serverConfig;
+  public void setServerConfigId(String serverConfigId) {
+    this.serverConfigId = serverConfigId;
   }
 
   public String getService() {

app/src/main/java/chat/rocket/android/service/ddp_subscriber/AbstractDDPDocEventSubscriber.java

@@ -93,7 +93,7 @@ abstract class AbstractDDPDocEventSubscriber implements Registerable {
   private void onDocumentAdded(Realm realm, DDPSubscription.Added docEvent) throws JSONException {
     //executed in RealmTransaction
     JSONObject json = new JSONObject().put("id", docEvent.docID);
-    json.put("serverConfig", new JSONObject().put("id", serverConfigId));
+    json.put("serverConfigId", serverConfigId);
     mergeJson(json, docEvent.fields);
     realm.createOrUpdateObjectFromJson(getModelClass(), customizeFieldJson(json));
   }
@@ -109,7 +109,7 @@ abstract class AbstractDDPDocEventSubscriber implements Registerable {
       throws JSONException {
     //executed in RealmTransaction
     JSONObject json = new JSONObject().put("id", docEvent.docID);
-    json.put("serverConfig", new JSONObject().put("id", serverConfigId));
+    json.put("serverConfigId", serverConfigId);
     for (int i = 0; i < docEvent.cleared.length(); i++) {
       String fieldToDelete = docEvent.cleared.getString(i);
       json.put(fieldToDelete, JSONObject.NULL);