Unverified Commit 064485e3 authored by Filipe de Lima Brito's avatar Filipe de Lima Brito Committed by GitHub

Merge pull request #1437 from shubhsherl/feature_1394

[NEW] Notify new message in the chat room.
parents 649e1a9f f1444428
...@@ -255,10 +255,9 @@ class ChatRoomPresenter @Inject constructor( ...@@ -255,10 +255,9 @@ class ChatRoomPresenter @Inject constructor(
messagesRepository.save(newMessage) messagesRepository.save(newMessage)
view.showNewMessage( view.showNewMessage(
mapper.map( mapper.map(
newMessage, RoomUiModel( newMessage,
roles = chatRoles, isBroadcast = chatIsBroadcast RoomUiModel(roles = chatRoles, isBroadcast = chatIsBroadcast)
) ), false
)
) )
client.sendMessage(id, chatRoomId, text) client.sendMessage(id, chatRoomId, text)
} catch (ex: Exception) { } catch (ex: Exception) {
...@@ -473,7 +472,7 @@ class ChatRoomPresenter @Inject constructor( ...@@ -473,7 +472,7 @@ class ChatRoomPresenter @Inject constructor(
messagesRepository.saveAll(messages.result) messagesRepository.saveAll(messages.result)
launchUI(strategy) { launchUI(strategy) {
view.showNewMessage(models) view.showNewMessage(models, true)
} }
if (messages.result.size == 50) { if (messages.result.size == 50) {
...@@ -990,7 +989,7 @@ class ChatRoomPresenter @Inject constructor( ...@@ -990,7 +989,7 @@ class ChatRoomPresenter @Inject constructor(
} else { } else {
Timber.d("Adding new message") Timber.d("Adding new message")
messagesRepository.save(streamedMessage) messagesRepository.save(streamedMessage)
view.showNewMessage(viewModelStreamedMessage) view.showNewMessage(viewModelStreamedMessage, true)
} }
} }
} }
......
...@@ -60,7 +60,7 @@ interface ChatRoomView : LoadingView, MessageView { ...@@ -60,7 +60,7 @@ interface ChatRoomView : LoadingView, MessageView {
* *
* @param message The (recent) message sent to a chat room. * @param message The (recent) message sent to a chat room.
*/ */
fun showNewMessage(message: List<BaseUiModel<*>>) fun showNewMessage(message: List<BaseUiModel<*>>, isMessageReceived: Boolean)
/** /**
* Dispatch to the recycler views adapter that we should remove a message. * Dispatch to the recycler views adapter that we should remove a message.
......
...@@ -133,6 +133,7 @@ class ChatRoomFragment : Fragment(), ChatRoomView, EmojiKeyboardListener, EmojiR ...@@ -133,6 +133,7 @@ class ChatRoomFragment : Fragment(), ChatRoomView, EmojiKeyboardListener, EmojiR
internal lateinit var chatRoomId: String internal lateinit var chatRoomId: String
private lateinit var chatRoomName: String private lateinit var chatRoomName: String
private lateinit var chatRoomType: String private lateinit var chatRoomType: String
private var newMessageCount: Int = 0
private var chatRoomMessage: String? = null private var chatRoomMessage: String? = null
private var isSubscribed: Boolean = true private var isSubscribed: Boolean = true
private var isReadOnly: Boolean = false private var isReadOnly: Boolean = false
...@@ -448,10 +449,13 @@ class ChatRoomFragment : Fragment(), ChatRoomView, EmojiKeyboardListener, EmojiR ...@@ -448,10 +449,13 @@ class ChatRoomFragment : Fragment(), ChatRoomView, EmojiKeyboardListener, EmojiR
private val fabScrollListener = object : RecyclerView.OnScrollListener() { private val fabScrollListener = object : RecyclerView.OnScrollListener() {
override fun onScrolled(recyclerView: RecyclerView, dx: Int, dy: Int) { override fun onScrolled(recyclerView: RecyclerView, dx: Int, dy: Int) {
if (!recyclerView.canScrollVertically(1)) { if (!recyclerView.canScrollVertically(1)) {
text_count.isVisible = false
button_fab.hide() button_fab.hide()
newMessageCount = 0
} else { } else {
if (dy < 0 && !button_fab.isVisible) { if (dy < 0 && !button_fab.isVisible) {
button_fab.show() button_fab.show()
if (newMessageCount !=0) text_count.isVisible = true
} }
} }
} }
...@@ -504,9 +508,21 @@ class ChatRoomFragment : Fragment(), ChatRoomView, EmojiKeyboardListener, EmojiR ...@@ -504,9 +508,21 @@ class ChatRoomFragment : Fragment(), ChatRoomView, EmojiKeyboardListener, EmojiR
showMessage(getString(R.string.msg_invalid_file)) showMessage(getString(R.string.msg_invalid_file))
} }
override fun showNewMessage(message: List<BaseUiModel<*>>) { override fun showNewMessage(message: List<BaseUiModel<*>>, isMessageReceived: Boolean) {
ui { ui {
adapter.prependData(message) adapter.prependData(message)
if (isMessageReceived && button_fab.isVisible) {
newMessageCount++
if (newMessageCount <= 99)
text_count.text = newMessageCount.toString()
else
text_count.text = "99+"
text_count.isVisible = true
}
else if (!button_fab.isVisible)
recycler_view.scrollToPosition(0)
verticalScrollOffset.set(0) verticalScrollOffset.set(0)
empty_chat_view.isVisible = adapter.itemCount == 0 empty_chat_view.isVisible = adapter.itemCount == 0
} }
...@@ -742,7 +758,9 @@ class ChatRoomFragment : Fragment(), ChatRoomView, EmojiKeyboardListener, EmojiR ...@@ -742,7 +758,9 @@ class ChatRoomFragment : Fragment(), ChatRoomView, EmojiKeyboardListener, EmojiR
button_fab.setOnClickListener { button_fab.setOnClickListener {
recycler_view.scrollToPosition(0) recycler_view.scrollToPosition(0)
verticalScrollOffset.set(0) verticalScrollOffset.set(0)
text_count.isVisible = false
button_fab.hide() button_fab.hide()
newMessageCount = 0
} }
} }
......
<shape xmlns:android="http://schemas.android.com/apk/res/android"
android:shape="oval">
<solid android:color="@color/colorAccent" />
<size
android:width="20dp"
android:height="20dp" />
</shape>
\ No newline at end of file
...@@ -10,18 +10,40 @@ ...@@ -10,18 +10,40 @@
android:layout_height="match_parent" android:layout_height="match_parent"
android:scrollbars="vertical" /> android:scrollbars="vertical" />
<com.google.android.material.floatingactionbutton.FloatingActionButton <RelativeLayout
android:id="@+id/button_fab"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_margin="16dp" android:layout_alignParentEnd="true"
android:src="@drawable/ic_arrow_downward_24dp" android:layout_alignParentBottom="true"
android:theme="@style/Theme.AppCompat"
android:tint="@color/actionMenuColor"
android:visibility="invisible"
app:backgroundTint="@color/colorWhite"
app:fabSize="mini"
app:layout_anchor="@id/recycler_view" app:layout_anchor="@id/recycler_view"
app:layout_anchorGravity="bottom|end" /> app:layout_anchorGravity="bottom|end">
<com.google.android.material.floatingactionbutton.FloatingActionButton
android:id="@+id/button_fab"
android:layout_alignParentEnd="true"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:visibility="invisible"
android:layout_margin="16dp"
android:src="@drawable/ic_arrow_downward_24dp"
android:theme="@style/Theme.AppCompat"
android:tint="@color/actionMenuColor"
app:backgroundTint="@color/colorWhite"
app:fabSize="mini" />
<TextView
android:id="@+id/text_count"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:elevation="7dp"
android:padding="2dp"
android:gravity="center"
android:layout_margin="10dp"
android:textColor="@color/colorWhite"
android:visibility="invisible"
android:layout_alignParentEnd="true"
android:textSize="@dimen/message_time_text_size"
android:background="@drawable/round_textview" />
</RelativeLayout>
</androidx.coordinatorlayout.widget.CoordinatorLayout> </androidx.coordinatorlayout.widget.CoordinatorLayout>
\ No newline at end of file
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment