Commit 1a327b59 authored by Luci Stanescu's avatar Luci Stanescu

Added comment about the lack of a parent on the IncomingDialog

parent 15b35a29
...@@ -1930,7 +1930,7 @@ class SessionManager(object): ...@@ -1930,7 +1930,7 @@ class SessionManager(object):
video_stream = video_streams[0] if video_streams else None video_stream = video_streams[0] if video_streams else None
chat_stream = chat_streams[0] if chat_streams else None chat_stream = chat_streams[0] if chat_streams else None
desktopsharing_stream = desktopsharing_streams[0] if desktopsharing_streams else None desktopsharing_stream = desktopsharing_streams[0] if desktopsharing_streams else None
dialog = IncomingDialog() dialog = IncomingDialog() # The dialog is constructed without the main window as parent so that on Linux it is displayed on the current workspace rather than the one on which the main window resides.
incoming_session = IncomingSession(dialog, session, contact, proposal=False, audio_stream=audio_stream, video_stream=video_stream, chat_stream=chat_stream, desktopsharing_stream=desktopsharing_stream) incoming_session = IncomingSession(dialog, session, contact, proposal=False, audio_stream=audio_stream, video_stream=video_stream, chat_stream=chat_stream, desktopsharing_stream=desktopsharing_stream)
bisect.insort_right(self.incoming_sessions, incoming_session) bisect.insort_right(self.incoming_sessions, incoming_session)
incoming_session.accepted.connect(partial(self._SH_IncomingSessionAccepted, incoming_session)) incoming_session.accepted.connect(partial(self._SH_IncomingSessionAccepted, incoming_session))
...@@ -1969,7 +1969,7 @@ class SessionManager(object): ...@@ -1969,7 +1969,7 @@ class SessionManager(object):
video_stream = video_streams[0] if video_streams else None video_stream = video_streams[0] if video_streams else None
chat_stream = chat_streams[0] if chat_streams else None chat_stream = chat_streams[0] if chat_streams else None
desktopsharing_stream = desktopsharing_streams[0] if desktopsharing_streams else None desktopsharing_stream = desktopsharing_streams[0] if desktopsharing_streams else None
dialog = IncomingDialog() dialog = IncomingDialog() # The dialog is constructed without the main window as parent so that on Linux it is displayed on the current workspace rather than the one on which the main window resides.
incoming_session = IncomingSession(dialog, session, contact, proposal=True, audio_stream=audio_stream, video_stream=video_stream, chat_stream=chat_stream, desktopsharing_stream=desktopsharing_stream) incoming_session = IncomingSession(dialog, session, contact, proposal=True, audio_stream=audio_stream, video_stream=video_stream, chat_stream=chat_stream, desktopsharing_stream=desktopsharing_stream)
bisect.insort_right(self.incoming_sessions, incoming_session) bisect.insort_right(self.incoming_sessions, incoming_session)
incoming_session.accepted.connect(partial(self._SH_IncomingSessionAccepted, incoming_session)) incoming_session.accepted.connect(partial(self._SH_IncomingSessionAccepted, incoming_session))
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment