Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
P
PHP-MySQLi-Database-Class
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Kulya
PHP-MySQLi-Database-Class
Commits
58938e24
Commit
58938e24
authored
May 07, 2014
by
Alexander Butenko
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Really sanitize orderBy and groupBy values
parent
1548e293
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
2 deletions
+3
-2
MysqliDb.php
MysqliDb.php
+2
-2
tests.php
tests.php
+1
-0
No files found.
MysqliDb.php
View file @
58938e24
...
...
@@ -339,7 +339,7 @@ class MysqliDb
{
$allowedDirection
=
Array
(
"ASC"
,
"DESC"
);
$orderbyDirection
=
strtoupper
(
trim
(
$orderbyDirection
));
$orderByField
=
filter_var
(
$orderByField
,
FILTER_SANITIZE_STRING
);
$orderByField
=
preg_replace
(
"/[^-a-z0-9\.\(\),]+/i"
,
''
,
$orderByField
);
if
(
empty
(
$orderbyDirection
)
||
!
in_array
(
$orderbyDirection
,
$allowedDirection
))
die
(
'Wrong order direction: '
.
$orderbyDirection
);
...
...
@@ -359,7 +359,7 @@ class MysqliDb
*/
public
function
groupBy
(
$groupByField
)
{
$groupByField
=
filter_var
(
$groupByField
,
FILTER_SANITIZE_STRING
);
$groupByField
=
preg_replace
(
"/[^-a-z0-9\.\(\),]+/i"
,
''
,
$groupByField
);
$this
->
_groupBy
[]
=
$groupByField
;
return
$this
;
...
...
tests.php
View file @
58938e24
...
...
@@ -181,6 +181,7 @@ if ($db->count != 1) {
$db
->
join
(
"users u"
,
"p.userId=u.id"
,
"LEFT"
);
$db
->
where
(
"u.login"
,
'user2'
);
$db
->
orderBy
(
"CONCAT(u.login, u.firstName)"
);
$products
=
$db
->
get
(
"products p"
,
null
,
"u.login, p.productName"
);
if
(
$db
->
count
!=
2
)
{
echo
"Invalid products count on join ()"
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment