... but we already know that because we are performing one.

(cherry picked from commit 53ee7f57)

(cherry picked from commit 83969040)
(cherry picked from commit d88999b0)

(cherry picked from commit 85e4bef0)

(cherry picked from commit 235049b9)

PR: https://github.com/opnsense/core/issues/1275
(cherry picked from commit 621d703a)

(cherry picked from commit baa813eb)

(cherry picked from commit 09ed08e8)

(proxy, remote acl's) add option to disable cert validation, closes https://github.com/opnsense/core/issues/1271

(cherry picked from commit 1b442b8e)

(cherry picked from commit a2570701)

(legacy) ditch get_possible_traffic_source_addresses(), https://github.com/opnsense/core/issues/1257

(cherry picked from commit 18a991be)

(cherry picked from commit fc1a15df)

(captive portal) don't try to generate invalid vouchers, closes https://github.com/opnsense/core/issues/1253

Let's keep this simple for now, just don't leave the dialog as long as the input isn't valid yet....

(cherry picked from commit fc39bb33)

(cherry picked from commit 340da972)

We checked for IPs, but the code runs the service in all cases.

(cherry picked from commit d870e03d)

Should probably remove the weekly/daily rotation in favour of a
setting of the value in KB on the GUI instead...

(cherry picked from commit 19dfa96c)

o Mark interface used in case of interface tracking
o Don't inject local DNS server when there is no IP

PR: https://github.com/opnsense/core/issues/1273
(cherry picked from commit 0ec85692)

PR: https://github.com/opnsense/core/issues/1277
(cherry picked from commit df469d32)

PR: https://forum.opnsense.org/index.php?topic=3824
(cherry picked from commit 5d238412)

(cherry picked from commit daa45382)
(cherry picked from commit 3fcf1b3c)
(cherry picked from commit 0d17982b)
(cherry picked from commit fbf0005d)
(cherry picked from commit aedc25a1)
(cherry picked from commit 79da7c9a)
(cherry picked from commit 6138d557)
(cherry picked from commit ee09677b)
(cherry picked from commit a670d05c)
(cherry picked from commit e9d13d26)
(cherry picked from commit b9820b09)
(cherry picked from commit 4a7ff245)
(cherry picked from commit 2bb0f230)
(cherry picked from commit a5fc46bd)
(cherry picked from commit bed2dbd8)
(cherry picked from commit 1b5c6d1b)
(cherry picked from commit 7e75cf26)
(cherry picked from commit 2ca72533)
(cherry picked from commit 33c41b16)
(cherry picked from commit 7526194b)
(cherry picked from commit c602a7fd)

(cherry picked from commit b74970ee)

(cherry picked from commit 203732a9)

(cherry picked from commit ce6a5565)
(cherry picked from commit ce3bc611)

(cherry picked from commit fd987e63)
(cherry picked from commit b30940b5)
(cherry picked from commit d539e535)

(cherry picked from commit dd80bded)

(cherry picked from commit aaa48131)

(cherry picked from commit 3222d5b2)

(cherry picked from commit 504c947b)

(ipsec) fix syslog output, eventually we should switch to the new style loggers, but for now it's better to make sure charondebug is respected.

From the docs:

Starting with version 4.2.9, strongSwan provides a much more flexible configuration of the loggers. Logger configurations in strongswan.conf have a higher priority than charondebug in ipsec.conf: If you define any loggers in strongswan.conf, charondebug does not have any effect at all.

(cherry picked from commit b9392f59)

Getting crowded...

(cherry picked from commit ce942771)

(proxy) add ftp support again for remote acl download. We switched to python's requests library, which doesn't support ftp. Some people still use ftp though.

(cherry picked from commit c3e84685)

(cherry picked from commit ad0109f6)

(cherry picked from commit 499ce45b)

(cherry picked from commit dd871c8e)

PR: https://forum.opnsense.org/index.php?topic=3976
(cherry picked from commit 8e013753)

We're switching to PHP 7.0 (or 7.1 maybe), php-suhosin seems dead,
and maybe someone wants to work on a newer python base.

(cherry picked from commit 33d00edd)

(cherry picked from commit 8a5b32bf)

IPFW and PF are used for more than just firewall and shaper, e.g.
NAT, policy routing or shaping, and the plugin framework supports
registering multiple user-facing services per file.

(cherry picked from commit 3b34f51f)
(cherry picked from commit ff0dcc4d)
(cherry picked from commit 5e1e138f)
(cherry picked from commit c8cb224b)