(cherry picked from commit dd80bded)

(cherry picked from commit aaa48131)

(cherry picked from commit 3222d5b2)

(cherry picked from commit 504c947b)

(ipsec) fix syslog output, eventually we should switch to the new style loggers, but for now it's better to make sure charondebug is respected.

From the docs:

Starting with version 4.2.9, strongSwan provides a much more flexible configuration of the loggers. Logger configurations in strongswan.conf have a higher priority than charondebug in ipsec.conf: If you define any loggers in strongswan.conf, charondebug does not have any effect at all.

(cherry picked from commit b9392f59)

Getting crowded...

(cherry picked from commit ce942771)

(proxy) add ftp support again for remote acl download. We switched to python's requests library, which doesn't support ftp. Some people still use ftp though.

(cherry picked from commit c3e84685)

(cherry picked from commit ad0109f6)

(cherry picked from commit 499ce45b)

(cherry picked from commit dd871c8e)

PR: https://forum.opnsense.org/index.php?topic=3976
(cherry picked from commit 8e013753)

We're switching to PHP 7.0 (or 7.1 maybe), php-suhosin seems dead,
and maybe someone wants to work on a newer python base.

(cherry picked from commit 33d00edd)

(cherry picked from commit 8a5b32bf)

IPFW and PF are used for more than just firewall and shaper, e.g.
NAT, policy routing or shaping, and the plugin framework supports
registering multiple user-facing services per file.

(cherry picked from commit 3b34f51f)
(cherry picked from commit ff0dcc4d)
(cherry picked from commit 5e1e138f)
(cherry picked from commit c8cb224b)

(cherry picked from commit 4a6a53bc)

(menusystem) it's ok to link to an item on the page, as long as we don't try to match it back on the server end

(cherry picked from commit d2bd0d52)
(cherry picked from commit 585b643f)

(cherry picked from commit bdb0fac6)

(cherry picked from commit 0a88cca3)

(cherry picked from commit 1583c0a1)

(auth/ldap) disable error reporting on connect, to prevent api to signal authentication errors as issues.

exception 'Exception' with message 'Error at /usr/local/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php:236 - ldap_bind(): Unable to bind to server: Invalid credentials (errno=2)' in /usr/local/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php:84
Stack trace:
 0 [internal function]: OPNsense\Base\ApiControllerBase->APIErrorHandler(2,

(cherry picked from commit 3fdb5a93)

(cherry picked from commit 83e21691)

(cherry picked from commit 1a37f39f)

(cherry picked from commit cb0d1842)

.. with either IGMP or FTP proxy.

(cherry picked from commit 44aaac4a)

(crashreport) something seems to trigger Phalcon\Mvc\View->render() before initialize() was called, not sure what it is, probably something changed in phalcon to trigger this in some cases.

exception 'Exception' with message 'The argument is not initialized or iterable()' in phalcon/mvc/view.zep:694
Stack trace:
 0 [internal function]: Phalcon\Mvc\View->_engineRender(Array, 'settings/listRu...', true, true, NULL)
 1 [internal function]: Phalcon\Mvc\View->render('settings', 'listRulesets', Array)
 2 /usr/local/opnsense/www/api.php(26): Phalcon\Mvc\Application->handle()

(cherry picked from commit 32e02ba0)

(cherry picked from commit 5632dfa0)

(cherry picked from commit e7268a99)

Quite some inconsistencies in this function, parameters that can't be set, lack of logic and code duplication.

* removes get_configured_pppoe_server_interfaces(), which can't work anyway... pppoe server interfaces are registered via the plugin itself.
* $dhcpv6ifconf['mode'] can't be set anywhere....
* don't try to revalidate rainterface
* collect "real interface" from dhcpif, shouldn't use carp if
* remove code duplication in dns collection
* move checks up for interface we should skip (when possible)
* RA subnets do not have any backend ties

PR: https://github.com/opnsense/core/issues/1196

(cherry picked from commit 607d8ecc)
(cherry picked from commit b3737522)
(cherry picked from commit 089a3f07)
(cherry picked from commit 89c7a39f)

Credits: https://redmine.pfsense.org/issues/4111
(cherry picked from commit 71275241)