1. 23 Jan, 2015 2 commits
  2. 21 Jan, 2015 4 commits
  3. 20 Jan, 2015 1 commit
  4. 19 Jan, 2015 1 commit
  5. 18 Jan, 2015 1 commit
  6. 16 Jan, 2015 2 commits
  7. 13 Jan, 2015 2 commits
  8. 11 Jan, 2015 10 commits
    • Franco Fichtner's avatar
      inc: remove a wee bit of over-engineering · 1b6984c7
      Franco Fichtner authored
      Hides complexity to make it easier to migrate away from
      the legacy 'check_reload_status' soon.
      1b6984c7
    • Franco Fichtner's avatar
      mvc: fix a couple of style errors · e40924c6
      Franco Fichtner authored
      e40924c6
    • Franco Fichtner's avatar
      3ff299e1
    • Franco Fichtner's avatar
      src: apply whitespace cleanups · 5e9ab6d8
      Franco Fichtner authored
      5e9ab6d8
    • Phil Davis's avatar
      Validation of y/n answers in setlanip · 6b1ca069
      Phil Davis authored
      At the moment the user can answer "yes" to most of the questions, but then later code only checks if the answer is "y". Thus you can type in "yes" in some places, have it accepted, but actually the negative action is taken. That is weird and will mess up people who try typing a whole string starting with "y".
      With this change it makes the user type one of "y", "yes", "n", "no". When they type 1 of those, it is turned into either "y" or "n". Then the existing implementation logic all works as expected.
      Hopefully this is the "final" version that fixes the behavior of the (y/n) questions.
      I also included the bit at 296-297 which adds the CIDR bit-count range to the prompt, so the user can see exactly what input is valid/expected there.
      Redmine issue #4100
      6b1ca069
    • Phil Davis's avatar
      rc.initial.setlanip fix validation of CIDR within range · e19ddeff
      Phil Davis authored
      Currently this allows the user to input any number for the CIDR. I happened to try 44 for an IPv4 CIDR when playing.
      This fixes that little bug - I think it is good to commit that first/separately so it can be identified apart from the other (y/n) checking/handling I am working on. Better to have separate commits for distinct bugs.
      e19ddeff
    • Phil Davis's avatar
      Fixup dhcpd interface enabled check · 8df5a57b
      Phil Davis authored
      8df5a57b
    • Phil Davis's avatar
      Fix console set interface IP address · 83d40310
      Phil Davis authored
      Problem as per forum https://forum.pfsense.org/index.php?topic=83651.0
      The problem comes whenever services_dhcpd_configure is called - the global $config gets reset from the actual current config, and any pending changes in the current process are lost.
      It was introduced by commit 86ce2df
      in which services_dhcpdv4_configure() does:
      
      require_once('pkg-utils.inc')
      
      and pkg-utils.inc does various stuff like:
      
      if(file_exists("/cf/conf/use_xmlreader"))
      require_once("xmlreader.inc");
      else
      require_once("xmlparse.inc");
      
      which seems to cause a reset of the $config variable, thus losing the pending changes the user has entered at the console.
      
      The top-level code in rc.initial.setlanip really does not need to (and should not) implement any changes along the way - it should collect all the answers from the user, then write_config and then make all the necessary calls to routines to implement the changes on the running system. This fixes it - defer any calls to services_dhcpd_configure() until after all questions are answered and write_config has happened.
      83d40310
    • Phil Davis's avatar
      Set interface address from consol tidy output · d6516133
      Phil Davis authored
      While trying to see why this is not working for me (forum https://forum.pfsense.org/index.php?topic=83651.0 ) I have fixed some little things:
      1) Get the new-lines right so the output of the restarting looks neat
      2) Fix a comparison that had just a single equal sign - it did not break anything real because the subsequent code was just text output to the console. Now that text output does take notice of the correctly-evaluated condition, and $interface is not overwritten.
      
      The issue in the forum post, about the interface IP address config not actually changing, is still the case, at least for me.
      
      IMO these little tidy ups might as well be committed. They make this code better!
      d6516133
    • Phil Davis's avatar
      Allow blank source port in diag_testport · c9fc7a45
      Phil Davis authored
      Reported by forum https://forum.pfsense.org/index.php?topic=86146.0
      Also, if there are input validation errors, save the user-entered data and re-display it, making it easier for the user to just correct the data in error and press Test again. It was blanking out all the entered data.
      c9fc7a45
  9. 09 Jan, 2015 6 commits
  10. 08 Jan, 2015 2 commits
  11. 07 Jan, 2015 2 commits
  12. 06 Jan, 2015 1 commit
  13. 04 Jan, 2015 1 commit
  14. 02 Jan, 2015 5 commits