(auth, legacy) proper error handling

e868dc56 · Ad Schellevis · b4dc3688 · e868dc56
Commit e868dc56 authored Oct 28, 2015 by Ad Schellevis
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 1 deletion

auth.inc src/etc/inc/auth.inc +6 -1

No files found.
--- a/src/etc/inc/auth.inc
+++ b/src/etc/inc/auth.inc
@@ -727,5 +727,10 @@ function authenticate_user($username, $password, $authcfg = NULL) {
 	$authFactory = new OPNsense\Auth\AuthenticationFactory;
 	$authenticator = $authFactory->get($authName);

-	return $authenticator->authenticate($username, $password) ;
+	if ($authenticator != null) {
+		return $authenticator->authenticate($username, $password) ;
+	} else {
+		log_error('Unable to retrieve authenticator for '. $authName);
+		return false;
+	}
 }