(menu / interfaces) empty description check fails

src/opnsense/mvc/app/controllers/OPNsense/Base/ControllerBase.php

@@ -206,7 +206,7 @@ class ControllerBase extends ControllerRoot
 
         $ifarr = array();
         foreach ($cnf->object()->interfaces->children() as $key => $node) {
-            $ifarr[$key] = $node->descr ? $node->descr->__toString() : strtoupper($key);
+            $ifarr[$key] = !empty($node->descr) ? $node->descr->__toString() : strtoupper($key);
         }
         natcasesort($ifarr);
         $ordid = 0;

src/www/head.inc

@@ -20,7 +20,7 @@ $menu = new OPNsense\Base\Menu\MenuSystem();
 $cnf = OPNsense\Core\Config::getInstance();
 $ifarr = array();
 foreach ($cnf->object()->interfaces->children() as $key => $node) {
-    $ifarr[$key] = $node->descr ? $node->descr->__toString() : strtoupper($key);
+    $ifarr[$key] = !empty($node->descr) ? $node->descr->__toString() : strtoupper($key);
 }
 natcasesort($ifarr);
 $ordid = 0;