auth: /usr/local/bin/scponly was never part of the base install

src/etc/inc/auth.inc

@@ -414,8 +414,6 @@ function local_user_set(&$user)
 	/* configure shell type */
 	if (userHasPrivilege($user, 'user-shell-access')) {
 		$user_shell = '/bin/csh';
-	} elseif (userHasPrivilege($user, 'user-copy-files')) {
-		$user_shell = '/usr/local/bin/scponly';
 	}
 
 	/* unlock valid shell users */

src/etc/inc/upgrade_config.inc

@@ -1356,9 +1356,6 @@ function upgrade_049_to_050()
 				case "hasshell":
 				$privs[] = "user-shell-access";
 				break;
-				case "copyfiles":
-				$privs[] = "user-copy-files";
-				break;
 			}
 		}
 		$user['priv'] = $privs;

src/opnsense/mvc/app/models/OPNsense/Core/ACL_Legacy_Page_Map.json

@@ -7,10 +7,6 @@
         "name": "User - Services - Captive portal login",
         "descr": "Indicates whether the user is able to login on the captive portal."
     },
-    "user-copy-files": {
-        "name": "User - System - Copy files",
-        "descr": "Indicates whether the user is allowed to copy files onto the  appliance via SCP\/SFTP."
-    },
     "user-shell-access": {
         "name": "User - System - Shell account access",
         "descr": "Indicates whether the user is able to login for example via SSH."