(legacy) crashreport, fix some input validation

9ddb9c0b · Ad Schellevis · Franco Fichtner · 52dce31b · 9ddb9c0b
Commit 9ddb9c0b authored Aug 04, 2015 by Ad Schellevis Committed by Franco Fichtner Aug 04, 2015
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 2 deletions

auth.inc src/etc/inc/auth.inc +8 -2

No files found.
--- a/src/etc/inc/auth.inc
+++ b/src/etc/inc/auth.inc
@@ -197,8 +197,10 @@ function index_groups()
 	if (isset($config['system']['group'])) {
 		$i = 0;
 		foreach($config['system']['group'] as $groupent) {
-			$groupindex[$groupent['name']] = $i;
+			if (isset($groupent['name'])) {
-			$i++;
+				$groupindex[$groupent['name']] = $i;
+				$i++;
+			}
 		}
 	}
@@ -584,6 +586,10 @@ function local_group_del_user($user)
 function local_group_set($group, $reset = false)
 {
+	if (!isset($group['name']) || !isset($group['gid'])) {
+		// input data invalid
+		return false;
+	}
 	$group_name = $group['name'];
 	$group_gid = $group['gid'];
 	$group_members = '';