Fix EmailField type and add "if helpers.exists ..." to squid.conf

src/opnsense/mvc/app/models/OPNsense/Proxy/Proxy.xml

@@ -69,12 +69,12 @@
                 <default>0</default>
                 <Required>N</Required>
             </suppressVersion>
-            <VisibleEmail type="TextField">
-                <default>localhost</default>
+            <VisibleEmail type="EmailField">
+                <default>admin@localhost</default>
                 <Required>N</Required>
             </VisibleEmail>
             <VisibleHostname type="TextField">
-                <default>admin@localhost</default>
+                <default>localhost</default>
                 <Required>N</Required>
             </VisibleHostname>
             <cache>

src/opnsense/service/templates/OPNsense/Proxy/squid.conf

@@ -523,7 +523,11 @@ delay_parameters 1 {{OPNsense.proxy.general.traffic.OverallBandwidthTrotteling|i
 {% endif %}
 # Disable squid logfile rotate to use system defaults
 logfile_rotate 0
+{% if helpers.exists('OPNsense.proxy.general.VisibleHostname') %}
 # Define visible hostname
 visible_hostname {{OPNsense.proxy.general.VisibleHostname}}
+{% endif %}
+{% if helpers.exists('OPNsense.proxy.general.VisibleEmail') %}
 # Define visible email
 cache_mgr {{OPNsense.proxy.general.VisibleEmail}}
+{% endif %}