firewall: tweak previous for #504

(cherry picked from commit b1256d80)

src/www/firewall_rules.php

@@ -436,23 +436,17 @@ $( document ).ready(function() {
 <?php
                       elseif (!empty($filterent['direction']) && $filterent['direction'] == "any"):?>
                         <i class="fa fa-arrows-h" data-toggle="tooltip" data-placement="left" title="<?=gettext("any");?>"></i>
-<?php
-                      endif;?>
-<?php
-                      if ($selected_if != 'FloatingRules'):
-                        ; // all other interfaces are always quick
-                      elseif(!empty($filterent['quick'])): ?>
-                        <i class="fa fa-flash <?= ($filterent['quick'] == 'yes') ? 'text-warning' : 'text-muted' ?>" data-toggle="tooltip" data-placement="left" title="<?= ($filterent['quick'] == 'yes') ? gettext('first match') : gettext('last match') ?>"></i>
-<?php
-                      else: ?>
+<?php                 endif;?>
+<?php                 if ($selected_if != 'FloatingRules'):
+                        ; // interfaces are always quick
+                      elseif (isset($filterent['quick']) && $filterent['quick'] === 'yes'): ?>
+                        <i class="fa fa-flash text-warning" data-toggle="tooltip" data-placement="left" title="<?= gettext('first match') ?>"></i>
+<?php                 else: ?>
                         <i class="fa fa-flash text-muted" data-toggle="tooltip" data-placement="left" title="<?= gettext('last match') ?>"></i>
 <?php                 endif; ?>
-
-<?php
-                      if (isset($filterent['log'])):?>
+<?php                 if (isset($filterent['log'])):?>
                       <span class="glyphicon glyphicon-info-sign <?=!empty($filterent['disabled']) ? "text-muted" :""?>"></span>
-<?php
-                      endif; ?>
+<?php                 endif; ?>
                     </td>
                     <td>
                         <?=$record_ipprotocol;?>
@@ -609,8 +603,7 @@ $( document ).ready(function() {
                           <td width="100"><?=gettext("log");?></td>
                           <td width="16"><span class="fa fa-long-arrow-right"></span></td>
                           <td width="100"><?=gettext("in");?></td>
-<?php
-                          if ($selected_if == 'FloatingRules'): ?>
+<?php                     if ($selected_if == 'FloatingRules'): ?>
                           <td width="16"><span class="fa fa-flash text-warning"></span></td>
                           <td width="100"><?=gettext("first match");?></td>
 <?php                     endif; ?>
@@ -632,8 +625,7 @@ $( document ).ready(function() {
                           <td class="nowrap"><?=gettext("log (disabled)");?></td>
                           <td width="16"><span class="fa fa-long-arrow-left"></span></td>
                           <td width="100"><?=gettext("out");?></td>
-<?php
-                          if ($selected_if == 'FloatingRules'): ?>
+<?php                     if ($selected_if == 'FloatingRules'): ?>
                           <td width="16"><span class="fa fa-flash text-muted"></td>
                           <td width="100"><?=gettext("last match");?></td>
 <?php                     endif; ?>