unbound: removed no-duplicate host restriction

Previously it was not possible to add two host override entries for the same
host-domain combination. Technically this restriction does not exist neither
within unbound nor DNS.

src/etc/inc/unbound.inc

@@ -515,32 +515,27 @@ function unbound_add_host_entries() {
         $host_entries = "";
         $added_item = array();
         foreach($config['unbound']['hosts'] as $host) {
-            $current_host = $host['host'];
-            if ($host['host'] != "")
+            if ($host['host'] != "") {
                 $host['host'] = $host['host'].".";
-            if (!$added_item[$current_host]) {
-                /* Backwards compatibility for records created before introducing RR types. */
-                if (!isset($host['rr'])) {
-                    $host['rr'] = (is_ipaddrv6($host['ip'])) ? 'AAAA' : 'A';
-                }
-
-                switch ($host['rr']) {
-                    case 'A':
-                    case 'AAAA':
-                        $host_entries .= "local-data-ptr: \"{$host['ip']} {$host['host']}{$host['domain']}\"\n";
-                        $host_entries .= "local-data: \"{$host['host']}{$host['domain']} IN {$host['rr']} {$host['ip']}\"\n";
-                        break;
-                    case 'MX':
-                        $host_entries .= "local-data: \"{$host['host']}{$host['domain']} IN MX {$host['mxprio']} {$host['mx']}\"\n";
-                        break;
-                }
+            }
+            /* Backwards compatibility for records created before introducing RR types. */
+            if (!isset($host['rr'])) {
+                $host['rr'] = (is_ipaddrv6($host['ip'])) ? 'AAAA' : 'A';
+            }
 
-                if (!empty($host['descr']) && isset($config['unbound']['txtsupport'])) {
-                    $host_entries .= "local-data: '{$host['host']}{$host['domain']} TXT \"".addslashes($host['descr'])."\"'\n";
-                }
+            switch ($host['rr']) {
+                case 'A':
+                case 'AAAA':
+                    $host_entries .= "local-data-ptr: \"{$host['ip']} {$host['host']}{$host['domain']}\"\n";
+                    $host_entries .= "local-data: \"{$host['host']}{$host['domain']} IN {$host['rr']} {$host['ip']}\"\n";
+                    break;
+                case 'MX':
+                    $host_entries .= "local-data: \"{$host['host']}{$host['domain']} IN MX {$host['mxprio']} {$host['mx']}\"\n";
+                    break;
+            }
 
-                // Do not add duplicate entries
-                $added_item[$current_host] = true;
+            if (!empty($host['descr']) && isset($config['unbound']['txtsupport'])) {
+                $host_entries .= "local-data: '{$host['host']}{$host['domain']} TXT \"".addslashes($host['descr'])."\"'\n";
             }
         }
         $unbound_entries .= $host_entries;

src/www/services_unbound_host_edit.php

@@ -158,18 +158,6 @@ if ($_POST) {
 			$input_errors[] = gettext("A valid domain must be specified in alias list.");
 	}
 
-	/* check for overlaps */
-	foreach ($a_hosts as $hostent) {
-		if (isset($id) && ($a_hosts[$id]) && ($a_hosts[$id] === $hostent))
-			continue;
-
-		if (($hostent['host'] == $_POST['host']) && ($hostent['domain'] == $_POST['domain'])
-			&& ((is_ipaddrv4($hostent['ip']) && is_ipaddrv4($_POST['ip'])) || (is_ipaddrv6($hostent['ip']) && is_ipaddrv6($_POST['ip'])))) {
-			$input_errors[] = gettext("This host/domain already exists.");
-			break;
-		}
-	}
-
 	if (!$input_errors) {
 		$hostent = array();
 		$hostent['host'] = $_POST['host'];