firewall: mark deprecated ICMP types; closes #912

Taken from: http://www.iana.org/assignments/icmp-parameters/icmp-parameters.xhtml

(cherry picked from commit aa21adfe)

src/www/firewall_rules.php

@@ -501,22 +501,22 @@ $( document ).ready(function() {
 <?php
                         $icmptypes = array(
                           "" => gettext("any"),
-                          "echoreq" => gettext("Echo request"),
-                          "echorep" => gettext("Echo reply"),
-                          "unreach" => gettext("Destination unreachable"),
-                          "squench" => gettext("Source quench"),
+                          "echoreq" => gettext("Echo Request"),
+                          "echorep" => gettext("Echo Reply"),
+                          "unreach" => gettext("Destination Unreachable"),
+                          "squench" => gettext("Source Quench (Deprecated)"),
                           "redir" => gettext("Redirect"),
-                          "althost" => gettext("Alternate Host"),
-                          "routeradv" => gettext("Router advertisement"),
-                          "routersol" => gettext("Router solicitation"),
-                          "timex" => gettext("Time exceeded"),
-                          "paramprob" => gettext("Invalid IP header"),
+                          "althost" => gettext("Alternate Host Address (Deprecated)"),
+                          "routeradv" => gettext("Router Advertisement"),
+                          "routersol" => gettext("Router Solicitation"),
+                          "timex" => gettext("Time Exceeded"),
+                          "paramprob" => gettext("Parameter Problem"),
                           "timereq" => gettext("Timestamp"),
-                          "timerep" => gettext("Timestamp reply"),
-                          "inforeq" => gettext("Information request"),
-                          "inforep" => gettext("Information reply"),
-                          "maskreq" => gettext("Address mask request"),
-                          "maskrep" => gettext("Address mask reply")
+                          "timerep" => gettext("Timestamp Reply"),
+                          "inforeq" => gettext("Information Request (Deprecated)"),
+                          "inforep" => gettext("Information Reply (Deprecated)"),
+                          "maskreq" => gettext("Address Mask Request (Deprecated)"),
+                          "maskrep" => gettext("Address Mask Reply (Deprecated)")
                         );
                         if (isset($filterent['protocol']) && $filterent['protocol'] == "icmp" && !empty($filterent['icmptype'])):
 ?>

src/www/firewall_rules_edit.php

@@ -856,22 +856,22 @@ include("head.inc");
 <?php
                       $icmptypes = array(
                       "" => gettext("any"),
-                      "echoreq" => gettext("Echo request"),
-                      "echorep" => gettext("Echo reply"),
-                      "unreach" => gettext("Destination unreachable"),
-                      "squench" => gettext("Source quench"),
+                      "echoreq" => gettext("Echo Request"),
+                      "echorep" => gettext("Echo Reply"),
+                      "unreach" => gettext("Destination Unreachable"),
+                      "squench" => gettext("Source Quench (Deprecated)"),
                       "redir" => gettext("Redirect"),
-                      "althost" => gettext("Alternate Host"),
-                      "routeradv" => gettext("Router advertisement"),
-                      "routersol" => gettext("Router solicitation"),
-                      "timex" => gettext("Time exceeded"),
-                      "paramprob" => gettext("Invalid IP header"),
+                      "althost" => gettext("Alternate Host Address (Deprecated)"),
+                      "routeradv" => gettext("Router Advertisement"),
+                      "routersol" => gettext("Router Solicitation"),
+                      "timex" => gettext("Time Exceeded"),
+                      "paramprob" => gettext("Parameter Problem"),
                       "timereq" => gettext("Timestamp"),
-                      "timerep" => gettext("Timestamp reply"),
-                      "inforeq" => gettext("Information request"),
-                      "inforep" => gettext("Information reply"),
-                      "maskreq" => gettext("Address mask request"),
-                      "maskrep" => gettext("Address mask reply")
+                      "timerep" => gettext("Timestamp Reply"),
+                      "inforeq" => gettext("Information Request (Deprecated)"),
+                      "inforep" => gettext("Information Reply (Deprecated)"),
+                      "maskreq" => gettext("Address Mask Request (Deprecated)"),
+                      "maskrep" => gettext("Address Mask Reply (Deprecated)")
                       );
 
                       foreach ($icmptypes as $icmptype => $descr): ?>