firmware: reconfigure on reload; kill backend webgui call

Backend can't call tainted code that may run configd again.  This needs
to be cleaned up.  Ideally, the backend should only call python code.

(cherry picked from commit 4f43181d)

src/etc/rc.restart_webgui

@@ -5,14 +5,16 @@ require_once('config.inc');
 require_once('interfaces.inc');
 require_once('captiveportal.inc');
 require_once('rrd.inc');
-require_once("util.inc");
-require_once("system.inc");
+require_once('util.inc');
+require_once('system.inc');
 
 if (count($argv) > 1 && is_numeric($argv[1])) {
     // starting delayed.
     sleep($argv[1]);
 }
 
+system_firmware_configure();
+
 echo 'Restarting webConfigurator...';
 
 killbyname('lighttpd');

src/opnsense/service/conf/actions.d/actions_webgui.conf

-[reload|restart]
-command:/usr/local/etc/rc.restart_webgui
-parameters:%s
-type:script
-message:webConfigurator restart in progress

src/www/diag_logs_settings.php

@@ -206,7 +206,7 @@ if ($_POST['resetlogs'] == gettext("Reset Log Files")) {
 			ob_flush();
 			flush();
 			log_error(gettext("webConfigurator configuration has changed. Restarting webConfigurator."));
-			configd_run("webgui restart 2", true);
+			mwexec_bg('/usr/local/etc/rc.restart_webgui 2');
 			$savemsg .= "<br />" . gettext("WebGUI process is restarting.");
 		}
 

src/www/system_advanced_admin.php

@@ -684,5 +684,5 @@ if ($restart_webgui) {
     ob_flush();
     flush();
     log_error(gettext("webConfigurator configuration has changed. Restarting webConfigurator."));
-    configd_run("webgui restart 2", true);
+    mwexec_bg('/usr/local/etc/rc.restart_webgui 2');
 }