(firmware) add session close for long running api action

src/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php

@@ -46,6 +46,14 @@ class ApiControllerBase extends Controller
         $this->view->disable();
     }
 
+    /**
+     * Wrap close session, for long running operations.
+     */
+    protected function sessionClose()
+    {
+        session_write_close();
+    }
+
     /**
      * before routing event
      * @param Dispatcher $dispatcher
@@ -82,7 +90,7 @@ class ApiControllerBase extends Controller
 
     }
 
-        /**
+    /**
      * process API results, serialize return data to json.
      * @param $dispatcher
      * @return string json data

src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php

@@ -43,6 +43,7 @@ class FirmwareController extends ApiControllerBase
      */
     public function statusAction()
     {
+        $this->sessionClose(); // long running action, close session
         $backend = new Backend();
         $response = json_decode(trim($backend->configdRun("firmware pkgstatus")), true);
 

src/opnsense/mvc/app/controllers/OPNsense/Proxy/Api/ServiceController.php

@@ -106,7 +106,7 @@ class ServiceController extends ApiControllerBase
     public function reconfigureAction()
     {
         // close session for long running action
-        session_write_close();
+        $this->sessionClose();
 
         $mdlProxy = new Proxy();
         $backend = new Backend();