interfaces, refactor and rename get_interface_info() to remove most of the...

interfaces, refactor and rename get_interface_info() to remove most of the performance bottlenecks. for https://github.com/opnsense/core/issues/1662

src/www/status_interfaces.php

@@ -65,8 +65,9 @@ include("head.inc");
 <?php
             $mac_man = json_decode(configd_run("interface list macdb json"), true);
             $pfctl_counters = json_decode(configd_run("filter list counters json"), true);
+            $ifsinfo = get_interfaces_info();
             foreach (get_configured_interface_with_descr(false, true) as $ifdescr => $ifname):
-              $ifinfo = get_interface_info($ifdescr);
+              $ifinfo = $ifsinfo[$ifdescr];
               $ifpfcounters = $pfctl_counters[$ifinfo['if']];
               legacy_html_escape_form_data($ifinfo);
               $ifdescr = htmlspecialchars($ifdescr);

src/www/widgets/api/plugins/interfaces.inc

@@ -31,8 +31,9 @@
 function interfaces_api()
 {
     $result = array();
+    $ifsinfo = get_interfaces_info();
     foreach (get_configured_interface_with_descr() as $ifdescr => $ifname) {
-        $ifinfo = get_interface_info($ifdescr);
+        $ifinfo = $ifsinfo[$ifdescr];
         $interfaceItem = array();
         $interfaceItem['inpkts'] = $ifinfo['inpkts'];
         $interfaceItem['outpkts'] = $ifinfo['outpkts'];

src/www/widgets/widgets/interface_list.widget.php

@@ -68,8 +68,9 @@ require_once("interfaces.inc");
 <table class="table table-striped table-condensed" data-plugin="interfaces" data-callback="interface_widget_update">
   <tbody>
 <?php
+    $ifsinfo = get_interfaces_info();
     foreach (get_configured_interface_with_descr() as $ifdescr => $ifname):
-      $ifinfo = get_interface_info($ifdescr);
+      $ifinfo = $ifsinfo[$ifdescr];
       $iswireless = is_interface_wireless($ifdescr);?>
       <tr id="interface_widget_item_<?=$ifname;?>">
         <td>