cleanup traffic shaper

src/etc/inc/shaper.inc

@@ -2965,7 +2965,8 @@ class dnpipe_class extends dummynet_class {
 		foreach ($this->subqueues as $q)
 			$q->delete_queue();
 		unset_dn_object_by_reference($this->GetLink());
-		@pfSense_pipe_action("pipe delete " . $this->GetNumber());
+		// TODO: re-enable after kernel fix for dummynet
+		// @pfSense_pipe_action("pipe delete " . $this->GetNumber());
 	}
 	function GetBandwidth() {
 		return $this->qbandwidth;
@@ -3509,7 +3510,8 @@ class dnqueue_class extends dummynet_class {
 	function delete_queue() {
 		cleanup_dnqueue_from_rules($this->GetQname());
 		unset_dn_object_by_reference($this->GetLink());
-		@pfSense_pipe_action("queue delete " . $this->GetNumber());
+		// TODO: re-enable after kernel fix for dummynet
+		// @pfSense_pipe_action("queue delete " . $this->GetNumber());
 	}
 
 	function validate_input($data, &$input_errors) {

src/www/firewall_shaper_vinterface.php

@@ -48,24 +48,30 @@ read_dummynet_config();
  */
 
 if ($_GET) {
-	if ($_GET['queue'])
+	if (isset($_GET['queue'])) {
 		$qname = htmlspecialchars(trim($_GET['queue']));
-        if ($_GET['pipe'])
+        }
+        if (isset($_GET['pipe'])) {
                 $pipe = htmlspecialchars(trim($_GET['pipe']));
-        if ($_GET['action'])
+        }
+        if (isset($_GET['action'])) {
                 $action = htmlspecialchars($_GET['action']);
+        }
 }
 if ($_POST) {
-	if ($_POST['name'])
+	if (isset($_POST['name'])) {
 		$qname = htmlspecialchars(trim($_POST['name']));
-	else if ($_POST['newname'])
+        } else if (isset($_POST['newname'])) {
 		$qname = htmlspecialchars(trim($_POST['newname']));
-        if ($_POST['pipe'])
+        }
+        if (isset($_POST['pipe'])) {
 		$pipe = htmlspecialchars(trim($_POST['pipe']));
-	else
+        } else {
 		$pipe = htmlspecialchars(trim($qname));
-	if ($_POST['parentqueue'])
+        }
+	if (isset($_POST['parentqueue'])) {
 		$parentqueue = htmlspecialchars(trim($_POST['parentqueue']));
+        }
 }
 
 if ($pipe) {